Scripting Helpers is winding down operations and is now read-only. More info→

My game is giving tools to everyone in the server? lol please help if you are smart

Asked by

maxpax2009 340

5 years ago

So, to start off with..

It is in a Local Script.

I'm creating a shop script, that you can only buy items with points. When someone purchases the tool with points; everyone gets the tool?

I'm very concerned.

Here's the script:

01local Part = game.Workspace.BuyPart
02local RS = game:GetService("ReplicatedStorage")
03local Sword = RS.Tools:FindFirstChild("SpeedCoil")
04local Players = game:GetService("Players")
05local Debounce = false
06 
07Part.Touched:Connect(function(hit)
08    local Player = game.Players.LocalPlayer
09    if Player.leaderstats.Points.Value >= 500 then
10        if not Debounce then
11            Debounce = true
12        Sword.Parent = Player.Backpack
13        wait(10)
14        Debounce = false
15    end
16 
17    local GravityCoil = RS.Tools:FindFirstChild("GravityCoil")
18    local Part1 = game.Workspace.BuyPart1
19 
20    Part1.Touched:Connect(function(hit)
21        if hit.Parent:FindFirstChild("Humanoid") then
22 
23            if Player.leaderstats.Points.Value >= 7000 then
24                if not Debounce then
25                    Debounce = true
26                GravityCoil.Parent = Player.Backpack
27                wait(10)
28                Debounce = false
29    end
30 
31    local Part2 = game.Workspace.BuyPart2
32    local Tool = RS.Tools:FindFirstChild("PointGiverTool")
33 
34    Part2.Touched:Connect(function(hit)
35if hit.Parent:FindFirstChild("Humanoid") then
36 
37            if Player.leaderstats.Points.Value >= 10000 then
38                if not Debounce then
39                    Debounce = true
40                Tool.Parent = Player.Backpack
41                wait(10)
42                Debounce = false
43            end
44            end
45            end
46            end)
47                end
48                end
49                end)
50                    end
51                    end)
 View all 51 lines...

Add a variable named coins set it to the amount you want then do coins.Value = coins.Value - Points.Value on line 10 and line 38 and line 24. JesseSong 3916 — 5y

3 answers

Answered by

Infocus 144

5 years ago

01--[[
02I optimized your script because there were placements that shouldn't have been made. Such as 3 other Touched events in a touch event.
03]]
04 
05local Part = game.Workspace.BuyPart
06local RS = game:GetService("ReplicatedStorage")
07local Sword = RS.Tools:FindFirstChild("SpeedCoil")
08local Players = game:GetService("Players")
09local Debounce = false
10local Player = game.Players.LocalPlayer
11 
12Part.Touched:connect(function(hit) -- I close each event after its done its job
13    if Player.leaderstats.Points.Value >= 500 and not Debounce then -- Can have multiple conditional statements in one line using 'and'
14        Debounce = true
15        Sword:Clone().Parent = Player.Backpack -- Clone the part to avoid repetition
16        wait(10)
17        Debounce = false
18    end
19end)
20 
21local GravityCoil = RS.Tools:FindFirstChild("GravityCoil")
22local Part1 = game.Workspace.BuyPart1
23 
24Part1.Touched:connect(function(hit)
25    if hit.Parent:findFirstChild("Humanoid") and Player.leaderstats.Points.Value >= 7000 and not Debounce then
26        Debounce = true
27        GravityCoil:Clone().Parent = Player.Backpack
28        wait(10)
29        Debounce = false
30    end
31end)
32 
33 
34local Part2 = game.Workspace.BuyPart2
35local Tool = RS.Tools:FindFirstChild("PointGiverTool")
36 
37Part2.Touched:connect(function(hit)
38    if hit.Parent:findFirstChild("Humanoid") and Player.leaderstats.Points.Value >= 10000 and not Debounce then
39        Debounce = true
40        Tool:Clone().Parent = Player.Backpack
41        wait(10)
42        Debounce = false
43    end
44end)
 View all 44 lines...

Obviously there are more efficient ways of doing this, like gathering them all and having them give the tools based on what value they are holding. I didn't want to alter your script beyond your current style or understanding. Im just giving ideas. Cheers Infocus 144 — 5y

I'm so happy now, you definitely taught me something. maxpax2009 340 — 5y

Glad to help Infocus 144 — 5y

Also what you did and what that script does it does it only for the local player. Changing the local player and using GetPlayerFromCharacter allows it so anyone can use that. Unless the script is given to everyone then you're fine Infocus 144 — 5y

Answered by

JesseSong 3916

5 years ago

Edited 5 years ago

That's because you didn't clone it to the backpack. If player has more points then you have to clone it to the backpack otherwise it wont work and will give the tools to everyone and.

Note: If you don't put clone this will just make the thing of the parent which you told the script plus if you want to make a bought script all you have to do is say

1coins = 10 -- you can name it to anything you want
2 
3coins.Value = coins.Value - Points.Value

Please upvote me if I am correct.

Answered by

Skychiild 4

5 years ago

Make sure they're not in Starterpack otherwise they'll be given to the player by default. Put the tools in ServerStorage and then clone them to the player when you need to.

Thats manually but you can do it with a script. JesseSong 3916 — 5y

My game is giving tools to everyone in the server? lol please help if you are smart

3 answers

Answer this question