Scripting Helpers is winding down operations and is now read-only. More info→

"Health Is Not A Valid Member of Player"?

Asked by

Loughdough 291

7 years ago

Edited 7 years ago

Hi, total noob to RemoteEvents here. I'm making a weapon. When the handle of the weapon is touched by somebody other than the Player who is attacking, it takes damage to the victim. I have two values, attacking and debounce. The code is inside a local script inside the tool. The RemoteEvent is in ReplicatedStorage, and the script is inside ServerScriptService.

The clip of the local script containing the :FireServer() looks like this:

01function onTouch(part)
02    if attacking == true and debounce == true then
03        if part.Parent.Name ~= player.Name then
04            local vhum = part.Parent:findFirstChild("Humanoid")
05            if vhum and vhum.Health > 0 then
06                game.ReplicatedStorage.RemoteEvents.TakeHealthFromWeapon:FireServer(player, vhum, damage)
07                attacking = false
08            end
09        end
10    end
11end

The script looks like this:

1function onTHFW(vhum, damage)
2    vhum.Health = vhum.Health - damage
3end
4 
5game.ReplicatedStorage.RemoteEvents.TakeHealthFromWeapon.OnServerEvent:connect(onTHFW)

When the tool is activated, I get this error from the Script:

"21:41:29.298 - Health is not a valid member of Player" ... "21:49:55.547 - Script 'ServerScriptService.Script', Line 3"

Any help is appreciated. Thanks. :} ~Loughdough

Health is not a valid member of Player. Use Player.Character.Humanoid.Health instead. abnotaddable 920 — 7y

1 answer

Answered by

movsb 242

7 years ago

Your problem is that on the server 'vhum' is the client (a fancy word for player) that is firing to the server.

When you fire parameters from the client to the server via a remote event, the first parameter on the server is the client that fired the data.

You are getting that error because Player.Health does not exist.

You should change your server code to this:

1game.ReplicatedStorage.RemoteEvents.TakeHealthFromWeapon.OnServerEvent:connect
2(function(Player, vhum, damage)
3    vhum.Health = vhum.Health - damage;
4end)

If you are confused still, lets say that player "Bob" hits player "Barney" with his sword; when Bob's client fires to the server, and you print(Player.Name), you would get the output Bob; and in your case if you also print(vhum.Name) then you would get Barney.

I hope this helped you out.

It's not getting any errors now, but now it's still not taking any damage.. I defined damage as "local damage = 30" at the beginning of the local script. Got any idea on how to fix this? :{ Loughdough 291 — 7y

I do, but it would take another entire answer to explain. It has to deal with how tools actually work in filtering enabled environments. I will edit my original answer to include some more information for you, but it may take a bit because i am usually very busy. movsb 242 — 7y

@laczka I'll just write another question. Feel free to answer it. Thanks for the help! Loughdough 291 — 7y

I have already gotten fairly far into the answer though :( movsb 242 — 7y

View all comments (2 more)

@laczka I think it gives you higher reputation if you have two accepted answers instead of one. Which is good! You can answer it here: https://scriptinghelpers.org/questions/44724/weapon-isnt-dealing-damage -- Thanks :} Loughdough 291 — 7y

Thanks, I will be sure to :) movsb 242 — 7y

"Health Is Not A Valid Member of Player"?

1 answer

Answer this question