Scripting Helpers is winding down operations and is now read-only. More info→

Weapon Isn't Dealing Damage?

Asked by

Loughdough 291

7 years ago

Edited 7 years ago

Hi, I wrote a question about the use of my RemoteEvents because of the error I was having. I now have no errors, but the script still does not deal damage to the player that is being attacked. The tool has one local script, a RemoteEvent in a folder in ReplicatedStorage, and a script in ServerScriptService to activate when the RemoteEvent is fired.

The local script is this:

01local player = game.Players.LocalPlayer
02local char = player.Character
03local hum = char:WaitForChild("Humanoid")
04 
05repeat wait() until char
06 
07repeat wait() until hum
08 
09local attackanim = script:WaitForChild("SlashAnim2")
10attackanim.Parent = char
11 
12local animtrack = hum:LoadAnimation(attackanim)
13 
14local tool = script.Parent
15 
16local damage = 30
17 
18local debounce = false
19local attacking = false
20local attackingtouch = false
21 
22local rs = game:GetService("RunService")
23local debris = game:GetService("Debris")
24 
25function onEquip()
26    enabled = true
27    animtrack:Stop()
28end
29 
30function onActivate()
31    if debounce == false then
32        debounce = true
33        attacking = true
34        attackingtouch = true
35 
36        animtrack:Play()
37 
38        wait(1)
39 
40        attackingtouch = false
41        debounce = false
42        attacking = false
43    end
44end
45 
46function onTouch(part)
47    if attackingtouch == true and debounce == true then
48        if part.Parent.Name ~= player.Name then
49            local vhum = part.Parent:findFirstChild("Humanoid")
50            if vhum and vhum.Health > 0 then
51                game.ReplicatedStorage.RemoteEvents.TakeHealthFromWeapon:FireServer(vhum, damage)
52                attackingtouch = false
53            end
54        end
55    end
56end
57 
58 
59function onUnequip()
60    enabled = false
61    animtrack:Stop()
62end
63 
64tool.Equipped:connect(onEquip)
65tool.Activated:connect(onActivate)
66tool.Handle.Touched:connect(onTouch)
67tool.Unequipped:connect(onUnequip)
 View all 67 lines...

The script in ServerScriptService looks like this:

1function onTHFW(Player, vhum, damage)
2    vhum.Health = vhum.Health - damage
3end
4 
5game.ReplicatedStorage.RemoteEvents.TakeHealthFromWeapon.OnServerEvent:connect(onTHFW)

As I said before, I get no errors. What am I doing wrong? Thanks. :} ~Loughdough

1 answer

Answered by

movsb 242

7 years ago

Edited 7 years ago

Ok; here I go:

The first thing you need to understand is that tools like swords, and guns are not very functional in a filtering enabled environment, unless they are replicated over both the server, and the cleint(s). To achieve this, you should usually store tools inside ReplicatedStorage, and clone the tool in replicated storage into a certain player's backpack down the road instead, however do not store your remote event inside of the tool; instead make sure your remote event is stored directly in ReplicatedStorage (i.e. so you could say game.ReplicatedStorage.my_remote_event)

From this point on, I will refer to your sword tool as 'Tool', and a standard remote event as 'r'

Typically to start a game, you would want to get the recent player that joined, and you typically do that with game.Players.PlayerAdded, however with filtering enabled, getting the player that joined is a bit different.

Insert a local script into game.StarterPlayer.StarterPlayerScripts; It's code should be something along the lines of:

`1`	`local` `r` `=` `game.ReplicatedStorage.remote_event;`

`2`	`r:FireServer("Join");`

this script is the script that fires to the server whenever its client joins the game. (this works because all local scripts are replicated to each client when they join a server)

Insert a server script (a script) into game.ServerScriptService that can manage cloning and giving out the Tool to every player when they join, or are re-spawned; its code should be something along the lines of:

01local r = game.ReplicatedStorage.remote_event;
02local my_tool = game.ReplicatedStorage.Tool;
03r.OnServerEvent:connect(function(plr, info)
04    if info == "Join" then
05--just to be on the safe side i am adding a waitforchild incase the player's backpack does not exist yet, since they just joined the server.
06        plr:WaitForChild("Backpack");
07        my_tool:Clone().Parent = plr.Backpack;
08    end
09--when the player's character is changed is essentially when the player is respawned, because ROBLOX has to create a new character for the player.
10    plr.Changed:connect(function(prop)
11        if prop == "Character" then
12            my_tool:Clone().Parent = plr.Backpack;
13        end
14    end)
15end)

I will be referring to this script as 'main' from this point on.

So now that the basics of Filtering enabled are all out of the way, lets get down to analyzing the code inside of the local script of your Tool; change its code to:

01local player = game.Players.LocalPlayer
02local r = game.ReplicatedStorage.remote_event;
03 
04local attackanim = script:WaitForChild("SlashAnim2")
05 
06local tool = script.Parent
07local damage = 30
08 
09local current_track;
10 
11local debounce = false;
12local attacking = false
13local attack_debounce = false;
14 
15--by the time a player activates a tool, their character, and humanoid will already be loaded in.
16tool.Activated:connect(function()
17    if not debounce then
18        debounce = true;
19        local hmd = player.Character:FindFirstChild("Humanoid");
20        current_track = hmd:LoadAnimation(attackanim);
21        attacking = true;
22        current_track:Play();
23        local event;
24        event = current_track.Stopped:connect(function()
25            attacking = false;
26            wait(0.2);
27            debounce = false;
28            event:disconnect();
29        end);
30    end
31end)
32 
33tool.Handle.Touched:connect(function(part)
34    if not attack_debounce then
35        attack_debounce = true;
36        if attacking then
37            local plr_hmd = part.Parent:FindFirstChild("Humanoid") or part.Parent.Parent:FindFirstChild("Humanoid"); --always take into account whether the tool hit an accessorie's Handle on the other player as well (i.e. part.Parent.Parent)
38            if plr_hmd ~= nil then
39                local plr_name = plr_hmd.Parent.Name;
40                if player.Name ~= plr_name then
41                    r:FireServer("Hit", plr_hmd.Parent, damage);
42                end
43            end
44        end
45        attack_debounce = false;
46    end
47end)
48 
49tool.Unequipped:connect(function()
50    if current_track ~= nil then
51        current_track:Stop();
52        current_track:Destroy();
53        current_track = nil;
54    end
55    attack_debounce = false;
56    attacking = false;
57    debounce = false;
58end)
 View all 58 lines...

We are using the same remote event for Tool, as we did for our join script. So now we can go back and edit main's code to something more like this so that it can also handle whenever a player attacks another player:

01local r = game.ReplicatedStorage.remote_event;
02local my_tool = game.ReplicatedStorage.Tool;
03r.OnServerEvent:connect(function(plr, ...)
04    local inf_table = {...};
05    if inf_table[1] == "Join" then
06--just to be on the safe side i am adding a waitforchild incase the player's backpack does not exist yet, since they just joined the server.
07        plr:WaitForChild("Backpack");
08        my_tool:Clone().Parent = plr.Backpack;
09    elseif inf_table[1] == "Hit" then
10        if game.Players:GetPlayerFromCharacter(inf_table[2]) then
11            inf_table[2].Humanoid:TakeDamage(inf_table[3]);
12        end
13    end
14--when the player's character is changed is essentially when the player is respawned, because ROBLOX has to create a new character for the player.
15    plr.Changed:connect(function(prop)
16        if prop == "Character" then
17            my_tool:Clone().Parent = plr.Backpack;
18        end
19    end)
20end)

I am too tired to explain any more, if you are still having problems with it, send me details and I will see what I can do to help.

I hope this helps you.

Sorry it took me a while to answer, but this answer is a pretty long one. movsb 242 — 7y

@laczka You really seem to know what you're doing. Thanks! ~Loughdough Loughdough 291 — 7y

I am always glad to help. :) movsb 242 — 7y

Weapon Isn't Dealing Damage?

1 answer

Answer this question