[CLOSED] leaderstats variables not saving for DataStoreService? [closed]

Asked by

4 years ago

Edited 4 years ago

I've been trying fix this problem of not saving my variables, I'm using 2 variables and I'm also using leaderstats with 2 intValues. I do not know why my data isn't saving. This is server script, and it's in ServerScriptService. The print statement at line 44 works, however, the print statement at line 64 doesn't.

01local DSS = game:GetService("DataStoreService")
02local mDS = DSS:GetDataStore("MyDataStore") 
03game.Players.PlayerAdded:Connect(function(player)
04    local key = player.UserId
05 
06    local leaderstats = Instance.new("Folder")
07    leaderstats.Name = "leaderstats"
08    leaderstats.Parent = player
09 
10    local wins = Instance.new("IntValue")
11    wins.Name = "Wins"
12    wins.Parent = leaderstats
13 
14    local xp = Instance.new("IntValue")
15    xp.Name = "XP"
16    xp.Parent = leaderstats
17 
18    local data 
19 
20    local success, ErrorCode = pcall(function()
21        return mDS:GetAsync(tostring(key))
22    end)
23 
24    if success then
25        if data then
26            wins.Value = data["Wins"]
27            xp.Value = data["XP"]
28        end
29    else
30        warn("Error while saving: "..ErrorCode)
31    end
32end)
33 
34game.Players.PlayerRemoving:Connect(function(player)
35    local key = player.UserId
36    local dataTable = {
37        Wins = player.leaderstats.Wins.Value,
38        XP = player.leaderstats.XP.Value
39    }
40    local success, ErrorCode = pcall(function()
41        mDS:SetAsync(tostring(key),dataTable)
42    end)
43    if success then
44        print("Data saved!")
45    else
46        warn("Error while saving: "..ErrorCode)
47    end
48 
49end)
50 
51game:BindToClose(function(player)
52    local key
53    for _, v in pairs(game:GetService('Players'):GetPlayers()) do
54        key = v.UserId
55        local dataTable = {
56            Wins = v.leaderstats.Wins.Value,
57            XP = v.leaderstats.XP.Value
58        }
59        spawn(function()
60            local success, ErrorCode = pcall(function()
61                mDS:SetAsync(tostring(key),dataTable)
62            end)
63            if success then
64                print("Data2 Saved!")
65            else
66                print("Error While Saving:"..ErrorCode)
67            end
68        end)
69    end
70end)
 View all 70 lines...

I've tested this both in-game and in studio and they do not work. Also, if possible, how can I change mDS:SetAsync to mDS:UpdateAsync? Any help is appreciated. Edit: I switched to DataStore2 (as recommended by some people and friends) and so far, it actually saved my data. To future people who read this, just because I used DataStore2, doesn't mean you should either. Use either DataStoreService or DataStore2, depending which one is easier. Best of luck, future developers!

I suspect that I might know the problem. Try moving the code out of the spawn(). If that works, then I will post an answer explaining it. gskw 1046 — 4y

That spawn is supposed to be just in case the code doesn't finish before the server shut down. Also it still doesn't work. Thanks for helping! Dovydas1118 1495 — 4y

The code will definitely execute before the game shuts down because it's in :BindToClose. AntiWorldliness 868 — 4y

Locked by JesseSong

This question has been locked to preserve its current state and prevent spam and unwanted comments and answers.

Why was this question closed?

[CLOSED] leaderstats variables not saving for DataStoreService? [closed]

Locked by JesseSong

1 answer