Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
2

Function not looping because of a nil value?

Asked by
coolmanHDMI 72
4 years ago

I need this loop to work so that he drops the block multiple times but it doesnt loop and says "attempt to call a nil value" pls help

view source
01function bloc()
02    local count = 1000
03    while count == 1000 do 
04    local gb = script.Parent.Health
05    local mp = game.Lighting.money
06    if gb <= 29999 then
07        wait(2)
08        mp:Clone()
09        mp.Parent = game.Workspace
10        mp.Position = script.Parent.Parent.HumanoidRootPart.Position
11    end
12    end
13script.Parent.HealthChanged:Connect(bloc)
14end
0
the error is that in output it says attempt to call a nil value and the script isnt looping coolmanHDMI 72 — 4y

3 answers

Log in to vote
1
Answered by
youtubemasterWOW 2741 Moderation Voter Community Moderator
4 years ago
Edited 4 years ago

Hello.

Issues:

  1. You attempted to connect your function inside the function you were trying to connect.

  2. You didn't create a variable for the cloned mp, so you'd be changing the parent of the money in Lighting, not the clone of it.

  3. You'd need a coroutine so the script wouldn't get stuck in the while count == 1000 loop.

Improvments:

  1. Use DataModel:GetService() instead of using the conditional dot operator.

  2. Use local before indexing your function.

  3. Set the mp's position before parenting it.

  4. Name the function more correctly so you don't get confused on what function is what.

Fixed code:

view source
01local function onHealthChanged()
02    local count = 1000
03 
04    coroutine.wrap(function()
05        while count == 1000 do 
06            local gb = script.Parent.Health
07            local mp = game:GetService("Lighting").money
08 
09            if gb <= 29999 then
10                wait(2)
11 
12                local clonedMp = mp:Clone()
13                clonedMp.Position = script.Parent.Parent.HumanoidRootPart.Position
14                clonedMp.Parent = workspace
15            end
16        end
17    end)()
18end
19 
20script.Parent.HealthChanged:Connect(onHealthChanged)

Please accept and upvote this answer if it helped!

0
@coolmanHDMI this works this is best answer ayuu_ondev 60 — 4y
Ad
Log in to vote
0
Answered by
ayuu_ondev 60
4 years ago
Edited 4 years ago

One thing I see is that you called your function in the function you wanted to call the proper script is

view source
01function bloc()
02    local count = 1000
03    while count == 1000 do 
04    local gb = script.Parent.Health
05    local mp = game.Lighting.money
06    if gb <= 29999 then
07        wait(2)
08        mp:Clone()
09        mp.Parent = game.Workspace
10        mp.Position = script.Parent.Parent.HumanoidRootPart.Position
11    end
12    end
13 
14end
15while true do
16    script.Parent.HealthChanged:Connect(bloc)
17end
0
Does this work @coolmanHDMI ayuu_ondev 60 — 4y
Log in to vote
0
Answered by
JesseSong 3916 Moderation Voter Community Moderator
4 years ago
Edited 4 years ago

Try this:

view source
01while (count) == 1000 do
02local function bloc()
03    local count = 1000
04    local gb = script.Parent.Health
05    local mp = game.Lighting.money
06    if gb <= 29999 then
07coroutine.wrap(function()
08        wait(2)
09        mp:Clone()
10        mp.Parent = game.Workspace
11        mp.Position = script.Parent.Parent.HumanoidRootPart.Position
12    end
13    end
14 
15end) ()
16end
17script.Parent.HealthChanged:Connect(bloc)

Answer this question