[SOLVED] This whitelist system that uses Datastore is not working and doesn't output any error?

Asked by

4 years ago

Edited 4 years ago

(Edit: fixed OnServerEvent and updated the GUI Code)

So I am making a Datastore whitelisting system, basically I can whitelist, unwhitelist, or view who is whitelisted via a GUI.

How my system works is to use RemoteFunctions (to return stuff, also don't get confused if the RemoteFunction name is UTGJRemoteEvent)

The problem is that my code doesn't work and doesn't output any error. And yes I enabled studio API access. (Because I was testing it on studio). When I clicked whitelist, unwhitelist, or get users whitelisted on my GUI, all of them say that is failed (I made a status system that can say wether it succeded or failed.), and my output says that it failed as well (I added a warn everytime Datastore fails)

Server script: (the datastore and code is classified.)

001local DataStore = game:GetService("DataStoreService")
002local UTGJDS = DataStore:GetDataStore("classified")
003 
004local remote = game.ReplicatedStorage:WaitForChild("UTGJRemoteEvent")
005local code = "classified"
006 
007game.Players.PlayerAdded:Connect(function(plr)
008    plr.Chatted:Connect(function(msg, recipient)
009        if string.lower(msg) == string.lower("giveutgj") and not recipient then
010            local getallowed, atable = pcall(function()
011                return UTGJDS:GetAsync("Username")
012            end)
013 
014            if getallowed then
015                for i, v in pairs(atable) do
016                    if plr.Name == v then
017                        local cloned = script:WaitForChild("AccessUI"):Clone()
018                        cloned.Parent = plr:WaitForChild("PlayerGui")
019                    end
020                end
021            else
022                warn("UTGJ get allowed table Datastore Error! Now Retrying..")
023                for i = 1, 5 do
024                    local getallowed2, atable2 = pcall(function()
025                        return UTGJDS:GetAsync("Username")
026                    end)
027 
028                    if getallowed2 then
029                        for i, v in pairs(atable2) do
030                            if plr.Name == v then
031                                local cloned = script:WaitForChild("AccessUI"):Clone()
032                                cloned.Parent = plr:WaitForChild("PlayerGui")
033                            end
034                        end
035                    else
036                        warn("UTGJ Update Datstore Error! Retrying..")
037                    end
038                end
039            end
040        end
041    end)
042end)
043 
044remote.OnServerInvoke = function(plr, action, username, vcode)
045    if vcode == code then
046        if action == "Whitelist" then
047            local dstable
048            local getsuccsess, ctable = pcall(function()
049                return UTGJDS:GetAsync("Username")
050            end)
051 
052            if getsuccsess then
053                dstable = ctable
054            else
055                if type(ctable) ~= "table" and type(ctable) == 'string' then
056                    warn("UTGJ whitelisting Datastore Error! Now Retrying..")
057                end
058                for i = 1, 5 do
059                    local getsuccsess2, ctable2 = pcall(function()
060                        return UTGJDS:GetAsync("Username")
061                    end)
062 
063                    if getsuccsess2 then
064                        dstable = ctable
065                    else
066                        warn("UTGJ whitelisting Datstore Error! Retrying..")
067                    end
068                end
069            end
070 
071            if dstable then
072                table.insert(dstable, #dstable + 1, username)
073                local updatesuccess, err = pcall(function()
074                    return UTGJDS:UpdateAsync("Username", dstable)
075                end)
076 
077                if updatesuccess then
078                    print("Successfully updated UTGJ username whitelist. New user added: "..username)
079                    return true
080                else
081                    warn("UTGJ Update Datastore Error! Now Retrying..")
082                    for i = 1, 5 do
083                        local getupdate2, err2 = pcall(function()
084                            return UTGJDS:UpdateAsync("Username", dstable)
085                        end)
086 
087                        if getupdate2 then
088                            print("Successfully updated UTGJ username whitelist. New user added: "..username)
089                            return true
090                        else
091                            warn("UTGJ Update Datstore Error! Retrying..")
092                        end
093                    end
094                end
095            end
096            return false
097        elseif action == "Unwhitelist" then
098            local dstableunwhitelist
099            local getsuccsessunwhitelist, dtable = pcall(function()
100                return UTGJDS:GetAsync("Username")
101            end)
102 
103            if getsuccsessunwhitelist then
104                dstableunwhitelist = dtable
105            else
106                warn("UTGJ unwhitelisting Datastore Error! Now Retrying..")
107                for i = 1, 5 do
108                    local getsuccsessunwhitelist2, dtable2 = pcall(function()
109                        return UTGJDS:GetAsync("Username")
110                    end)
111 
112                    if getsuccsessunwhitelist2 then
113                        dstableunwhitelist = dtable2
114                    else
115                        warn("UTGJ unwhitelisting Datstore Error! Retrying..")
116                    end
117                end
118            end
119 
120            if dstableunwhitelist then
121                for a, b in pairs(dstableunwhitelist) do
122                    if (username == dstableunwhitelist[a]) then
123                        table.remove(dstableunwhitelist, a)
124                    end
125                end
126                local updatesuccessunwhitelist, errunwhitelist = pcall(function()
127                    return UTGJDS:UpdateAsync("Username", dstableunwhitelist)
128                end)
129 
130                if updatesuccessunwhitelist then
131                    print("Successfully updated UTGJ username unwhitelist. Removed user: "..username)
132                    return true
133                else
134                    warn("UTGJ Update Datastore Error! Now Retrying..")
135                    for i = 1, 5 do
136                        local updateunwhitelist2, errunwhitelist2 = pcall(function()
137                            return UTGJDS:UpdateAsync("Username", dstableunwhitelist)
138                        end)
139 
140                        if updateunwhitelist2 then
141                            print("Successfully updated UTGJ username unwhitelist. Removed user: "..username)
142                            return true
143                        else
144                            warn("UTGJ Update Datstore Error! Retrying..")
145                        end
146                    end
147                end
148            end
149            return false
150        end
151    elseif action == "GetUserWhitelisted" then
152        local getusers, usertable = pcall(function()
153            return UTGJDS:GetAsync("Username")
154        end)
155 
156        if getusers then
157            return true, usertable
158        else
159            warn("UTGJ get users whitelisted Datastore Error! Now Retrying..")
160            for i = 1, 5 do
161                local getusers2, usertable2 = pcall(function()
162                    return UTGJDS:GetAsync("Username")
163                end)
164 
165                if getusers2 then
166                    return true, usertable2
167                else
168                    warn("UTGJ Update Datstore Error! Retrying..")
169                end
170            end
171        end
172        return false
173    else
174        warn("Unauthorized user "..plr.Name.." tried to use UTGJ Whitelister/Unwhitelister.")
175    end
176end
 View all 176 lines...

(I am sorry if it's hard to read)

GUI Code:

01local remote = game.ReplicatedStorage:WaitForChild("UTGJRemoteEvent")
02local code = ""
03 
04local openclose = script.Parent:WaitForChild("Open")
05local frame = script.Parent:WaitForChild("Frame")
06local usertextbox = frame:WaitForChild("Username")
07local whitelist = frame:WaitForChild("Whitelist")
08local unwhitelist = frame:WaitForChild("Unwhitelist")
09local status = frame:WaitForChild("status")
10local getuserframe = script.Parent:WaitForChild("GetUsersUTGJ")
11local textgetuser = getuserframe:WaitForChild("Users")
12local getuserbutton = getuserframe:WaitForChild("GetUsers")
13 
14openclose.MouseButton1Click:Connect(function()
15    if frame.Visible == true then
16        frame.Visible = false
17        getuserframe.Visible = false
18    else
19        frame.Visible = true
20        getuserframe.Visible = true
21    end
22end)
23 
24whitelist.MouseButton1Click:Connect(function()
25    if usertextbox.Text ~= "" or usertextbox.Text ~= " " or usertextbox.Text ~= "ItzEthanPlayz_YT" or usertextbox.Text ~= "hellomehaOof" then
26        local sucess = remote:InvokeServer("Whitelist", usertextbox.Text, code)
27 
28        if sucess then
29            status.Text = "Successfully whitelisted the user."
30            status.TextColor3 = Color3.fromRGB(0, 255, 0)
31        else
32            status.Text = "Failed while whitelisting the user."
33            status.TextColor3 = Color3.fromRGB(255, 0, 0)
34        end
35    end
36end)
37 
38unwhitelist.MouseButton1Click:Connect(function()
39    if usertextbox.Text ~= "" or usertextbox.Text ~= " " or usertextbox.Text ~= "ItzEthanPlayz_YT" or usertextbox.Text ~= "hellomehaOof" then
40        local sucess = remote:InvokeServer("Unwhitelist", usertextbox.Text, code)
41 
42        if sucess then
43            status.Text = "Successfully unwhitelisted the user."
44            status.TextColor3 = Color3.fromRGB(0, 255, 0)
45        else
46            status.Text = "Failed while unwhitelisting the user."
47            status.TextColor3 = Color3.fromRGB(255, 0, 0)
48        end
49    end
50end)
51 
52getuserbutton.MouseButton1Click:Connect(function()
53    local sucess, usertable = remote:InvokeServer("GetUserWhitelisted", "a", code)
54 
55    if sucess then
56        if type(usertable) == "table" then
57            for i, v in pairs(usertable) do
58                if textgetuser.Text ~= "" then
59                    textgetuser.Text = textgetuser.Text.." , "..v
60                else
61                    textgetuser.Text = v
62                end
63            end
64        else
65            textgetuser.Text = "Error. (Not a table.)"
66        end
67    else
68        textgetuser.Text = "An error has occured in the serverside script. Please try again.)"
69    end
70end)
 View all 70 lines...

(Also the string replaced with "no" is me and my friend)

Can anyone help please?

Thanks, Ethan

After I rewrote the PlayerAdded chat event, it works. So I'll try rewriting the whitelist, unwhitelist, and get user. Still if you can awnser the problem, please do that in case after I rewrite it fails again. RadiatedExodus 41 — 4y

Using SetAsync works but UpdateAsync doesn't work, which is strange. RadiatedExodus 41 — 4y

[SOLVED] This whitelist system that uses Datastore is not working and doesn't output any error?

1 answer

Answer this question