Scripting Helpers is winding down operations and is now read-only. More info→

FE Fist combat system issues, both players take damage?

Asked by

BIuehawks 62

5 years ago

Edited 5 years ago

Hi so I'm currently working on a basic fist combat system, I've gotten pretty far to the point where the player can swing and damage with their fists, however, there's an issue within my server script.

I used two variables in my serverscript to detect when the arms should deal damage.

`1`	`leftDamage` `=` `false`

`2`	`rightDamage` `=` `false`

However, when a player swings with their left arm for example, yes their left arm will deal damage, but so will everybody in the games.

I'm just going to include all the code here, sorry if what I've included is unnecessary

01local repStorage = game:GetService("ReplicatedStorage")
02local remoteEvent = repStorage:WaitForChild("Swing")
03Players = game:GetService("Players")
04leftDamage = false
05rightDamage = false
06char = script.Parent.Parent
07char:WaitForChild("Humanoid")
08leftarm = char:WaitForChild("Left Arm")
09rightarm = char:WaitForChild("Right Arm")
10 
11 
12 
13remoteEvent.OnServerEvent:connect(function(player, passthrough)
14local char = player.Character
15    if passthrough == "L" then
16    leftDamage = true
17    elseif passthrough == "R" then
18        rightDamage = true
19    else
20    end
21end)
22 
23 
24 
25leftarm.Touched:connect(function(hit)
26    if hit.Parent:FindFirstChild("Humanoid") then
27            if leftDamage == true then hit.Parent.Humanoid:TakeDamage(10)
28                leftDamage = false
29                script.Parent.Sound:Play()
30        else
31 
32        end
33        end
34end)
35 
36 
37 
38rightarm.Touched:connect(function(hit)
39    if hit.Parent:FindFirstChild("Humanoid") then
40            if rightDamage == true then hit.Parent.Humanoid:TakeDamage(10)
41                rightDamage = false
42                script.Parent.Sound:Play()
43        else
44 
45        end
46        end
47end)
 View all 47 lines...

I have a solution im just writing it out Dec_ade 47 — 5y

3 answers

Answered by

IStarConquestI 414

5 years ago

If I am able to interpret this correctly, you have a server script in each character.

When the remote event is fired, your script doesn't check if the player who is firing it owns the character model. As a result, when it is fired, all server scripts with this code will set rightDamage or leftDamage to true, indiscriminate of who fired the event originally.

By adding something like if player.Character == char to the remote event's associated function, then you could prevent this from happening.

im not sure where im putting this but i havent had any luck with it so far BIuehawks 62 — 5y

The remote event on line 13 fires for all versions of the serverscript, in every character. You need to make sure that its only setting the damage arm to true for the character who actually swung, so you need to include a logic statement. IStarConquestI 414 — 5y

Answered by

Dec_ade 47

5 years ago

Edited 5 years ago

The solution is that the script checks if the name of the player who was hit was equivalent to the player attacking

01local repStorage = game:GetService("ReplicatedStorage")
02local remoteEvent = repStorage:WaitForChild("Swing")
03Players = game:GetService("Players")
04leftDamage = false
05rightDamage = false
06char = script.Parent.Parent
07char:WaitForChild("Humanoid")
08leftarm = char:WaitForChild("Left Arm")
09rightarm = char:WaitForChild("Right Arm")
10 
11 
12 
13remoteEvent.OnServerEvent:connect(function(player, passthrough)
14local char = player.Character
15    if passthrough == "L" then
16    leftDamage = true
17    elseif passthrough == "R" then
18        rightDamage = true
19    else
20    end
21end)
22 
23 
24 
25leftarm.Touched:connect(function(hit)
26    if hit.Parent:FindFirstChild("Humanoid") then
27       if hit.Parent.Name ~= player.name then
28            and leftDamage == true then hit.Parent.Humanoid:TakeDamage(10)
29                leftDamage = false
30                script.Parent.Sound:Play()
31        else
32 
33        end
34        end
35end)
36 
37 
38 
39rightarm.Touched:connect(function(hit)
40    if hit.Parent:FindFirstChild("Humanoid") then
41       if hit.Parent.Name ~= player.name then
42            and rightDamage == true then hit.Parent.Humanoid:TakeDamage(10)
43                rightDamage = false
44                script.Parent.Sound:Play()
45        else
46 
47        end
48        end
49end)
 View all 49 lines...

This should work i think Dec_ade 47 — 5y

no luck BIuehawks 62 — 5y

OOF Dec_ade 47 — 5y

Answered by

Lakodex 711

5 years ago

Edited 5 years ago

New script, Put this in the tool directly and not in handles or parts.

01local repStorage = game:GetService("ReplicatedStorage")
02local remoteEvent = repStorage:WaitForChild("Swing")
03Players = game:GetService("Players")
04leftDamage = false
05rightDamage = false
06char = script.Parent.Parent
07char:WaitForChild("Humanoid")
08leftarm = char:WaitForChild("Left Arm")
09rightarm = char:WaitForChild("Right Arm")
10 
11 
12 
13remoteEvent.OnServerEvent:connect(function(player, passthrough)
14local char = player.Character
15    if passthrough == "L" then
16    leftDamage = true
17    elseif passthrough == "R" then
18        rightDamage = true
19    else
20    end
21end)
22 
23 
24 
25leftarm.Touched:connect(function(hit)
26    if hit.Parent:FindFirstChild("Humanoid") and hit.Parent ~= script.Parent.Parent then
27            if leftDamage == true then hit.Parent.Humanoid:TakeDamage(10)
28                leftDamage = false
29                script.Parent.Sound:Play()
30        else
31 
32        end
33        end
34end)
35 
36 
37 
38rightarm.Touched:connect(function(hit)
39    if hit.Parent:FindFirstChild("Humanoid") and hit.Parent ~= script.Parent.Parent then
40            if rightDamage == true then hit.Parent.Humanoid:TakeDamage(10)
41                rightDamage = false
42                script.Parent.Sound:Play()
43        else
44 
45        end
46        end
47end)
 View all 47 lines...

It's in startercharacterscripts but I'll try it anyways BIuehawks 62 — 5y

sadly not sorry BIuehawks 62 — 5y

FE Fist combat system issues, both players take damage?

3 answers

Answer this question