Scripting Helpers is winding down operations and is now read-only. More info→

[SOLVED] "GetPropertyChangedSignal" not functioning, any idea why?

Asked by

guest_20I8 266

5 years ago

Edited 3 years ago

Explanation: So I'm trying to make a script for a hospital roleplay game. When the player enters the game, the game auto-detects whether they are in a group or not and whether they have enough rank. If the player has enough rank and is in the group, the player will automatically be on the team "Hospital Staff", otherwise, the player will automatically be on team "Patient". There's 2 teams, 1 is called "Hospital Staff". Another team is called "Patient". My problem here is that when a player changed the team, the game won't detect, i've tried to use GetPropertyChangedSignal function but it does not detect as well..

I Have 3 scripts.

First Script: Located In StarterPack Named "TeamChooseLocal". It's a local script as u can tell from the name. This is the script for detecting whether they are in the group and have enough rank.

Second Script: Located In a part named "ReceptionDoor" in Workspace, Named "ReceptionDoorAccessServer". It's a server script (as you can tell). This is the script where it detects which team a player is in and whether to give access to the reception door to a player.

Third Script: Located in StarterPack Named "ReceptionDoorAccessLocal". Well, you know what type of script is that. This is the script where is it gets the rank from the group to see if player meet the requirement when they select "Hospital Staff" Rank and check if they are in the group as well so that they will have access to the reception door if they did.

Here are the scripts.

TeamChooseLocal:

01local Player = game.Players.LocalPlayer
02local Teams = game:GetService("Teams")
03local ReceptionDoorEvent = game:GetService("ReplicatedStorage"):WaitForChild("EventsFolder"):WaitForChild("ReceptionDoorAccessEvent")
04 
05 
06if Player:IsInGroup(5786709) and Player:GetRankInGroup(5786709) > 1 then
07    print("Player Is In Group: Robloxia City Hospital")
08    print("Player's Rank Is: "..Player:GetRankInGroup(5786709))
09    Player.Team = Teams["Hospital Staff"]
10    print("Team Changed, Player's Team Is Hospital Staff")
11    ReceptionDoorEvent:FireServer()
12    print("FiredServer")
13elseif Player:IsInGroup(5786709) and Player:GetRankInGroup(5786709) == 1 then
14    print("Player Is In Group: Robloxia City Hospital")
15    print("Player's Rank Is: "..Player:GetRankInGroup(5786709))
16    Player.Team = Teams.Patient
17    print("Team Changed, Player's Team Is 'Patient'")
18    ReceptionDoorEvent:FireServer()
19    print("FiredServer")
20else
21    print("Player Is Not In Group: Robloxia City Hospital!")
22    Player.Team = Teams.Patient
23    print("Team Changed, Player's Team Is 'Patient'")
24    ReceptionDoorEvent:FireServer()
25    print("FiredServer")
26end
 View all 26 lines...

ReceptionDoorAccessServer:

01local ReceptionDoorEvent = game:GetService("ReplicatedStorage"):WaitForChild("EventsFolder"):WaitForChild("ReceptionDoorAccessEvent")
02local ReceptionDoorEvent2 = game:GetService("ReplicatedStorage"):WaitForChild("EventsFolder"):WaitForChild("ReceptionDoorAccessEvent2")
03local Touched = false
04local Teams = game:GetService("Teams")
05 
06game.Players.PlayerAdded:Connect(function()
07    script.Parent.Touched:Connect(function(ReceptionDoor)
08            if ReceptionDoor.Parent:FindFirstChild("HumanoidRootPart") then
09                if Touched == false then
10                    Touched = true
11                    print("HumanoidRootPart Found")
12                    ReceptionDoorEvent.OnServerEvent:Connect(function(Player)
13                        print("ReceptionDoorEvent Received Signal") -- supposed to put "GetPropertyChangedSignal" function after this but it doesn't work...
14                        if Player.Team == Teams["Hospital Staff"] then
15                            print("Player Is In Team: Hospital Staff, Access Granted!")
16                            ReceptionDoorEvent2:FireClient(Player)
17                            print("FiredClient")
18                        elseif Player.Team == Teams.Patient then
19                            print("Player Is In Team: Patient, Access Not Granted!")
20                            Touched = true
21                        end
22                    end)
23                end
24            elseif ReceptionDoor.Parent:FindFirstChild("Torso")then
25                if Touched == false then
26                    Touched = true
27                    print("Torso Found")
28                    ReceptionDoorEvent.OnServerEvent:Connect(function(Player)
29                        print("ReceptionDoorEvent Received Signal") -- supposed to put "GetPropertyChangedSignal" function after this too...
30                        if Player.Team == Teams["Hospital Staff"] then
31                            print("Player Is In Team: Hospital Staff, Access Granted!")
32                            ReceptionDoorEvent2:FireClient(Player)
33                            print("FiredClient")
34                        elseif Player.Team == Teams.Patient then
35                            print("Player Is In Team: Patient, Access Not Granted!")
36                            Touched = true
37                        end
38                    end)
39                end
40            end
41        ReceptionDoorEvent2.OnServerEvent:Connect(function()
42            Touched = false
43        end)
44    end)
45end)
 View all 45 lines...

ReceptionDoorAccessLocal:

01local ReceptionDoorEvent2 = game:GetService("ReplicatedStorage"):WaitForChild("EventsFolder"):WaitForChild("ReceptionDoorAccessEvent2")
02local LocalPlayer = game.Players.LocalPlayer
03local ActualReceptionDoor = game.Workspace:WaitForChild("ReceptionDoor")
04local Teams = game:GetService("Teams")
05 
06ReceptionDoorEvent2.OnClientEvent:Connect(function()
07    print("ReceptionDoorEvent2 Received Signal")
08    if LocalPlayer:GetRankInGroup(5786709) >= 3 then
09        print(LocalPlayer:GetRankInGroup(5786709))
10        ActualReceptionDoor.Transparency = 0.5
11        ActualReceptionDoor.CanCollide = false
12        wait(1)
13        ActualReceptionDoor.Transparency = 0
14        ActualReceptionDoor.CanCollide = true
15        ReceptionDoorEvent2:FireServer()
16    end
17end)

1 answer

Answered by

User#23252 26

5 years ago

Edited 5 years ago

okay, first up, great explanation.. I wish everybody would explain their problems in as much detail as you did..

There's multiple problems in your scripts:

1.I am pretty sure you can only check the rank of a player in a group from the server

2.a player's team is not dictated by a team object, instead it's controlled by the TeamColor of a team object. Which means to set the player's team, you have to player.TeamColor = TeamObject.TeamColor

3.you don't really need remote event's to give access to a door, unless absolutely neccessary

now here's how you can do the same thing:

in a server script

01local Players = game:GetService("Players")
02local Teams = game:GetService("Teams");
03 
04local staff = Teams["Hospital Staff"]
05local patients = Teams.Patients
06 
07Players.PlayerAdded:Connect(function(player)
08    if(player:IsInGroup(5786709)) then
09        local rank  = player:IsInGroup(5786709)
10        if(rank > 1) then
11            player.TeamColor =  staff.TeamColor
12            print("Is staff")
13        elseif(rank == 1) then
14            player.TeamColor = patients.TeamColor
15            print("Is patient")
16        end
17    else
18        print("Player is not in group")
19    end
20end)

LocalSCript

01local Players = game:GetService("Players")
02local Teams = game:GetService("Teams");
03local door = nil--set this to the door part;
04 
05door.Touched:Connect(function(part)
06    local player = Players.LocalPlayer
07    local character = player.Character
08 
09    local isStaff  = player.Team == Teams["Hospital Staff"]
10    local isInGroup = player:IsInGroup(5786709)
11 
12    if part.Parent == character and character and isInGroup and isStaff then
13        door.CanCollide = false
14        door.Transparancy = 0.5
15        wait(3);
16        door.CanCollide = true
17        door.Transparancy = 0
18    end
19end)

Object:GetPropertyChangedSignal takes a property name,like TeamColor.. you can check when the player' team changes by doing

1player:GetPropertyChangedSignal("TeamColor"):Connect(function()
2    print("Player's team changed")
3end)

hopefully this helps, lemme know if you need more help

Hi, I tried the "GetPropertyChangedSIgnal('TeamColor')" function you said but still doesn't work. I tried to print("Team Change Detected") after the "GetPropertyChangedSignal" function but it doesn't print. However, the ServerScript still receives the Signal from the LocalScript as I tried to print("ReceptionDoorEvent Received Signal") and it printed. guest_20I8 266 — 5y

Ow by the way Player.Team works for me tho. Everything works well except for the "GetPropertyChangedSignal" function. It didn't even print any error.... guest_20I8 266 — 5y

Dude, do you have discord? Maybe can you add me and guide me? My ID is: Mr1O1#9346 Thanks guest_20I8 266 — 5y

sure User#23252 26 — 5y

View all comments (2 more)

just sent u one User#23252 26 — 5y

Arsubia12#0546 User#23252 26 — 5y

[SOLVED] "GetPropertyChangedSignal" not functioning, any idea why?

1 answer

Answer this question