Scripting Helpers is winding down operations and is now read-only. More info→

Am I missing something with this Color3.new?

Asked by

10 years ago

Hello. I am currently working on a GUI project. My issue is, when I click the button to the "Off" position, the BackgroundColor3 does not change to 161, 161, 161.

Here is the code:

01local Button = script.Parent
02script.Parent.MouseButton1Click:connect(function()
03    if script.On.Value == true then
04        Button:TweenPosition(UDim2.new(0.5, 0, 0, 0), "Out", "Quad", 1)
05        wait(0.5)
06        Button.BackgroundColor3 = Color3.new(161, 161, 161)
07        Button.Text = "Off"
08        script.On.Value = false
09    elseif script.On.Value == false then
10        Button:TweenPosition(UDim2.new(0, 0, 0, 0), "Out", "Quad", 1)
11        wait(0.5)
12        Button.BackgroundColor3 = Color3.new(0, 255, 0)
13        Button.Text = "On"
14        script.On.Value = true
15    end
16end)

This Script is directly inside of a TextButton. The Value is a BoolValue directly inside of the Script.

This is a Server Script (In other words, Script)

What happens is when I click it to turn Off the BackgroundColor3 is changed to 30090, 30090, 30090 instead of 161, 161, 161.

I'm not sure if I am missing something in my script, or if Color3.new is glitched somehow. It turns 0, 255, 0 (Lime green) when turned On every time.

Thanks for your help guys! I appreciate it!

Color3.New(1, 1, 1) is pure white. The numbers are max of one, min of zero. Some people make a color function that divides all values by 255. Color3.new(161/255, 161/255, 161/255) is what you really need for line 6. GoldenPhysics 474 — 10y

I'll try it, but it changes the color to 0, 255, 0 when it is told to. TheStudentPilot 75 — 10y

Well it worked, thanks for your help! TheStudentPilot 75 — 10y

Yep, that threw my head for a few spins too before someone told me that one day. :) deaththerapy 60 — 10y

1 answer

Answered by

NoahWillCode 370

10 years ago

The issue is in Color3.new(), the parameters aren't integers. Rather, they are more like what we call double or float values, and they are in the range of 0 - 1. So, instead of 255, you could more properly just put 1 (though, 255 is more readable). Here's an example:

1--This is how it would make more sense
2Color3.new(20, 255, 20) -- Should make a green color, but it would actually make white.
3--But this is how it actually works
4Color3.new(20/255, 255/255, 20/255) --This makes a green!

So, the best way to do this, while keeping everything readable, is just to use colorValue / 255 (since 255 is the maximum value, and 0 divided by anything is still 0).

Am I missing something with this Color3.new?

1 answer

Answer this question