Why won't this script work? I have tried multiple methods to fix it. [ANSWERED]

Asked by

5 years ago

Edited 5 years ago

Hello, I am trying to achieve a Carry System but whenever a player comes

Here is the full code:

01local UI = script.Parent
02local RS = game:GetService("RunService")
03local debugmode = 0
04local firstply = "nil"
05if debugmode == 0 then
06 
07RS.Stepped:Connect(function()
08    local ply = game.Players:GetPlayers()
09    for i,v in pairs(ply) do
10       if game.Players.LocalPlayer:DistanceFromCharacter(v.Character.UpperTorso.Position) <= 10 and v.Name ~= game.Players.LocalPlayer.Name and firstply ~= v.Name then
11            firstply = v.Name
12            print(game.Players.LocalPlayer.Name.." is close to "..firstply..".")
13            script.Parent.Visible = true
14            script.Parent.PlayerCarried.Text = ("Carry, "..firstply.."?")
15        else if game.Players.LocalPlayer:DistanceFromCharacter(v.Character.UpperTorso.Position) >= 10 and v.Name ~= game.Players.LocalPlayer.Name and firstply == v.Name then
16            firstply = "nil"
17            print(game.Players.LocalPlayer.Name.." is not close to "..firstply..".")
18            script.Parent.Visible = false
19            end
20        end
21    end
22end)
23 
24elseif debugmode == 0 then
25 
26RS.Stepped:Connect(function()
27        if game.Players.LocalPlayer:DistanceFromCharacter(game.Workspace.PlayerCarry.UpperTorso.Position) <= 10 then
28            script.Parent.Visible = true
29        else
30            script.Parent.Visible = false
31        end
32    end)
33end
34 
35UI.Carry.MouseButton1Click:Connect(function()
36    game.ReplicatedStorage.CarryEvent:FireServer(firstply, game.Players.LocalPlayer.Name)
37    print(firstply)
38end)
39 
40UI.Cancel.MouseButton1Click:Connect(function()
41    game.ReplicatedStorage.DropEvent:FireServer(firstply, game.Players.LocalPlayer.Name)
42    print(firstply)
43end)
 View all 43 lines...

The code that is erroring is:

`1`	`game.Players.LocalPlayer:DistanceFromCharacter(v.Character.UpperTorso.Position) <=` `10` `and` `v.Name ~=` `game.Players.LocalPlayer.Name` `and` `firstply ~=` `v.Name` `then`

This is the errors I receive: https://i.imgur.com/peJUGUU.png https://i.imgur.com/vefPWWJ.png

This is the output it gives: https://i.imgur.com/beCK31M.png https://i.imgur.com/tuSAn8f.png

Sorry, if the Images are blurred.

do u use r6? HappyTimIsHim 652 — 5y

I'm using R15. iiMxtt_Destinyii 62 — 5y

why is firstply a string? if you want to assign it's really nil, you should remove the quotation marks. also, pretty sure what's wrong is the "(v.Character.UpperTorso.Position) <= 10", because you haven't specified the axis (x,y,z) Goomiin 1 — 5y

Alright, that seemed to fix it. Thanks for the help. iiMxtt_Destinyii 62 — 5y

If it is fixed, you should put [Answered] in the question title so people know. CoolOlivie057 45 — 5y

Why won't this script work? I have tried multiple methods to fix it. [ANSWERED]

Answer this question