Scripting Helpers is winding down operations and is now read-only. More info→

Why is my attack script not doing damage? The damage script normally works in other situations.

Asked by

5 years ago

I have created a script that clones a part called "Damager" onto a hitbox. Damager should damage everything it touches, however for some reason it is not dealing damage when it is cloned. This is the script in damager:

1function onTouched(hit)
2        local human = hit.Parent:findFirstChild("Humanoid")
3        if (human ~= nil) then
4                human.Health = human.Health - 2 -- Change the amount to change the damage.
5        end
6end
7script.Parent.Touched:connect(onTouched)

It should work. This next script is the script that makes the attack work:

01local player = game.Players.LocalPlayer
02repeat wait() until player.Character.Humanoid
03local humanoid = player.Character.Humanoid
04local mouse = player:GetMouse()
05 
06 
07 
08local anim = Instance.new("Animation")
09anim.AnimationId = "http://www.roblox.com/asset/?id=4752814788"
10 
11mouse.KeyDown:connect(function(key)
12  if key == "e" then
13    if script.Cooldown.Value == false then
14    script.Cooldown.Value = true
15   local playAnim = humanoid:LoadAnimation(anim)
16   playAnim:Play()
17 
18    local Damage1 = workspace.Clonables.Damager:Clone()
19    Damage1.Parent = workspace
20    Damage1.Position = player.Character.Hitbox1.Position
21    Damage1.Orientation = player.Character.Hitbox1.Orientation
22    local weld1 = Instance.new("WeldConstraint")
23    weld1.Parent = Damage1
24    weld1.Enabled = true
25    weld1.Part0 = Damage1
26    weld1.Part1 = player.Character.Hitbox1
27 
28 
29 
30    local Damage2 = workspace.Clonables.Damager:Clone()
31    Damage2.Parent = workspace
32    Damage2.Position = player.Character.Hitbox2.Position
33    Damage2.Orientation = player.Character.Hitbox2.Orientation
34    local weld2 = Instance.new("WeldConstraint")
35    weld2.Parent = Damage2
36    weld2.Enabled = true
37    weld2.Part0 = Damage2
38    weld2.Part1 = player.Character.Hitbox2
39 
40 
41    wait (0.4)
42    script.Cooldown.Value = false
43    weld1:Destroy()
44    weld2:Destroy()
45    Damage1:Destroy()
46    Damage2:Destroy()
47 
48    end
49    end
50end)
 View all 50 lines...

In theory, all of this should work perfectly, but for some reason it is not dealing damage. Does anyone know why? Please help.

I think the problem is at line 12, don’t think keyboard input doesn’t work like that. TTHKKB 12 — 5y

2 answers

Answered by

Shadic1270 136

5 years ago

Edited 5 years ago

Welp, I actually dont know what is the error on your script, but i got this one that i used in my old game and it still working

01--// Services
02local UserInputService = game:GetService('UserInputService')
03local ReplicatedStorage = game:GetService('ReplicatedStorage')
04local Players = game:GetService('Players')
05 
06--// Debounces
07local Punching = false
08local Damaging = true
09 
10--// Customisation
11local Damage = 20
12local Cooldown = 0.5
13 
14--// Events
15local PunchEvent = ReplicatedStorage:WaitForChild('PunchEvent')
16 
17--// Player
18local Player = game.Players.LocalPlayer
19local Character = game.Workspace:WaitForChild(Player.Name)
20local Humanoid = Character:FindFirstChildOfClass('Humanoid')
21local RightArm = Character:WaitForChild('Right Arm')
22 
23--//Animations
24Punch = Instance.new('Animation')
25Punch.AnimationId = 'rbxassetid:// '--animation here
26PunchTrack = Humanoid:LoadAnimation(Punch)
27 
28--// Coding
29UserInputService.InputBegan:Connect(function(Input)
30    if Input.KeyCode == Enum.KeyCode.R and not Punching then
31        Punching = true
32        PunchTrack:Play()
33        PunchTrack.KeyframeReached:Connect(function(Keyframe)
34            if Keyframe == 'End' then
35                wait(Cooldown)
36                Punching = false
37                Damaging = true
38            end
39        end)
40    end
41end)
42 
43RightArm.Touched:Connect(function(hitPart)
44    if Punching and hitPart.Parent:FindFirstChild('Humanoid') and Damaging then
45        Damaging = false
46        local HumanoidToDamage = hitPart.Parent:FindFirstChild('Humanoid')
47        PunchEvent:FireServer(HumanoidToDamage, Damage)
48    end
49end)
 View all 49 lines...

ALSO.... add a RemoteEvent called "PunchEvent" (its really important that u name it PunchEvent cuz if u dont it wont work. Make this correct answer if it is

U can customize it as u want to Shadic1270 136 — 5y

Answered by

Dfzoz 489

5 years ago

Is the damager script disabled? You have to turn disabled to false on the clone of the hitbox you make

I added lines to make sure Disabled is off, and it still doesn't do damage. Thanks anyways, though. luckylucas9 0 — 5y

Why is my attack script not doing damage? The damage script normally works in other situations.

2 answers

Answer this question