"FireClient: player argument must be a Player object" Error?

Asked by

5 years ago

This question has been solved by the original poster.

My Idle animation won't stop working because my getPlayer function won't get the actual player? I'm not sure why it won't get the player!?

Serverscript in tool

001local Tool = script.Parent
002local Remote = Tool:WaitForChild("Remote")
003local Handle = Tool:WaitForChild("Handle")
004local Mesh = Handle:WaitForChild("Mesh")
005 
006 
007 
008local Equipping = false
009local Grip = nil
010 
011local StraightMeshData = "http://www.roblox.com/asset/?id=193827643"
012local StraightGripPos = Vector3.new(0, 0, 1.5)
013local BentMeshData = "http://www.roblox.com/asset/?id=193827593"
014local BentGripPos = Vector3.new(0, 0.6, 0.5)
015local Bent = true
016 
017local AttackAble = true
018local AttackRestTime = 1
019local AttackVictims = {}
020local AttackWindow = 0.66
021local AttackDamaging = false
022local AttackWindup = 0.1
023 
024function getPlayer()
025    local char = script.Parent.Parent
026    return game:GetService("Players"):GetPlayerFromCharacter(char)
027end
028 
029function contains(t, v)
030    for _, val in pairs(t) do
031        if val == v then
032            return true
033        end
034    end
035    return false
036end
037 
038function tagHuman(human)
039    local tag = Instance.new("ObjectValue")
040    tag.Value = getPlayer()
041    tag.Name = "creator"
042    tag.Parent = human
043    game:GetService("Debris"):AddItem(tag)
044end
045 
046function normal()
047 
048    if not AttackAble then return end
049 
050    --rest
051    AttackAble = false
052    delay(AttackRestTime, function()
053        AttackAble = true
054    end)
055 
056    --damage
057    delay(AttackWindup, function()
058        AttackVictims = {}
059        AttackDamaging = true
060        delay(AttackWindow, function()
061            AttackDamaging = false
062        end)
063    end)
064 
065    Handle.Swing:Play()
066 
067    local t = math.random(1, 2)
068    if t == 1 then
069        Remote:FireClient(getPlayer(), "PlayAnimation", "Swing1")
070        Handle.Trail.Enabled = true
071    elseif t == 2 then
072        Remote:FireClient(getPlayer(), "PlayAnimation", "Swing2")
073        Handle.Trail.Enabled = true
074    end
075 
076end
077 
078function onEquip()
079    if Equipping then return end
080    Equipping = true
081 
082    --animation
083    Remote:FireClient(getPlayer(), "PlayAnimation", "Idle")
084    Handle.Trail.Enabled = false
085    Equipping = false
086end
087 
088function onUnequip()
089    if Grip then
090        Grip:Destroy()
091    end
092 
093    --animation
094    Remote:FireClient(getPlayer(), "StopAnimation", "Idle")
095end
096 
097function onRemote(player, func, ...)
098    if player ~= getPlayer() then return end
099 
100    if func == "NormalStart" then
101        normal()
102    end
103end
104 
105Tool.Equipped:connect(onEquip)
106Tool.Unequipped:connect(onUnequip)
107Remote.OnServerEvent:connect(onRemote)
 View all 107 lines...

can you try printing out: print(getPlayer()) and then print(getPlayer().Parent) ? royaltoe 5144 — 5y

Did you try debugging? Maybe using the print function at certain points in your getPlayer() function? Or after it's called? joshmatt2244 28 — 5y

do u even read bruh i just said that royaltoe 5144 — 5y

You asked if you could. I said you can. Stop being arrogant, you came here for answers, your script is messy and it hurts my eyes to read it. If you want to solve your issue, learn to script like everyone who scripts did. It's called reading the roblox developer API page :) joshmatt2244 28 — 5y

View all comments (4 more)

Oops, sorry. I'm not the original poster. I also meant the 'do u even read' comment sarcastically since I already told him to try printing but, bad wording by me and you explained well. Srry. royaltoe 5144 — 5y

I fixed it Jomeliter 55 — 5y

yay royaltoe 5144 — 5y

please let ppl know what you did to fix it in the comments or answer tab. i'll mark your solution as the answer. royaltoe 5144 — 5y

"FireClient: player argument must be a Player object" Error?

1 answer

Answer this question