Scripting Helpers is winding down operations and is now read-only. More info→

A bug in my script i can't seem to understand why it happens, why?

Asked by

PicoTheRiko 34

5 years ago

in short, i made a script that lets you run when pressing shift, and lets you walk when you let go.

you are able to run when an Intvalue is more than 0, and it increases every second by 1 when not running.

However, if you press shift two times under a second, the intvalue increases by 1 TWICE every second. from my understanding , the script malfunctions and runs the same line twice.

(the main bug starts at line 30)

01repeat wait() until game.Players.LocalPlayer
02local running = false
03local amount = game.StarterGui.run.Value.Value
04 
05local function stoprunning()
06    game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 11
07end
08 
09m = game.Players.LocalPlayer:GetMouse()
10 
11 
12m.KeyDown:connect(function(key)
13    if key == "0" and running == false then
14        print("Running")
15        running = true
16        game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 22
17        while running == true do
18            game.StarterGui.run.Value.Value = math.clamp(game.StarterGui.run.Value.Value - 1, 0, 100)
19            local amount = game.StarterGui.run.Value.Value
20            print (amount)
21            wait(0.1)
22            if amount == 0 then
23                game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 11
24            end
25        end
26 
27    end
28end)
29 
30m.KeyUp:connect(function(key)
31    if key == "0" and running == true then
32        running = false
33        local amount = game.StarterGui.run.Value.Value
34        game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 11
35        while running == false do
36            local amount = game.StarterGui.run.Value.Value
37            game.StarterGui.run.Value.Value = math.clamp(game.StarterGui.run.Value.Value + 1, 0, 100)
38            print(amount)
39            wait(0.9)
40        end
41    end
42end)
 View all 42 lines...

you have to rewrite your code to use UserInputService instead, Mouse is being Deprecated, Mouse should only be used in Plugins and Tools. Luka_Gaming07 534 — 5y

Mouse is NOT being deprecated, but KeyUp/KeyDown are deprecated and UserInputService.InputBegan should be used instead royaltoe 5144 — 5y

1 answer

Answered by

chess123mate 5873

5 years ago

You should always be careful of putting while loops in event handlers: every time someone taps "0" , you start a new while loop, causing your code to run 2x (or more if they keep tapping "0" in the right way).

Two possible fixes:

Add additional variables to make sure that you don't enter into the while loops if they're already being run
Whenever you start the while loop, increment some variable. Stop executing the loop if this variable is changed (since this means that another thread has started running the while loop and the current thread is now the "old" one).

A bug in my script i can't seem to understand why it happens, why?

1 answer

Answer this question