Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
1

My Shop Gui Won't Open If You Step On It Again!?

Asked by
Jomeliter 55
5 years ago

After you step on the Part that makes the shop open, it opens once. If you try again it won't open??

Script In Part

view source
01CanOpen = true
02 
03function onTouched(hit)
04    local plr = game.Players:GetPlayerFromCharacter(hit.Parent)
05    if plr then
06        if CanOpen == true then
07            local shop = plr:WaitForChild("PlayerGui").ShopUI.Shop
08            shop.Visible = true
09            CanOpen = false
10            wait(1)
11            CanOpen = true
12        end
13    end
14end
15 
16script.Parent.Touched:connect(onTouched)

3 answers

Log in to vote
0
Answered by
Alphexus 498 Moderation Voter
5 years ago

Your real problem is that you are changing the visibility from the Client and also from the Server. I think you are opening it, but then using a button to close the GUI, but that changes the visibility for the Client. The Server still sees the GUI open.

0
I suggest using a RemoteEvent and opening it from the client. Alphexus 498 — 5y
Ad
Log in to vote
-1
Answered by
lolol1901 28
5 years ago

Hi! I'm lolol1901, hoping to fix your issue. Any problems? Worked? Something else? Please comment on this reply right away so I can help you or make sure it worked fine.

First of all, I suggest you replace CanOpen by debounce, but it's 100% your choice.

Second of all, nice indent. First time I see someone using indents goodly.

Lastly, here's what I would've put in your position. This script is fully commented (like all my answers.) I'm also going to space it so it's easy to read.

view source
01db = true -- db short for debounce, replacing your CanOpen bool variable.
02 
03script.Parent.Touched:Connect(function(hit)
04    if hit.Parent:FindFirstChild("Humanoid") or hit.Parent.Parent:FindFirstChild("Humanoid") then -- Why didn't I create the player variable immediately? An accessory might've touched the part. I need to make sure whatever touched was part of a player, and if it is an accessory.
05 
06        local player = game.Players:GetPlayerFromCharacter(hit.Parent) -- player var
07 
08        if db == true then -- Of course, an if statement to make sure the cooldown is off.
09 
10            db = false -- I prefer activating the cooldown first things first in case of something.
11            local shop = player:WaitForChild("PlayerGui").ShopUI.Shop -- shop var
12 
13            shop.Visible = true -- Make it visible
14 
15            wait(1) -- Of course, wait so the debounce works.
View all 23 lines...

Please upvote this if it is a good solution or if it worked well!

0
This is a stolen comment from another issue. Please! Make your own for once and not just look it up. Lakodex 711 — 5y
0
stolen? royaltoe 5144 — 5y
0
also canOpen is the same as debounce. debounce is just the term for it. youre also not checking if the player exists royaltoe 5144 — 5y
Log in to vote
-1
Answered by
HappyTimIsHim 652 Moderation Voter
5 years ago

You can't access a playersgui with a normal script.

view source
01CanOpen = true
02 
03function onTouched(hit)
04    local plr = game.Players:GetPlayerFromCharacter(hit.Parent)
05    if plr then
06        if CanOpen == true then
07            local shop =game.ServerStorage.ShopUI.Shop:Clone()
08        shop.Parent = plr.PlayerGui
09            shop.Visible = true
10            CanOpen = false
11            wait(1)
12            CanOpen = true
13        end
14    end
15end
16 
17script.Parent.Touched:connect(onTouched)
0
You actually can access PlayerGui from a server script. It just isn't recommended. I suggest you do your research before making claims like that. Alphexus 498 — 5y
0
well sorry that im late but from my experience i couldn't access it and bye HappyTimIsHim 652 — 5y

Answer this question