Scripting Helpers is winding down operations and is now read-only. More info→

Shortening Currencies Value Doesn't Work For Second Currency?

Asked by

Jomeliter 55

5 years ago

I'm trying to shorten the values for the currency,

It works for Coins but no the Chi?

Leaderstats

01game.Players.PlayerAdded:Connect(function(plr)
02    local leaderstats = Instance.new("Folder", plr)
03    leaderstats.Name = "leaderstats"
04 
05    local MainCurrency = Instance.new("Folder", plr)
06    MainCurrency.Name = "MainCurrency"
07 
08    local Coins = Instance.new("IntValue", MainCurrency)
09    Coins.Name = "Coins"
10    Coins.Value = 0
11 
12    local Chi = Instance.new("IntValue", MainCurrency)
13    Chi.Name = "Chi"
14    Chi.Value = 0
15 
16    local CoinsDis = Instance.new("StringValue", leaderstats)
17    CoinsDis.Name = "Coins"
18    CoinsDis.Value = 0
19 
20    local Gems = Instance.new("IntValue", leaderstats)
21    Gems.Name = "Gems"
22    Gems.Value = 0
23 
24    local ChiDisp = Instance.new("StringValue", leaderstats)
25    ChiDisp.Name = "Chi"
26    ChiDisp.Value = 0
27 
28    local Strength = Instance.new("IntValue", leaderstats)
29    Strength.Name = "Strength"
30    Strength.Value = 0
31 
32    local MaxStrength = Instance.new("IntValue", leaderstats)
33    MaxStrength.Name = "MaxStrength"
34    MaxStrength.Value = 10
35 
36    while wait() do --COIN COVERT
37        local Coin = tostring(Coins.Value)
38        if #Coin >= 10 then -- Bill
39            CoinsDis.Value = Coin:sub(0,(#Coin-9)).."."..(Coin:sub(#Coin-7,(#Coin-7))).."B+"
40        elseif #Coin >= 7 then -- Mill
41            CoinsDis.Value = Coin:sub(0,(#Coin-6)).."."..(Coin:sub(#Coin-5,(#Coin-5))).."M+"
42        elseif #Coin >= 4 then -- Thos
43            CoinsDis.Value = Coin:sub(0,(#Coin-3)).."."..(Coin:sub(#Coin-2,(#Coin-2))).."K+"
44        else
45            CoinsDis.Value = tostring(Coins.Value)
46        end        
47    end
48 
49    while wait() do --CHI COVERT
50        local Chi = tostring(Chi.Value)
51        if #Chi >= 10 then -- Bill
52            ChiDisp.Value = Chi:sub(0,(#Chi-9)).."."..(Chi:sub(#Chi-7,(#Chi-7))).."B+"
53        elseif #Chi >= 7 then -- Mill
54            ChiDisp.Value = Chi:sub(0,(#Chi-6)).."."..(Chi:sub(#Chi-5,(#Chi-5))).."M+"
55        elseif #Chi >= 4 then -- Thos
56            ChiDisp.Value = Chi:sub(0,(#Chi-3)).."."..(Chi:sub(#Chi-2,(#Chi-2))).."K+"
57        else
58            ChiDisp.Value = tostring(Chi.Value)
59        end        
60    end
61 
62 
63end)
 View all 63 lines...

Your using 2 while loops, so the first while loop will only run, try combining the loops. killerbrenden 1537 — 5y

Any errors? moo1210 587 — 5y

No errors Jomeliter 55 — 5y

2 answers

Answered by

killerbrenden 1537

5 years ago

Your using 2 while loops, so the game reads it from top to bottom, and it will loop over the first While Loop until it breaks. If it doesn't break, it'll just loop over that current code for the rest of the game being live.

To fix this, I used a ModuleScript with functions and just looped those. I may have done it a bit more complicated and memory consuming than it had to be, but I just found this way to be easier for me.

In the ModuleScript that I named NumericalShortener I changed it around.

01local numericalShortener = {}
02 
03function numericalShortener.ShortenChi(player)
04    local chi = tostring(player:WaitForChild("MainCurrency"):FindFirstChild("Chi").Value)
05    local chiDis = player:WaitForChild("leaderstats"):FindFirstChild("Chi")
06 
07    if #chi >= 10 then
08        chiDis.Value = chi:sub(0,(#chi - 9)).."."..(chi:sub(#chi - 7,(#chi - 7))).."B+"
09    elseif #chi >= 7 then
10        chiDis.Value = chi:sub(0,(#chi - 6)).."."..(chi:sub(#chi - 5,(#chi - 5))).."M+"
11    elseif #chi >= 4 then
12        chiDis.Value = chi:sub(0,(#chi - 3)).."."..(chi:sub(#chi - 2,(#chi - 2))).."K+"
13    else
14        chiDis.Value = chi
15    end
16end
17 
18function numericalShortener.ShoternCoins(player)
19    local coins = tostring(player:WaitForChild("MainCurrency"):FindFirstChild("Coins").Value)
20    local coinsDis = player:WaitForChild("leaderstats"):FindFirstChild("Coins")
21 
22    if #coins >= 10 then
23        coinsDis.Value = coins:sub(0,(#coins - 9)).."."..(coins:sub(#coins - 7,(#coins - 7))).."B+"
24    elseif #coins >= 7 then
25        coinsDis.Value = coins:sub(0,(#coins - 6)).."."..(coins:sub(#coins - 5,(#coins - 5))).."M+"
26    elseif #coins >= 4 then
27        coinsDis.Value = coins:sub(0,(#coins - 3)).."."..(coins:sub(#coins - 2,(#coins - 2))).."K+"
28    else
29        coinsDis.Value = coins
30    end
31end
32 
33return numericalShortener
 View all 33 lines...

In a ServerScript that I named CurrencyHandler I added a loop for the functions of the ModuleScript while requiring it.

01local moduleShortener = require(script.NumericalShortener)
02 
03game.Players.PlayerAdded:Connect(function(plr)
04    local leaderstats = Instance.new("Folder", plr)
05    leaderstats.Name = "leaderstats"
06 
07    local MainCurrency = Instance.new("Folder", plr)
08    MainCurrency.Name = "MainCurrency"
09 
10    local Coins = Instance.new("IntValue", MainCurrency)
11    Coins.Name = "Coins"
12    Coins.Value = 0
13 
14    local Chi = Instance.new("IntValue", MainCurrency)
15    Chi.Name = "Chi"
16    Chi.Value = 0
17 
18    local CoinsDis = Instance.new("StringValue", leaderstats)
19    CoinsDis.Name = "Coins"
20    CoinsDis.Value = 0
21 
22    local Gems = Instance.new("IntValue", leaderstats)
23    Gems.Name = "Gems"
24    Gems.Value = 0
25 
26    local ChiDisp = Instance.new("StringValue", leaderstats)
27    ChiDisp.Name = "Chi"
28    ChiDisp.Value = 0
29 
30    local Strength = Instance.new("IntValue", leaderstats)
31    Strength.Name = "Strength"
32    Strength.Value = 0
33 
34    local MaxStrength = Instance.new("IntValue", leaderstats)
35    MaxStrength.Name = "MaxStrength"
36    MaxStrength.Value = 10
37 
38    while wait() do
39        moduleShortener.ShortenChi(plr)
40        moduleShortener.ShoternCoins(plr)
41    end
42end)
 View all 42 lines...

This is how I have it set up in ServerScriptService, here.

Hope this helped! I'm pretty sure this should work as I have tested it myself.

If this is what you're looking for and it helped, let me know by selecting this as the answer!

I put a ServerScript inside of ServerScriptService, and then I put a ModuleScript inside of that ServerScript. killerbrenden 1537 — 5y

Thx, it works! Jomeliter 55 — 5y

No problem! killerbrenden 1537 — 5y

Answered by

Jomeliter 55

5 years ago

Tried This But The Chi's Value Won't Change Now?

01game.Players.PlayerAdded:Connect(function(plr)
02    local leaderstats = Instance.new("Folder", plr)
03    leaderstats.Name = "leaderstats"
04 
05    local MainCurrency = Instance.new("Folder", plr)
06    MainCurrency.Name = "MainCurrency"
07 
08    local Coins = Instance.new("IntValue", MainCurrency)
09    Coins.Name = "Coins"
10    Coins.Value = 0
11 
12    local Chi = Instance.new("IntValue", MainCurrency)
13    Chi.Name = "Chi"
14    Chi.Value = 0
15 
16    local CoinsDis = Instance.new("StringValue", leaderstats)
17    CoinsDis.Name = "Coins"
18    CoinsDis.Value = 10
19 
20    local Gems = Instance.new("IntValue", leaderstats)
21    Gems.Name = "Gems"
22    Gems.Value = 0
23 
24    local ChiDisp = Instance.new("StringValue", leaderstats)
25    ChiDisp.Name = "Chi"
26    ChiDisp.Value = 10
27 
28    local Strength = Instance.new("IntValue", leaderstats)
29    Strength.Name = "Strength"
30    Strength.Value = 0
31 
32    local MaxStrength = Instance.new("IntValue", leaderstats)
33    MaxStrength.Name = "MaxStrength"
34    MaxStrength.Value = 10
35 
36    while wait() do --COIN COVERT
37        local Coin = tostring(Coins.Value)
38        if #Coin >= 10 then -- Bill
39            CoinsDis.Value = Coin:sub(0,(#Coin-9)).."."..(Coin:sub(#Coin-7,(#Coin-7))).."B+"
40        elseif #Coin >= 7 then -- Mill
41            CoinsDis.Value = Coin:sub(0,(#Coin-6)).."."..(Coin:sub(#Coin-5,(#Coin-5))).."M+"
42        elseif #Coin >= 4 then -- Thos
43            CoinsDis.Value = Coin:sub(0,(#Coin-3)).."."..(Coin:sub(#Coin-2,(#Coin-2))).."K+"
44        else
45            CoinsDis.Value = tostring(Coins.Value)
46        end
47 
48        local Chi = tostring(Chi.Value)
49        if #Chi >= 10 then -- Bill
50            ChiDisp.Value = Chi:sub(0,(#Chi-9)).."."..(Chi:sub(#Chi-7,(#Chi-7))).."B+"
51        elseif #Chi >= 7 then -- Mill
52            ChiDisp.Value = Chi:sub(0,(#Chi-6)).."."..(Chi:sub(#Chi-5,(#Chi-5))).."M+"
53        elseif #Chi >= 4 then -- Thos
54            ChiDisp.Value = Chi:sub(0,(#Chi-3)).."."..(Chi:sub(#Chi-2,(#Chi-2))).."K+"
55        else
56            ChiDisp.Value = tostring(Chi.Value)
57        end        
58    end
59 
60end)
 View all 60 lines...

Shortening Currencies Value Doesn't Work For Second Currency?

2 answers

Answer this question