Scripting Helpers is winding down operations and is now read-only. More info→

How can I prevent this code from being ran before this for loop finishes?

Asked by

hpenney2 53

5 years ago

Edited 5 years ago

01while true do
02    game:GetService("RunService").Heartbeat:Wait()
03    if(sound.TimePosition >= 73.8) and (not fade) then
04        fade = true
05        for i = 0, 1, -0.1 do
06            sound.Volume = i
07            wait(0.5)
08        end
09        sound.TimePosition = 0
10        for i = 0, 1, 0.1 do
11            sound.Volume = i
12            wait(0.5)
13        end
14        fade = false
15    end
16end

sound.TimePosition = 0 is being ran before the for loop finishes, causing the audio to abruptly jump back to the beginning instead of slowly fading out, then going back to the beginning after the fade finishes. I can confirm that this is the issue as I have another script printing the audio's TimePosition every heartbeat. No other scripts are affecting the audio.

1 answer

Answered by

Psudar 882

5 years ago

It's probably because you're stepping with -0.1 even though your goal is 1 in the first loop. As well as this, checking the time can be pretty hacky. I'd recommend using the Sound.Ended event.

In addition to using an infinite loop, i think it might be better if you just set the Loop property of the sound object to true, then use the Ended and Played event instead.

01Sound.Looped = true
02 
03Sound.Played:Connect(function()
04    --fade in
05    for i = 0, 1, 0.1 do
06        Sound.Volume = i
07        wait(0.5)
08    end
09end)
10 
11Sound.Ended:Connect(function()
12    --fade out
13    for i = 1, 0, -0.1 do
14        Sound.Volume = i 
15        wait(0.5)
16    end
17end)

Hopefully this helps.

I'm using a loop because I want the song to fade out before the song actually ends. Also, this solution would cause the fade out to begin *after* the audio has already ended. I don't need the song to fade out precisely at 73.8 seconds, and I understand that my solution is hacky. hpenney2 53 — 5y

Also, my goal *is* to get to 0 in the first loop. hpenney2 53 — 5y

good point, my bad. i wasnt thinking about the ended event. surely you can use it for .Played tho. as for .ended, just replace it with waiting for the time and such. Psudar 882 — 5y

How can I prevent this code from being ran before this for loop finishes?

1 answer

Answer this question