Scripting Helpers is winding down operations and is now read-only. More info→

Remote event not firing in a while true do loop when more than 1 player joins?

Asked by

Asynchronize 16

5 years ago

Edited 5 years ago

The script works fine for when the first player joins and starts the server (playing the music and showing the song name) but when another player joins, it just plays the music and doesn't show the song name for them until it switches to another song.

Script in Sound:

01local Sound = Instance.new("Sound", game.Workspace)
02 
03Sound.Name = "SongAcreol2"
04 
05local musicList = require(game.ServerScriptService.SongList)
06 
07local Event = game.ReplicatedStorage.ApoxyzMusicChange
08 
09local musicName = musicList
10 
11local Activate = false
12 
13local keys = {}
14 
15for key, _ in pairs(musicList) do
16    table.insert(keys, key)
17end
18 
19game.Players.PlayerAdded:Connect(function(player)
20 
21    if Activate == false then
22 
23        Activate = true
24 
25        while true do
26 
27            local Change = game.ReplicatedStorage.ChangeSong
28 
29            Change.OnServerEvent:Connect(function(player, text)
30 
31                Sound:Stop()
32 
33                wait(0.5)
34 
35                Sound.SoundId = "rbxassetid://"..text
36 
37                local musicNameInfo = game:GetService("MarketplaceService"):GetProductInfo(text).Name
38                Event:FireAllClients(musicNameInfo)
39 
40                Sound:Play()
41 
42                Sound.Ended:Wait()
43 
44            end)
45 
46            local Skip = game.ReplicatedStorage.SkipSong
47 
48            Skip.OnServerEvent:Connect(function()
49 
50                Sound:Stop()
51 
52                wait(0.5)
53 
54                local randomKey = keys[math.random(#keys)]
55 
56                Sound.SoundId = "rbxassetid://"..randomKey
57 
58                musicName = musicList[randomKey]
59                Event:FireAllClients(musicName)
60 
61                Sound:Play()
62 
63                Sound.Ended:Wait()
64 
65            end)
66 
67            wait(0.5)
68 
69            local randomKey = keys[math.random(#keys)]
70 
71            Sound.SoundId = "rbxassetid://"..randomKey
72 
73            Sound:Play()
74 
75            musicName = musicList[randomKey]
76            Event:FireAllClients(musicName)
77 
78            Sound.Ended:Wait()
79 
80        end
81 
82    end
83 
84    Event:FireClient(player, musicName)
85 
86end)
 View all 86 lines...

Local Script in TextLabel:

1local Event = game.ReplicatedStorage.ApoxyzMusicChange
2 
3Event.OnClientEvent:Connect(function(musicName)
4    if musicName then
5        script.Parent.Text = musicName
6    end
7end)

2 answers

Answered by

Torren_Mr 334

5 years ago

You forgot to make the Activate value false at the end.

Try using this code:

01local Event = game.ReplicatedStorage.ApoxyzMusicChange
02 
03local Activate = false
04 
05game.Players.PlayerAdded:Connect(function()
06 
07    if Activate == false then
08 
09        Activate = true
10 
11        while true do
12 
13            wait(0.5)
14 
15            local randomKey = keys[math.random(#keys)]
16 
17            script.Parent.SoundId = "rbxassetid://"..randomKey
18 
19            local musicName = musicList[randomKey]
20            Event:FireAllClients(musicName)
21 
22            script.Parent:Play()
23 
24            script.Parent.Ended:Wait()
25            Activate = false --Added the line. 
26        end
27        --Put the line I added here if it doesn't work.
28    end
29end)
 View all 29 lines...

If the script above doesn't work in the way you wanted it to, try moving the line I added 2 lines below.

Answered by

SteelMettle1 394

5 years ago

Edited 5 years ago

Hey bud, I was helping you out with your other post on this. All you need to do to fix this is add one line of code and change the order around a little. Here is your updated code:

01local Event = game.ReplicatedStorage.ApoxyzMusicChange
02local musicName = "" -- moved the scope outside so it can be used outside of the while loop
03local Activate = false
04 
05game.Players.PlayerAdded:Connect(function(player) --Added player to capture the newly joined player
06 
07    if Activate == false then
08 
09        Activate = true
10 
11        while true do
12 
13            wait(0.5)
14 
15            local randomKey = keys[math.random(#keys)]
16 
17            script.Parent.SoundId = "rbxassetid://"..randomKey
18 
19            musicName = musicList[randomKey] -- removed local from in front of here
20            Event:FireAllClients(musicName)
21 
22            script.Parent:Play()
23 
24            script.Parent.Ended:Wait()
25 
26        end
27    end
28    Event:FireClient(player, musicName) -- This will only send musicName to players that join. FireClient must always send the individual player, but the local script does not need to include the player, so don't change your local script.
29end)
 View all 29 lines...

Also, I remember your other post on this, so don't change Activate back to false. You wanted the while loop to run only once as I remember. I hope this helps out! If it doesn't, please keep this post opened and add a comment under my post. I check my answers for feedback regularly.

I also noticed that you structured your code differently than what I did to prevent the Studio bug. Unless they fixed this (it's been around for a long time, so doubtful) you will definitely experience the bug as your game grows. It's ultimately your choice, but I promise it will save you some headache down the line.

[EDIT] The second problem probably should've been in another post since it was new problems based off of your changes, but I fixed it for you anyway. All I did was move some things around a little bit, you were definitely on the right track.

Here is the updated script:

01local Sound = Instance.new("Sound", game.Workspace)
02Sound.Name = "SongAcreol2"
03local musicList = { --replace this with your module script
04    ["356718047"] = "N'to Trauma",
05    ["372492410"] = "Tell Me Why",
06    ["2468961271"] = "Mine The Diamond"
07    }
08local Event = game.ReplicatedStorage.ApoxyzMusicChange
09local musicName --If you have a huge song list, then it's better not to have the same information in two places. No need to set this to any value.
10local Activate = false
11local keys = {}
12local Change = game.ReplicatedStorage.ChangeSong
13local Skip = game.ReplicatedStorage.SkipSong
14 
15for key, _ in pairs(musicList) do
16    table.insert(keys, key)
17end
18 
19local function Music() --Originally made this function because I thought I would need to kill multiple threads
20    while true do
21        wait(0.5)
22        local randomKey = keys[math.random(#keys)]
23        Sound.SoundId = "rbxassetid://"..randomKey
24        Sound:Play()
25        musicName = musicList[randomKey]
26        Event:FireAllClients(musicName)
27        Sound.Ended:Wait()
28    end
29end
30game.Players.PlayerAdded:Connect(function(player)
31    if Activate == false then
32        Activate = true
33        Music() -- Just calling a function, you can still think of the while loop as being in here
34    end
35    Event:FireClient(player, musicName)
36end)
37 
38--[[ Commented out since I'm not really sure the difference between the skip and Change events
39Change.OnServerEvent:Connect(function(player, text)
40    Sound:Stop()
41    wait(0.5)
42    Sound.SoundId = "rbxassetid://"..text
43    local musicNameInfo = game:GetService("MarketplaceService"):GetProductInfo(text).Name
44    Event:FireAllClients(musicNameInfo)
45    Sound:Play()
46    Sound.Ended:Wait()
47end)
48--]]
49Skip.OnServerEvent:Connect(function()
50    Sound:Stop()
51    wait(0.5)
52    local randomKey = keys[math.random(#keys)]
53    Sound.SoundId = "rbxassetid://"..randomKey
54    musicName = musicList[randomKey]
55    Event:FireAllClients(musicName)
56    Sound:Play()
57    Sound.Ended:Wait()
58 
59end)
 View all 59 lines...

A good rule of thumb is don't embed event-driven functions within one another. If you need several functions to use the same variables, then increase the scope of the variables to the highest scope. Be careful when doing this though, you'll need to account for the different values of the variable in the different functions.

I tested it as well in Studio for single and multiple players with the skip button, without the skip button, letting the song finish, and combinations of the three.

Seems to be working great, thank you, this has been aggravating me for awhile. I deleted the other post because I didn't realize you'd come back to check the comment I posted. This code is supposed to run constantly, not just once but it still works and the song changes and shows the name for everyone even when they join. Thank you again! Asynchronize 16 — 5y

Any time, glad to help! SteelMettle1 394 — 5y

Yeah it broke again, it works great when you first join but when the song switches it just breaks. I'm getting sick of this, do you have any suggestions? I edited the post and made it the full script. Asynchronize 16 — 5y

I think I've fixed your changes. SteelMettle1 394 — 5y

View all comments (5 more)

For some reason it still isn't working, it's being really weird but I don't want to bother you again with this. I've just been really busy with work so I can't work on this that much as I want too. It's been making me mad lol. I'll probably work on it later on with some of yours tips to help me. Thanks for everything. Asynchronize 16 — 5y

It sometimes stops playing for the 2nd half of the song, after a switch it will sometimes start a song already half way through, sometimes just switches and shows the song name but doesn't play the song. Not sure if you know what could be causing any of this? Asynchronize 16 — 5y

Your first problem may be from Roblox only allowing 1 minute 20 second audio files. So if you have a song that's 3 minutes long, you'll need at least 2 audio files (you'll still lose the last 20 seconds of the song though unless you play a third audio file). SteelMettle1 394 — 5y

As far as the second problem, I'm honestly not sure. I tested the code given in every way I could think of and it worked just fine. This tells me there's something else in your code that I don't have, unless of course it's because of the 1 minute 20 second problem. SteelMettle1 394 — 5y

I'm not too sure either man, thanks for your help though. Asynchronize 16 — 5y

Remote event not firing in a while true do loop when more than 1 player joins?

2 answers

Answer this question