DataStore either not saving or not loading properly?

Asked by

5 years ago

it prints that data is saved, loaded etc but when it comes to actually loading the data it doesn't seem to function properly. no error is given

001local dataStore = game:GetService("DataStoreService"):GetDataStore("Test3")
002 
003game.Players.PlayerAdded:Connect(function(player)
004 
005 
006 
007    local stats = Instance.new("Folder")
008    stats.Name = "leaderstats"
009    stats.Parent = player
010 
011    local kills = Instance.new("IntValue")
012    kills.Name = "Eliminations"
013    kills.Value = 0
014    kills.Parent = stats
015 
016    local deaths = Instance.new("IntValue")
017    deaths.Name = "Deaths"
018    deaths.Value = 0
019    deaths.Parent = stats
020 
021    local careerKills = Instance.new("IntValue")
022    careerKills.Name = "Career Eliminations"
023    careerKills.Parent = stats
024 
025    local careerDeaths = Instance.new("IntValue")
026    careerDeaths.Name = "Career Deaths"
027    careerDeaths.Parent = stats
028 
029    local careerWins = Instance.new("IntValue")
030    careerWins.Name = "Career Wins"
031    careerWins.Parent = stats
032 
033    local careerLosses = Instance.new("IntValue")
034    careerLosses.Name = "Career Losses"
035    careerLosses.Parent = stats
036 
037    local credits = Instance.new("IntValue")
038    credits.Name = "Credits"
039    credits.Parent = stats
040 
041    local ID = "SAVE-"..player.UserId
042    local saves = {careerKills.Value,careerDeaths.Value,careerWins.Value,careerLosses.Value,credits.Value}
043    local savedData = nil
044 
045    pcall(function()
046        savedData = dataStore:GetAsync(ID,saves)
047    end)
048 
049    if savedData == nil then
050        careerWins.Value = 0
051        careerLosses.Value = 0
052        careerKills.Value = 0
053        careerDeaths.Value = 0
054        credits.Value = 500
055        print("New Player")
056    else
057        careerKills.Value = savedData[1]
058        careerDeaths.Value = savedData[2]
059        careerWins.Value = savedData[3]
060        careerLosses.Value = savedData[4]
061        credits.Value = savedData[5]
062        print("Data Loaded")
063    end
064end)
065 
066game.Players.PlayerRemoving:Connect(function(player)
067    local ID = "SAVE-"..player.UserId
068    local careerKills =  player.leaderstats["Career Eliminations"]
069    local careerDeaths =  player.leaderstats["Career Deaths"]
070    local careerWins =  player.leaderstats["Career Wins"]
071    local careerLosses =  player.leaderstats["Career Losses"]
072    local credits =  player.leaderstats["Credits"]
073    local saves = {careerKills.Value,careerDeaths.Value,careerWins.Value,careerLosses.Value,credits.Value}
074 
075        pcall(function()
076        dataStore:SetAsync(ID,saves)
077        print("Saved")
078        end)
079    end)
080 
081game:BindToClose(function()
082    for i,player in pairs(game.Players:GetPlayers()) do
083        if player then
084            player:Kick("Shutting Down")
085        end
086    end
087 
088    wait(5)
089    end)
090 
091 
092local function AutoSave()
093    while true do
094        local ID = "SAVES-"..Player.UserId
095        local saves = {careerKills.Value,careerDeaths.Value,careerWins.Value,careerLoses.Value,credits.Value}
096 
097        dataStore:SetAsync(ID,saves)
098        print("Auto Save")
099        wait(60)
100    end
101end
 View all 101 lines...

Troubleshooting:

It worked when I tested it BUT if you have any issues with saving, try these troubleshooting:

1) Go to Studio -> Home tab -> Game settings (it's a blue gear) -> Options -> and turn on all three options.

2) Sometimes studio is wonky not saving datastores, so try playing in game and see what happens.

3) Another thing to look out for, make sure you're changing the values inside the objects on the server If you change them in the properties in play mode or in a local script, they won't change. only if you change them in a server script or [click this button to go into server mode (https://imgur.com/a/pSjaUYT)

If neither of those work, we can take a look at your game thru team create and see why it isnt working.

Code:

001local dataStore = game:GetService("DataStoreService"):GetDataStore("Test4")
002 
003function createValueObjects(player)
004    local leaderstatsFolder = Instance.new("Folder")
005    leaderstatsFolder.Name = "leaderstats"
006    leaderstatsFolder.Parent = player
007 
008    local kills = Instance.new("IntValue")
009    kills.Name = "Eliminations"
010    kills.Value = 0
011    kills.Parent = leaderstatsFolder
012 
013    local deaths = Instance.new("IntValue")
014    deaths.Name = "Deaths"
015    deaths.Value = 0
016    deaths.Parent = leaderstatsFolder
017 
018    local careerKills = Instance.new("IntValue")
019    careerKills.Name = "Career Eliminations"
020    careerKills.Parent = leaderstatsFolder
021 
022    local careerDeaths = Instance.new("IntValue")
023    careerDeaths.Name = "Career Deaths"
024    careerDeaths.Parent = leaderstatsFolder
025 
026    local careerWins = Instance.new("IntValue")
027    careerWins.Name = "Career Wins"
028    careerWins.Parent = leaderstatsFolder
029 
030    local careerLosses = Instance.new("IntValue")
031    careerLosses.Name = "Career Losses"
032    careerLosses.Parent = leaderstatsFolder
033 
034    local credits = Instance.new("IntValue")
035    credits.Name = "Credits"
036    credits.Parent = leaderstatsFolder
037 
038    return careerKills, careerDeaths, careerWins, careerLosses, credits
039end
040 
041function saveData(player)
042    local careerKills =  player.leaderstats["Career Eliminations"]
043    local careerDeaths =  player.leaderstats["Career Deaths"]
044    local careerWins =  player.leaderstats["Career Wins"]
045    local careerLosses =  player.leaderstats["Career Losses"]
046    local credits =  player.leaderstats["Credits"]
047 
048    print("values to save", careerKills.Value,careerDeaths.Value,careerWins.Value,careerLosses.Value,credits.Value)
049 
050    local saves = {careerKills.Value,careerDeaths.Value,careerWins.Value,careerLosses.Value,credits.Value}
051 
052    local success, err = pcall(function()
053        dataStore:SetAsync("SAVE-"..player.UserId,saves)
054        print("Saved data for "..player.Name)
055    end)
056 
057    if not success then error(err) end 
058end
059 
060function getData(player)
061    local dataFromDatastore 
062 
063    local success, err = pcall(function()
064        dataFromDatastore = dataStore:GetAsync("SAVE-"..player.UserId)
065    end)
066 
067    if not success then error(err) end 
068    return dataFromDatastore
069end
070 
071game.Players.PlayerAdded:Connect(function(player)
072    local careerKills, careerDeaths, careerWins, careerLosses, credits = createValueObjects(player)
073    local dataFromDatastore = getData(player)
074 
075 
076    if not dataFromDatastore then
077        careerWins.Value = 0
078        careerLosses.Value = 0
079        careerKills.Value = 0
080        careerDeaths.Value = 0
081        credits.Value = 500
082        print("New Player joined the game")
083    else
084        careerKills.Value = dataFromDatastore[1]
085        careerDeaths.Value = dataFromDatastore[2]
086        careerWins.Value = dataFromDatastore[3]
087        careerLosses.Value = dataFromDatastore[4]
088        credits.Value = dataFromDatastore[5]
089        print("Data Loaded")
090    end
091end)
092 
093game.Players.PlayerRemoving:Connect(function(player)
094    saveData(player)
095end)
096 
097game:BindToClose(function()
098    if game:GetService("RunService"):IsStudio() then return end
099 
100    for _,player in pairs(game.Players:GetPlayers()) do
101        saveData(player)
102    end
103end)
104 
105--ADDS ONE TO TO THE PLAYERS CARRER ELIMINATIONS EVERY SECOND.
106--THIS IS JUST FOR TESTING THAT THE DATASTORE WORKS
107--DELETE AFTER YOU'RE DONE TESTING
108spawn(function()
109    while true do
110        wait(1)
111        for _, player in pairs(game.Players:GetPlayers())do
112            player.leaderstats["Career Eliminations"].Value = player.leaderstats["Career Eliminations"].Value + 1
113        end
114    end
115end)
116 
117--AUTOSAVES EVERYONE'S DATA
118while true do
119    for _,player in pairs(game.Players:GetPlayers()) do
120        saveData(player)
121    end
122    wait(60)
123end
 View all 123 lines...

PS, only 4 of your values in the leaderstats will load. The values will be in the leaderstats and this script will work, but only four will show up on the leaderboard as you can see here. The solution to this would be to either use a custom leaderboard / use guis instead or don't display so many stats.

DataStore either not saving or not loading properly?

1 answer

Troubleshooting:

Code:

Answer this question