Scripting Helpers is winding down operations and is now read-only. More info→

How do i get my timer to work for my Combo System?

Asked by

rexpex 45

5 years ago

I'm trying to make a combo system that resets to the initial animation it started with if the player remains idle after attacking. It would go to 1,2,3,4,5 then reset back to 1; but if you were idle and stopped at 3 it would go 1,2,3 wait and back to 1.

But the local-script I have right now doesn't reset it at all, it just keeps going with the regular cycle of 1,2,3,4,5

01local uis = game:GetService("UserInputService")
02 
03local repstorage = game:GetService('ReplicatedStorage')
04    local events  = repstorage:FindFirstChild("Events")
05    local modules = repstorage:FindFirstChild("Modules")
06 
07 
08local player = game.Players.LocalPlayer
09    local char = player.Character or player.CharacterAdded:Wait()
10 
11repeat wait() until player:HasAppearanceLoaded()
12 
13local current  = 1
14local cooldown = false
15 
16local startTime = tick()
17local maxTime = 1.5
18 
19local animTable = {
20        "rbxassetid://04540124455",
21        "rbxassetid://04540153886",
22        "rbxassetid://04540429673",
23        "rbxassetid://4540628785" ,
24        "rbxassetid://4540931147" 
25}
26 
27 
28 
29uis.InputBegan:Connect(function(input)
30    if input.UserInputType == Enum.UserInputType.MouseButton1 and not char:FindFirstChildOfClass("Tool") and not cooldown then
31        cooldown = true
32 
33        startTime = tick()  --------TIMER SCRIPT[[
34            spawn(function()
35                if(tick() - startTime) > maxTime then
36                    startTime = tick()
37                    current = 1
38                    print("waited too long, combo reseted to first animation")
39                end
40            end)           ----------TIMER SCRIPT END]]
41 
42        local hum = char:FindFirstChild("Humanoid")
43 
44        local a1 = Instance.new("Animation")
45        a1.AnimationId = animTable[current]
46 
47        local track  = hum:LoadAnimation(a1)
48        track:Play()
49 
50 
51            track.KeyframeReached:Connect(function(frame)
52                if frame == "Hit" then
53                    local part = Instance.new("Part")
54 
55                end
56            end)
57            track.Stopped:Connect(function()
58                if current ~= #animTable then
59                    current = current + 1
60 
61                else
62                    current = 1
63 
64                end
65 
66                print(current)
67                cooldown = false
68            end)
69    end
70end)
 View all 70 lines...

Are you using a loop? and maybe try setting Line 67 to 0 instead of false aj44000 2 — 5y

Im not using a loop, also cooldown is a boolean for my debounce that dictates whether a player can hit again; so, i cant set that to 0 rexpex 45 — 5y

1 answer

Answered by

GrandSnaf 77

5 years ago

Edited 5 years ago

In your spawn() function, you don't have a loop to constantly check to see if it needs to reset their current combo. So it'll run a single time once you spawn the function, and of course since it's running only once as soon as you spawn the function, the passed time won't be passed your maxTime

With that being said, this should fix your problem

01local uis = game:GetService("UserInputService")
02 
03local runservice = game:GetService("RunService");
04 
05local repstorage = game:GetService('ReplicatedStorage')
06local events  = repstorage:FindFirstChild("Events")
07local modules = repstorage:FindFirstChild("Modules")
08 
09 
10local player = game.Players.LocalPlayer
11    local char = player.Character or player.CharacterAdded:Wait()
12 
13repeat wait() until player:HasAppearanceLoaded()
14 
15local current  = 1
16local cooldown = false
17 
18local startTime = tick()
19local maxTime = 1.5
20 
21local animTable = {
22        "rbxassetid://04540124455",
23        "rbxassetid://04540153886",
24        "rbxassetid://04540429673",
25        "rbxassetid://4540628785" ,
26        "rbxassetid://4540931147" 
27}
28 
29 
30 
31uis.InputBegan:Connect(function(input)
32    if input.UserInputType == Enum.UserInputType.MouseButton1 and not char:FindFirstChildOfClass("Tool") and not cooldown then
33        cooldown = true
34 
35        startTime = tick()  --------TIMER SCRIPT[[
36            spawn(function()
37                repeat -- loop added so it's constantly checking
38                    runservice.Heartbeat:Wait()
39                until (tick() - startTime) > maxTime 
40                startTime = tick()
41                current = 1
42                print("waited too long, combo reseted to first animation")
43            end)           ----------TIMER SCRIPT END]]
44 
45 
46        local hum = char:FindFirstChild("Humanoid")
47 
48        local a1 = Instance.new("Animation")
49        a1.AnimationId = animTable[current]
50 
51        local track  = hum:LoadAnimation(a1)
52        track:Play()
53 
54 
55            track.KeyframeReached:Connect(function(frame)
56                if frame == "Hit" then
57                    local part = Instance.new("Part")
58 
59                end
60            end)
61            track.Stopped:Connect(function()
62                if current ~= #animTable then
63                    current = current + 1
64 
65                else
66                    current = 1
67 
68                end
69 
70                print(current)
71                cooldown = false
72            end)
73    end
74end)
 View all 74 lines...

Thanks a lot, worked like a charm rexpex 45 — 5y

How do i get my timer to work for my Combo System?

1 answer

Answer this question