Scripting Helpers is winding down operations and is now read-only. More info→

Timing listeners using BindableEvents won't fire?

Asked by

compUcomp 417

5 years ago

I have this BindableEvent named "AddListener". It's parented to my timing script, which listens for these events and triggers the callback given when the time specified is reached. The signature is AddListener:Fire(id, triggerTime, cb). The first parameter is an identifier for the listener so I can remove it later if needed, kind of like with ContextActionService:BindAction. The second parameter is the number of minutes after midnight when the third parameter, the callback, should be executed. This is the timing script:

01local listeners = {}
02local AddListener = Instance.new("BindableEvent")
03AddListener.Event:Connect(function (id, triggerTime, cb)
04    listeners[id] = {
05        ["triggerTime"] = triggerTime, 
06        ["cb"] = cb
07    }
08end)
09AddListener.Parent = script
10local RemoveListener = Instance.new("BindableEvent")
11RemoveListener.Event:Connect(function (id)
12    listeners[id] = nil
13end)
14RemoveListener.Parent = script
15min = 0
16minRate = 60 -- how many times faster than a minute irl
17 
18while true do
19    game.Lighting:SetMinutesAfterMidnight(min)
20    local actualTime = wait(60 / minRate) / (60 / minRate) -- corrects for lag
21    for i, v in pairs(listeners) do
22        if v.triggerTime > min and v.triggerTime < min + actualTime then
23            v.cb()
24            print("executed timing listener with id " .. i) -- doesn't print
25        end
26    end
27    min = min + actualTime
28end
 View all 28 lines...

This is the listener, from another script:

1local sss = game:GetService("ServerScriptService")
2local addListener = sss.TimingScript:FindFirstChild("AddListener") or sss.TimingScript:WaitForChild("AddListener")
3addListener:Fire("test", 60, function ()
4    print("hello world!") -- doesn't print
5end)

Both of these are server scripts. No errors are thrown, but neither of the print statements are ran.

1 answer

Answered by

NiniBlackJackQc 1562

5 years ago

Edited 5 years ago

If you want, you can use _G to make a global variable.

01local listeners = {}
02 
03local AddListener = Instance.new("BindableEvent")
04AddListener.Event:Connect(function(id, triggerTime, cb)
05    listeners[id] = {
06        ["triggerTime"] = triggerTime, 
07        ["cb"] = cb
08    }
09    cb() -- Take you sure you called your function.
10end)
11 
12local RemoveListener = Instance.new("BindableEvent")
13RemoveListener.Event:Connect(function (id)
14    listeners[id] = nil
15end)
16 
17_G.GlobalVariables = {Added = AddListener, Remove = RemoveListener}

You can wait this variable with this function who return the Global Variable when is created with the other script. It's my personal method and other scripters use that.

01local GlobalVariables = (function()
02    repeat
03        wait()
04        if _G.GlobalVariables ~= nil then
05            return _G.GlobalVariables 
06        end
07    until _G.GlobalVariables
08end)()
09 
10GlobalVariables.Added:Fire("test", 60, function()
11    print("hello world!")
12end)

You don't have to assign a parent to your BindableEvent, he exist yet.

To any question post it on the commentaries!!

_G is slow because it doesn't know where the variable is and has to make a lot of checks which is slow, use module scripts or value objects if you really want a `global variable` royaltoe 5144 — 5y

I don't know but I use it everywhere and "Mad Games" has used this feature on each of its scripts. I think it's a good method. Personally I use module script when I want create a more complicate systeme and not just for a BindableEvent lol.. But indeed when you don't know what do you doing it's easily broken. NiniBlackJackQc 1562 — 5y

Thanks! I don't know what changed, but using _G works. compUcomp 417 — 5y

Timing listeners using BindableEvents won't fire?

1 answer

Answer this question