Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
0

Is It possible to make FindFirstChild find a part with another parts name?

Asked by
TFlanigan 86
5 years ago

so i want to find a workspace child with a folders name, for example if folder name is abc, i want it to find a child in workspace with folders name, in this case its gonna be abc.

my english isnt too god but i hope you understand what im talking about

0
no i mean if i have a part named ABC, its gonna find a child in workspace which is also named ABC TFlanigan 86 — 5y
0
ok so look im making a tycoon. and i want to make it so the cash from ore goes directly to player. furnace contains a folder which is automatically named with the players name when he joins (since its a singleplayer tycoon). Then i want to do something like this: game.Players:GetPlayerFromCharacter(game.Workspace:findFirstChild(folder.name)), but it doesnt work. TFlanigan 86 — 5y
0
Try replacing that last line with, "game:GetService("Players"):FindFirstChild(folder.Name)" MegaManSam1 207 — 5y
0
doesnt work TFlanigan 86 — 5y
View all comments (2 more)
0
Can you post your code and explorer? MegaManSam1 207 — 5y
0
ok ill post it in answers soon TFlanigan 86 — 5y

3 answers

Log in to vote
0
Answered by
haba_nero 386 Moderation Voter
5 years ago

Ok! Here it is! Put this script inside the folder:

view source
1local Folder = script.Parent
2local Child = game.Workspace:WaitForChild(Folder.Name)
3If Child then
4    --Do whatever you want!
5end
Ad
Log in to vote
0
Answered by
TFlanigan 86
5 years ago
Edited 5 years ago

ok so heres the script

view source
01local furnace = script.Parent.Parent
02wait(0.5)
03local folder = script.Parent.Name
04furnace.Touched:Connect(function(hit)
05    if hit:FindFirstChild("Cash") then
06        local player = game.Players:GetPlayerFromCharacter(game.Workspace:FindFirstChild(folder.name))
07        multiplier = script.Parent.Parent.Parent.Multiplier.Value
08        wait(0.1)
09        hit.BrickColor = BrickColor.new("Dark stone grey")
10        wait(0.1)
11        hit.BrickColor = BrickColor.new("Really black")
12        wait(0.1)
13        player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + hit.Cash.Value * multiplier
14        hit:Destroy()
15    end
16end)

and heres the explorer http://prntscr.com/qry9ow

oh ye and i changed the code to what it was before since none of answers worked

0
What is the "aaa" on line 6? MegaManSam1 207 — 5y
0
i just changed it to something random since it didnt work. ima change it to folder.name now tho TFlanigan 86 — 5y
0
it doesnt work even with folder.name tho TFlanigan 86 — 5y
0
You've made sure that when you test your game the folders name is changed to the player's name? MegaManSam1 207 — 5y
View all comments (4 more)
0
yes it is TFlanigan 86 — 5y
0
http://prntscr.com/qryml4 TFlanigan 86 — 5y
0
Any errors? Describe in as much detail as you can what you want to happen and what is happening right now. MegaManSam1 207 — 5y
0
No errors until ore hits the furnace. When it does i get this: 21:13:27.157 - Argument 1 missing or nil TFlanigan 86 — 5y
Log in to vote
0
Answered by
chess123mate 5873 Moderation Voter Community Moderator
5 years ago
Edited 5 years ago

You should only use GetPlayerFromCharacter if you have the player's character. Since you don't have it (you're hoping to look it up but as you've mentioned there are multiple things in the workspace with the player's name), it is better to just use game.Players:FindFirstChild(folder.Name) That could only fail if you put things directly in game.Players.

You have a few other problems with your script:

  • multiplier should be local. If you declare it local on the same line as multiplier = then if Multiplier.Value changes while the animation plays, the cash will be increased by the "old" value (which is probably what you want). If you declare it local at the top of the script (which has the same end result as not declaring it local at all, but it is good practice to declare your variables 'local'), then if a Cash Object #1 hits, then the Multiplier increases (or decreases), then Cash Object #2 hits, all in the span of 0.2 seconds, then both Cash Objects will increase the player's cash by the new multiplier. Another option is to access Multiplier.Value at the very last moment (when you increase cash).
  • If a Cash object bounces/hits the furnace a few times in a row, it will end up awarding cash for each time it makes contact. To fix this, you can track the object in a table (but be sure to remove it from the table before the end of the function).

Resulting script:

view source
01local furnace = script.Parent.Parent
02wait(0.5)
03local folder = script.Parent.Name
04local touched = {} -- Dictionary of parts that have already made contact with the furnace
05local multiplierObject = script.Parent.Parent.Parent.Multiplier
06furnace.Touched:Connect(function(hit)
07    if touched[hit] then return end -- already handling 'hit'
08    local hitCash = hit:FindFirstChild("Cash")
09    if hitCash and hitCash:IsA("IntValue") then
10        touched[hit] = true
11        local player = game.Players:FindFirstChild(folder.Name)
12        local multiplier = multiplierObject.Value
13        wait(0.1)
14        hit.BrickColor = BrickColor.new("Dark stone grey")
15        wait(0.1)
View all 28 lines...

Note that I used FindFirstChild on the leaderstats and Cash to ensure that the script doesn't error (ex if the player left right after they received a cash value), or else a memory leak would occur (since touched[hit] would remain true forever). An other option is to mark the touched table as having weak keys, which tells Roblox/Lua that it can remove objects from the table if they're not referenced by anything else: local touched = setmetatable({}, {__mode="k"}).

Answer this question