Scripting Helpers is winding down operations and is now read-only. More info→

Need help with MouseClick Event?

Asked by

JoneXI 51

5 years ago

Hello, I have a problem with my script. I have three different parts every second they change their color from red to green with math.random. Basiclly its a color cycle. So my problem is that have a part and its transparency is 1.

1if part1.BrickColor = Brickcolor.new("Dark Green") then
2click.MouseClick:Connect(function()(
3    Number1.Transparency = 0
4end)
5end

thats what I want to happen. When the button is red then nothing happens - thats ok. When it gets green and I click on it - it works, but when it hits green and then I wait till it hits red again i click and it works as well - thats bad. I know it might be complicated to understand... Any solutions? whole Script:

01Number1 = script.Parent.Number1
02part1 = script.Parent.part1
03part2 = script.Parent.part2
04part3 = script.Parent.part3
05click = script.Parent.part1.ClickDetector
06-- Properties 
07Number1.Transparency = 1
08part1.BrickColor = BrickColor.new("Really red")
09part2.BrickColor = BrickColor.new("Really red")
10part3.BrickColor = BrickColor.new("Really red")
11--Code
12while true do
13    RandomPart = math.random(1,3)
14    wait(1)
15 
16if RandomPart == 1 then
17    part1.BrickColor = BrickColor.new("Dark green")
18    part2.BrickColor = BrickColor.new("Really red")
19    part3.BrickColor = BrickColor.new("Really red")
20    part4.BrickColor = BrickColor.new("Really red")
21    part5.BrickColor = BrickColor.new("Really red")
22    part6.BrickColor = BrickColor.new("Really red")
23    part7.BrickColor = BrickColor.new("Really red")
24    part8.BrickColor = BrickColor.new("Really red")
25    part9.BrickColor = BrickColor.new("Really red")
26elseif RandomPart == 2 then
27    part1.BrickColor = BrickColor.new("Really red")
28    part2.BrickColor = BrickColor.new("Dark green")
29    part3.BrickColor = BrickColor.new("Really red")
30    part4.BrickColor = BrickColor.new("Really red")
31    part5.BrickColor = BrickColor.new("Really red")
32    part6.BrickColor = BrickColor.new("Really red")
33    part7.BrickColor = BrickColor.new("Really red")
34    part8.BrickColor = BrickColor.new("Really red")
35    part9.BrickColor = BrickColor.new("Really red")
36elseif RandomPart == 3 then
37    part1.BrickColor = BrickColor.new("Really red")
38    part2.BrickColor = BrickColor.new("Really red")
39    part3.BrickColor = BrickColor.new("Dark green")
40wait(1)
41end
42if part1.BrickColor == BrickColor.new("Dark green") then
43    click.MouseClick:Connect(function()
44    Number1.Transparency = 0
45    end)
46end
47end
 View all 47 lines...

Thank you.

2 answers

Answered by

awesomebanana2018 36

5 years ago

The problem is that once you start listening for the mouseclick, it listens no matter what.

1click.MouseClick:Connect(function()
2    if part1.BrickColor = BrickColor.new("Dark Green") then
3        Number1.Transparency = 0
4    end
5end)

Answered by

Benbebop 1049

5 years ago

Edited 5 years ago

First of all, for changing the color I would recommend using a table instead of separate values.

Ex.

1Local PartTable = {PartA, PartB, PartC}
2 
3For i=1,#PartTable do
4    PartTable[i].PartColor = “Really Red”
5end

{} creates a table containing its parameters, i is what item in the table it’s on and a number/variable contained in square brackets [] are which value in the table you want

As for fixing the problem, try having the mouse event happen before checking the color. Also try formatting it as a string instead of color.

Ex.

1click.MouseClick.Connect(function()
2    if PartTable[1].PartColor == “Really Red” then
3        -- code --
4    end
5end)

For more see Tables

{} doesn't make a value a table. {} is the table constructor. In fact, all Lua datatypes but tables are immutable. programmerHere 371 — 5y

That is what I meant by “{} make a value a table”, though I do see how that could be confusing. I edited it and it should be fixed. Benbebop 1049 — 5y

Need help with MouseClick Event?

2 answers

Answer this question