Scripting Helpers is winding down operations and is now read-only. More info→

Can anyone help me fix this difficult datastore bug?

Asked by

St_vnC 330

5 years ago

I have problems with my RPG datastore here's save/Load data part of the script :

001local Players = game:GetService("Players")
002local DataStoreService = game:GetService("DataStoreService")
003local RunService = game:GetService("RunService")
004local ReplicatedStorage = game:GetService("ReplicatedStorage")
005 
006local DataStore = DataStoreService:GetDataStore('Data')
007 
008-- Settings
009local StarterData = {
010    MaxChar = 5;
011    LStats = {
012        Lvl = 1;
013        XP = 0;
014        Coins = 0;
015    };
016 
017    savedStats = {
018        Mana = 50;
019        Health = 100;
020        Class = "Adventurer";
021        CharName = "Name";
022        CurrentPlace = 0;
023        CurrentPos = Vector3.new(0,0,0)
024    };
025    Stats = {
026        HitChance = 0;
027        CritChance = 0;
028        Attack = 0;
029        MagicAttack = 0;
030        Defense = 0;
031        MagicDefense = 0;
032        Dodge = 0;
033    };
034    StatPts = {
035        Strength = 5;
036        Intelligence = 5;
037        Dexterity = 5;
038        Agility = 5;
039        Vitality = 5;
040    };
041    Char = {
042        HairStyle = "Default";
043        HairColor = Color3.new(0,0,0);
044        Gender = "Boy";
045        SkinColor = BrickColor.new("Light orange").Color;
046        Mustache = "None";
047        Eye = "Default";
048        EyeColor = Color3.new(0.1,0.05,0)
049    };
050    Inventory = {      
051        MaxSlots = 50;
052        SlotSample = {
053            Item = "Rock";
054            Type = "Equipments";
055            EquipType = "Weapons";
056            WeaponType = "None";
057            Stackable = false;
058            Stack = 0;
059        };
060        EquipmentSlotSample = {
061            Item = "Rock";
062            WeaponType = "None";
063        }
064    };
065};
066local playersavetable = {};
067local AUTO_SAVE_INTERVAL = 180;
068 
069-- Functions
070 
071local function loadData(Player)
072    local Data
073    local s,e pcall(function()
074        Data = DataStore:GetAsync('UserId:'..Player.UserId)
075    end)
076 
077    if s then
078        print('Loading '.. Player.Name .."'s data was successful!")
079    else
080        print('Something went wrong!')
081    end
082 
083    if Data then
084        for num,Slot in pairs(Player.Slots:GetChildren()) do
085            for name, value in pairs(Data) do
086                if not Slot.leaderstats:FindFirstChild(name) then return end
087                Slot.leaderstats[name].Value = value
088            end
089            for name, value in pairs(Data) do
090                if not Slot.StatPts:FindFirstChild(name) then return end
091                Slot.StatPts[name].Value = value
092            end
093            for name, value in pairs(Data) do
094                if not Slot.savedStats:FindFirstChild(name) then return end
095                Slot.savedStats[name].Value = value
096            end
097            for name, value in pairs(Data) do
098                if not Slot.Char:FindFirstChild(name) then return end
099                Slot.Char[name].Value = value
100            end
101        end
102        for _, Folder in pairs(Player.Slots["Slot"..CurrentSlot.Value]:GetChildren()) do
103            for _,Stat in pairs(Folder:GetChildren()) do
104                Player[Folder.Name][Stat.Name].Value = Stat.Value
105            end
106        end
107        print('Data has been loaded')
108    else
109        print(Player.Name ..'has no data! Generating new data.')
110    end
111 
112end
113 
114local function saveData(Player)
115    if RunService:IsStudio() then return end
116    local Data = {}
117    -- Transfers char Current Data to current char slot.
118        local Slot = Player.CurrentSlot.Value
119        local Current_Slot = "Slot"..Slot
120        for _,stat in pairs(Player.Slots[Current_Slot].leaderstats:GetChildren()) do
121            stat.Value = Player[stat.Parent.Name][stat.Name].Value
122        end
123        for _,stat in pairs(Player.Slots[Current_Slot].StatPts:GetChildren()) do
124            stat.Value = Player[stat.Parent.Name][stat.Name].Value
125        end
126        for _,stat in pairs(Player.Slots[Current_Slot].savedStats:GetChildren()) do
127            stat.Value = Player[stat.Parent.Name][stat.Name].Value
128        end
129        for _,stat in pairs(Player.Slots[Current_Slot].Stats:GetChildren()) do
130            stat.Value = Player[stat.Parent.Name][stat.Name].Value
131        end
132    for i,v in pairs(Player.Slots:GetChildren()) do
133        for _,stat in pairs(v.leaderstats:GetChildren()) do
134            Data[stat.Name] = stat.Value
135        end
136        for _,stat in pairs(v.StatPts:GetChildren()) do
137            Data[stat.Name] = stat.Value
138        end
139        for _,stat in pairs(v.savedStats:GetChildren()) do
140            Data[stat.Name] = stat.Value
141        end
142        for _,stat in pairs(v.Stats:GetChildren()) do
143            Data[stat.Name] = stat.Value
144        end
145    end
146    local s,e pcall(function()
147         DataStore:SetAsync('UserId:'..Player.UserId, Data)
148    end)
149    if s then
150        print('Success')
151    else
152        warn('Failed to save '.. Player.Name.. "'s data.")
153    end
154end
 View all 154 lines...

I always have problems saving data(outside of studio) it keeps printing the error message when I see no errors. I'm pretty sure I didn't exceed the DataStore budget limit, you can check if I'm wrong tho. This DataStore system is based on Mystifine's system https://www.youtube.com/watch?v=at9Yhjt572c

1 answer

Answered by

Foxy_Developer 111

5 years ago

Ok, lets try it

Firs Step : We need to know how to acces to the DataStoreService and how it works! So lets see how we can get the service!

`1`	`local` `ds` `=` `game:GetService("DataStoreService")`

`2`	--> This is all! Is a service of the Instance "game" so you can get it with `GetService()`

That's how we get the DataStoreService in one simple line of code!

Second Step : Second, we need to know how to use correctly the DataStore so we have to make another variable that contains the data of the currency or etc we want to Store on the service!

1local ds = game:GetService("DataStoreService")
2local moneyDs = ds:GetDataStore("moneyData") 
3--[[
4    This is all! The service "DataStore" have a function to get the Data already stored in
5    so we called with the function "GetDataStore"
6]]

That's how we create a variable with the data we want to save. So lets make now a leaderstats functional with the SaveData

Third Step : Enjoy coding! You always have to enjoy what are you doing! Play some music while you script or even you can play a game before to be relaxed!

Lets get into code!

01local ds1 = game:GetService("DataStoreService")
02local moneyDs = ds1:GetDataStore("moneyData")
03local ds2 = game:GetService("DataStoreService")
04local xpDs = ds2:GetDataStore("xpData")
05local ds3 = game:GetService("DataStoreService")
06local lvlDs = ds3:GetDataStore("levelData")
07local ds4 = game:GetService("DataStoreService")
08local rxpDs = ds4:GetDataStore("requiredxpData")
09 
10game.Players.PlayerAdded:Connect(function(plr)
11    local folder = Instance.new("Folder", plr)
12    folder.Name = "leaderstats"
13 
14    local money = Instance.new("IntValue", folder)
15    money.Name = "Money"
16    money.Value = moneyDs:GetAsync(plr.UserId) or 0
17    --> If the player is new and doesn't have data stored will get the value 0
18    money.Changed:Connect(function()
19        moneyDs:SetAsync(plr.UserId, money.Value)
20        -->When the player get some monye then inmediately will store!
21    end)
22 
23    local xp = Instance.new("IntValue", folder)
24    xp.Name = "XP"
25    xp.Value = xpDs:GetAsync(plr.UserId) or 0  
26    xp.Changed:Connect(function()
27        xpDs:SetAsync(plr.UserId, xp.Vaue) -->The same like on the money
28    end)
29 
30    local rxp = Instance,new("IntValue", folder)
31    rxp.Name = "RequiredXP
32    rxp.Value = rxpDs:GetAsync(plr.UserId) or 100 --> Put your required xp for the first level
33    rxp.Changed:Connect(function()
34        rxpDs:SetAsync(plr.UserId, rxp.Value)
35    end)
36 
37    local level = Instance.new("IntValue", folder)
38    level.Name = "Level"
39    level.Value = lvlDs:GetAsync(plr.UserId) or 0
40    level.Changed:Connect(function()
41        lvlDs:SetAsync(plr.UserId, level.Value)
42    end)
43 
44    if xp.Value >= rxp.Value then
45        xp.Value = xp.Value - rxp.Value
46        rxp.Value + 1000 --> This will require for the next level
47        level.Value = level.Value + 1 -->Give one level to the player
48    elseif xp.Value <= rxp.Value then
49        print("You don't have enough experience! Get more to level up!")
50    end
51end)
52 
53game.Players.PlayerRemoving:Connect(function(plr)
54    moneyDs:SetAsync(plr.UserId, plr.leaderstats.Money.Value)
55    xpDs:SetAsync(plr.UserId, plr.leaderstats.XP.Value)
56    lvlDs:SetAsync(plr.UserId, plr.leaderstats.Level.Value)
57    --> We are saving all the values!
58end)
59 
60local warnMessage = "The code is incorrect"
61pcall(warnMessage)
 View all 61 lines...

That's how we use the DataStore correctly and easy. I write all the code here on scriptinghelpers so that's the why I don't answer faster.

I hope my answer already solve your question! If its like that please accept my answer. That will help me a lot!

Keep scripting!

That’s great but I don’t want to copy and paste. Also I want to know what’s wrong in my code St_vnC 330 — 5y

Ok, I'll explain you on Discord. Foxy_Developer 111 — 5y

But later, I'll check the advanced DataStore function. And I'll try to explain you how it works. Cya Foxy_Developer 111 — 5y

Can anyone help me fix this difficult datastore bug?

1 answer

Answer this question