Scripting Helpers is winding down operations and is now read-only. More info→

why does my button door not work at all? i dont know what I did wrong

Asked by

MrCreepyPeach 22

5 years ago

Edited 5 years ago

I made a simple door that, if you press the button, the door should lift up. There is a value that states if it is open or closed or not. It doesn't work for some reason. I need to mention 4 things before I show the script:

I do NOT know how to tween (im an amutuer i know)
It uses CFrame and Vector3 to make it slide
there are 2 buttons, so when it says button1, it refers to the first button
It's a long script (which like i said i dont know how to tween)

with that being said here is the script.

001local door = script.Parent.Parent.Door
002local button2 = script.Parent.ClickDetector
003local open_close = door.Open_Close
004local sound = script.Parent.Parent.metal_door
005 
006local function open()
007    sound:Play()
008    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
009    wait(0.001)
010    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
011    wait(0.001)
012    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
013    wait(0.001)
014    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
015    wait(0.001)
016    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
017    wait(0.001)
018    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
019    wait(0.001)
020    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
021    wait(0.001)
022    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
023    wait(0.001)
024    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
025    wait(0.001)
026    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
027    wait(0.001)
028    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
029    wait(0.001)
030    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
031    wait(0.001)
032    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
033    wait(0.001)
034    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
035    wait(0.001)
036    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
037    wait(0.001)
038    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
039    wait(0.001)
040    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
041    wait(0.001)
042    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
043    wait(0.001)
044    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
045    wait(0.001)
046    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
047    wait(0.001)
048    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
049    wait(0.001)
050    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
051    wait(0.001)
052    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
053    wait(0.001)
054    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
055    wait(0.001)
056    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
057    wait(0.001)
058    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
059    wait(0.001)
060    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
061    wait(0.001)
062    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
063    wait(0.001)
064    door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
065    wait(0.001)
066end
067 
068local function close()
069    sound:Play()
070    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
071    wait(0.001)
072    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
073    wait(0.001)
074    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
075    wait(0.001)
076    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
077    wait(0.001)
078    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
079    wait(0.001)
080    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
081    wait(0.001)
082    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
083    wait(0.001)
084    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
085    wait(0.001)
086    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
087    wait(0.001)
088    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
089    wait(0.001)
090    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
091    wait(0.001)
092    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
093    wait(0.001)
094    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
095    wait(0.001)
096    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
097    wait(0.001)
098    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
099    wait(0.001)
100    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
101    wait(0.001)
102    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
103    wait(0.001)
104    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
105    wait(0.001)
106    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
107    wait(0.001)
108    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
109    wait(0.001)
110    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
111    wait(0.001)
112    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
113    wait(0.001)
114    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
115    wait(0.001)
116    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
117    wait(0.001)
118    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
119    wait(0.001)
120    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
121    wait(0.001)
122    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
123    wait(0.001)
124    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
125    wait(0.001)
126    door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
127    wait(0.001)
128end
129 
130button2.MouseClick:Connect(function()
131    if open_close == false then
132        open_close = true
133        open()
134    elseif open_close == true then
135        open_close = false
136        close()
137    end
138end)
 View all 138 lines...

edit: fixed, thanks to repgainer3. thank you so much.

1 answer

Answered by

repgainer3 35

5 years ago

Hi, frankly I am horrified by this code. But don't worry, we've all been there! What you're missing are loops, in the case specifically, we're looking for for loops.

for loops allow you to run lines of code a specified number of times without needing to type all of them out.

Example:

1local Part = workspace.Part
2 
3for i = 1, 100 do
4    wait(0.1)
5    Part.CFrame = CFrame.new(Part.Position + Vector3.new(0, 0.1, 0))
6end

This code will run the wait and the Part.CFrame = lines 100 times and then continue with the script.

Furthermore, wait(0.001) can not be done. If you are looking for the fasted wait possible, you can simply write wait() with no argument. I believe the lowest by default is 0.03 repeating.

To be exact, your problem is that you're treating the variable open_close as if it were a boolean value, or a true or false value, when in reality it is not, it's an object. If the object is a BoolValue like I assume it is, you'll need to add .Value to the end to specify it's value.

Also, I would use a debounce here to make sure that both open() and close() aren't able to fire at the same time, all it does is makes sure you can't click the door until it's either fully open or fully closed.

01local door = script.Parent.Parent.Door
02local button2 = script.Parent.ClickDetector
03local open_close = door.Open_Close
04local sound = script.Parent.Parent.metal_door
05 
06local door_debounce = false
07 
08function open()
09    sound:Play()
10    for i = 1, 29 do
11        wait()
12        door.CFrame = CFrame.new(door.Position + Vector3.new(0, 0.1, 0))
13    end
14end
15 
16function close()
17    sound:Play()
18    for i = 1, 29 do
19        wait()
20        door.CFrame = CFrame.new(door.Position - Vector3.new(0, 0.1, 0))
21    end
22end
23 
24button2.MouseClick:Connect(function()
25    if door_debounce then return end
26    door_debounce = true
27    if open_close.Value == true then
28        open_close.Value = false
29        close()
30    else
31        open_close.Value = true
32        open()
33    end
34    wait(1)
35    door_debounce = false
36end)
 View all 36 lines...

oh my gosh, thank you so much. I'm going to try this right now MrCreepyPeach 22 — 5y

why does my button door not work at all? i dont know what I did wrong

1 answer

Answer this question