Scripting Helpers is winding down operations and is now read-only. More info→

attempt to index local 'player' a nil value?

Asked by

smash_abIe 19

5 years ago

Edited 5 years ago

01_G.Data = {
02koins = 500,
03level = 1,
04rank = "Bronze",
05print('make sure to add jersey'),
06--Helmet = (link)
07--Helmet.Name = "Helmet",
08--local mouthp = Instance.new("MeshPart",Data),
09--mouthp.Name = "Mouthpiece",
10xp = 1
11}
12 
13local DSS = game:GetService("DataStoreService")
14 
15local datastore = DSS:GetDataStore("YourChampion")
16 
17 
18function generateDataKey(player)
19        local ret = "cid_"..player.userId
20        return ret
21end
22 
23 
24for index,value in pairs (_G.Data) do
25    datastore:UpdateAsync(index, function() return value end) -- index will be our 
26end
27 
28 
29 
30function generateDataTable(player)
31    local dataTable = {
32        koins = player.PlayerGui.Nice.Data.koins.Value,
33        level = player.PlayerGui.Nice.Data.Level.Value,
34        xp = player.PlayerGui.Nice.Data.xp.Value,
35        rank = player.PlayerGui.Nice.Data.Rank.Value
36    }
37    return dataTable
38end
39 
40function saveDataForPlayer(player)
41local Success, ErrorMsg = pcall(function()
42  print('Saving Data') 
43  local key = generateDataKey(player)
44  local data = generateDataTable(player) 
45  datastore:SetAsync(key, data) 
46end)
47 
48if not Success then
49warn(ErrorMsg) -- if it errors, it will provide a reason on why it errored 
50end
51    local key = generateDataKey(player)
52    local data = generateDataTable(player)
53    datastore:SetAsync(key, data)
54end
55 
56function inputDataToPlayer(player, data)
57    player.PlayerGui.Nice.Data.koins.Value = data.koins
58    player.PlayerGui.Nice.Data.Level.Value = data.Level
59    player.PlayerGui.Nice.Data.xp.Value = data.xp
60    player.PlayerGui.Nice.Data.Rank.Value = data.Rank
61end
62 
63function loadDataForPlayer(player)
64    local key = generateDataKey(player)
65    local data = datastore:GetAsync(key)
66    inputDataToPlayer(player, data)
67end
68 
69if _G.Data == nil then
70    inputDataToPlayer()
71else
72    loadDataForPlayer()
73end
74 
75 
76game.Players.PlayerAdded:connect(function(player)
77    loadDataForPlayer(player) --Load first thing when they join
78                player.PlayerGui.Nice.Data.Rank.Changed:connect(function()
79                    saveDataForPlayer(player)
80                    end)
81end)
82 
83game.Players.PlayerRemoving:connect(saveDataForPlayer()) --Save data when the player leaves the game
84`Workspace.Data:19: attempt to index local 'player' (a nil value)`
 View all 84 lines...

Please post the code, where you used the generateDataKey function cegberry 432 — 5y

edited smash_abIe 19 — 5y

1 answer

Answered by

FrogNinjaX 222

5 years ago

Firstly, use :Connect not :connect. The latter is deprecated and may stop working at any point.

Secondly, as the error clearly states, you are attempting to index something for your variable 'player' which hasn't been defined. This can be troubleshooted by going through your code and looking at all the places you use your 'player' variable, then see if the player has been defined at that point.

Going through your code, the 'player' variable is indeed NOT defined for your functions because they all take in the 'player' parameter but that variable is not passed when you actually call the functions here:

1if _G.Data == nil then
2    inputDataToPlayer()
3else
4    loadDataForPlayer()
5end

and here:

`1`	`game.Players.PlayerRemoving:connect(saveDataForPlayer())`

To fix this, simply put the 'player' variable in the parenthesis so that you pass that variable to your functions.

attempt to index local 'player' a nil value?

1 answer

Answer this question