Script won't stop adding trees - how to stop?
So this code is a plugin, which adds trees at the mouse's location. When I click to stop, it does not work. Here is the code:
01 | -- Create a new toolbar section titled "Custom Script Tools" |
02 | open = false |
03 | local player = game.Players.LocalPlayer |
04 | local mouse = player:GetMouse() |
05 | local toolbar = plugin:CreateToolbar("Custom Script Tools") |
06 | local ChangeHistoryService = game:GetService("ChangeHistoryService") |
07 |
08 |
09 | -- Add a toolbar button named "Create Empty Script" |
10 | local newScriptButton = toolbar:CreateButton("Create Snow Tree", "Create a Snow Tree", "rbxassetid://4458901886") |
11 |
12 | local function onNewScriptButtonClicked() |
13 | if open == false then |
14 | open = true |
15 | print("Awesomemode14 Plugin is Open") |
Thanks for the Help!
0
1 answer
For this problem you should familiarize yourself with Events, like for instance the Button1Down mouse Event which fires a signal every time the mouse button is pressed down.
Your current issue is that you are binding the mouse click to your function Button1Down:Connect(function() but then have no way to disconnect this event afterwards. What's worse, you try to bind a new function to this event, creating an ever increasing memory leak.
What you should do, is store the event you are binding as a variable - which can be done like so:
1 | local treeEvent = mouse.Button1Down:Connect(function() |
2 | --stuff |
3 | end) |
This is possible because the :Connect function returns the event it creates!
So now that we have the event stored in a variable, we can call the :Disconnect() function whenever we want to stop the game from listening for your mouse click.
This means replacing:
1 | mouse.Button1Up:Connect(function()end) |
With:
1 | treeEvent:Disconnect() |
Hope this helps!
0
0