Scripting Helpers is winding down operations and is now read-only. More info→
Log in to vote
0
Why gets everyplayer an amount of cash when one single player is clicking a tool?
I think it has something to do with the remote event.
The server event script for the tool:
01 | local liftSwordEvent = game.ReplicatedStorage.RemoteEvents:WaitForChild("LiftSword") |
02 |
03 |
04 | liftSwordEvent.OnServerEvent:Connect(function(player,cashIncreaseValue) |
05 | local cash = game.Players[script.Parent.Parent.Name].leaderstats.Cash |
06 |
07 | for i, toolsInCharacter in pairs(script.Parent.Parent:GetChildren()) do |
08 |
09 | if toolsInCharacter and toolsInCharacter:IsA("Tool") then |
10 | local cashIncrease = toolsInCharacter:WaitForChild("CashIncrease") |
11 |
12 | local multiplier = toolsInCharacter:WaitForChild("CashMultiplier") |
13 |
14 | if multiplier then |
15 | cash.Value = cash.Value + cashIncrease.Value * multiplier.Value |
16 | end |
17 | end |
18 | end |
19 | end) |
The local script for the tool:
1 | local sword = script.Parent |
2 | local liftSwordEvent = game.ReplicatedStorage.RemoteEvents:WaitForChild("LiftSword") |
3 |
4 | sword.Activated:Connect(function() |
5 | if sword.Parent == game.Players.LocalPlayer.Character then |
6 | liftSwordEvent:FireServer() |
7 | end |
8 | end) |
The leaderstats script
01 | game.Players.PlayerAdded:Connect(function(player) |
02 | local folder = Instance.new("Folder",player) |
03 | folder.Name = "leaderstats" |
04 |
05 | local cash = Instance.new("IntValue",folder) |
06 | cash.Name = "Cash" |
07 | cash.Value = 1500 |
08 |
09 | local weaponsOwned = Instance.new("Folder",player) |
10 | weaponsOwned.Name = "weaponsowned" |
11 |
12 | local sword1owned = Instance.new("BoolValue",weaponsOwned) |
13 | sword1owned.Name = "Sword1owned" |
14 | sword1owned.Value = false |
15 |
16 | local sword2owned = Instance.new("BoolValue",weaponsOwned) |
17 | sword2owned.Name = "Sword2owned" |
18 | sword2owned.Value = false |
19 | end) |
Thanks!
0
Then my answer is still valid since characters cannot equip more than 1 tool at the same time programmerHere 371 — 5y
1 answer
Log in to vote
1
Not sure what is up, tbh I never even looked. But you can simplify this code. First up why is there a for loop? Just to check if there is a tool equipped? Use :FindFirstChildOfClass here.
Also you do not need :WaitForChild since the objects will be loaded in already.
01 | local liftSwordEvent = game.ReplicatedStorage.RemoteEvents:WaitForChild("LiftSword") |
02 |
03 |
04 | liftSwordEvent.OnServerEvent:Connect(function(player) |
05 | local cash = player.leaderstats.Cash |
06 | local tool = player.Character:FindFirstChildOfClass("Tool") |
07 |
08 | if tool then |
09 | local cashIncrease = tool.CashIncrease |
10 | local multiplier = tool.CashMultiplier |
11 | cash.Value = cash.Value + cashIncrease.Value*multiplier.Value |
12 | end |
13 | end) |
And for your Activated listener... why test if they have the tool equipped when Activated ONLY fires if the tool is even equipped? How can you activate it without it even being equipped?
1 | sword.Activated:Connect(function() |
2 | liftSwordEvent:FireServer() |
3 | end) |
0
I use the loop to get the values of the variables inside the sword so I can reference it to the script thebigwalkingdoor 0 — 5y
0
Well you did not specify what script.Parent.Parent is so I could not get your question programmerHere 371 — 5y
0
script.parent.parent leads to the character of the player. thebigwalkingdoor 0 — 5y