Scripting Helpers is winding down operations and is now read-only. More info→

[SOLVED] My music player script plays two songs at once. Fix?

Asked by

QuantumPlasmic 84

5 years ago

Edited 5 years ago

I want to improve my music player script. Right now, when a player presses a button, the music is toggle on/off. However, since the script waits for the sound to end, if the sound is paused, the script doesn't exit the "if" statement, meaning that if that sound ends after being toggled back on, it will play two sounds. (sorry if that's confusing, basically my script sometimes plays two songs at once)

01local btn = script.Parent
02local db = true
03local val = script.Parent.Toggle
04local ss = game.SoundService
05local s1 = ss.Sound1
06local s2 = ss.Sound2
07local s3 = ss.Sound3
08local s4 = ss.Sound4
09local s5 = ss.Sound5
10 
11val.Changed:Connect(function()
12    if val.Value == true then
13    btn.Text = "Music ON"
14    while true do
15        local n = math.random(1,5)
16        if n == 1 then
17            s1:Play()
18            wait(0.1)
19            db = true
20            s1.Ended:Wait()
21        elseif n == 2 then
22            s2:Play()
23            wait(0.1)
24            db = true
25            s2.Ended:Wait()
26        elseif n == 3 then
27            s3:Play()
28            wait(0.1)
29            db = true
30            s3.Ended:Wait()
31        elseif n == 4 then
32            s4:Play()
33            wait(0.1)
34            db = true
35            s4.Ended:Wait()
36        elseif n == 5 then
37            s5:Play()
38            wait(0.1)
39            db = true
40            s5.Ended:Wait()
41        end
42    end
43    elseif val.Value == false then
44        btn.Text = "Music OFF"
45        s1.Playing = false
46        s2.Playing = false
47        s3.Playing = false
48        s4.Playing = false
49        s5.Playing = false
50    end
51end)
 View all 51 lines...

Please help if you know a solution, thanks!

2 answers

Answered by

TheRealPotatoChips 793

5 years ago

Edited 5 years ago

Try this:

01local btn = script.Parent
02local db = true
03local val = script.Parent.Toggle
04local ss = game.SoundService
05local s1 = ss.Sound1
06local s2 = ss.Sound2
07local s3 = ss.Sound3
08local s4 = ss.Sound4
09local s5 = ss.Sound5
10 
11val.Changed:Connect(function()
12    if val.Value == true then
13    btn.Text = "Music ON"
14    while true do
15        local n = math.random(1,5)
16        if n == 1 then
17            s1:Play()
18            wait(0.1)
19            db = true
20            s1.Ended:Wait()
21        elseif n == 2 then
22            s2:Play()
23            wait(0.1)
24            db = true
25            s2.Ended:Wait()
26        elseif n == 3 then
27            s3:Play()
28            wait(0.1)
29            db = true
30            s3.Ended:Wait()
31        elseif n == 4 then
32            s4:Play()
33            wait(0.1)
34            db = true
35            s4.Ended:Wait()
36        elseif n == 5 then
37            s5:Play()
38            wait(0.1)
39            db = true
40            s5.Ended:Wait()
41        end
42    wait(s..n.TimeLength)
43    end
44    elseif val.Value == false then
45        btn.Text = "Music OFF"
46        s1.Playing = false
47        s2.Playing = false
48        s3.Playing = false
49        s4.Playing = false
50        s5.Playing = false
51    end
52end)
 View all 52 lines...

So that wait(s..n.TimeLength) will let the infinite loop wait for the song to finish before choosing another song randomly.

Answered by

QuantumPlasmic 84

5 years ago

Edited 5 years ago

Actually I've figured it out. Since a script is 'restarted' when it's disabled and then re-enabled, I can make a script just for playing the music and make another script for changing the button's text and enabling and disabling the music player script.

Disabler/Enabler Script

01--Main variables--
02local btn = script.Parent
03local db = true --debounce
04local val = script.Parent.Toggle
05 
06--Music variables--
07local ss = game.SoundService
08local s1 = ss.Sound1
09local s2 = ss.Sound2
10local s3 = ss.Sound3
11local s4 = ss.Sound4
12local s5 = ss.Sound5
13 
14btn.MouseButton1Click:Connect(function()
15    if db == true then
16        db = false
17        if script.Parent.MusicPlayer.Disabled == false then
18            script.Parent.MusicPlayer.Disabled = true
19            btn.Text = "Music OFF"
20            s1.Playing = false --Each song would need to be toggled off
21            s2.Playing = false --or else they would keep playing while
22            s3.Playing = false --the script (when it resets) plays
23            s4.Playing = false --another song.
24            s5.Playing = false
25            wait(0.2)
26            db = true
27        elseif script.Parent.MusicPlayer.Disabled == true then
28            script.Parent.MusicPlayer.Disabled = false
29            btn.Text = "Music ON"
30            wait(0.2)
31            db = true
32        end
33    end
34end)
 View all 34 lines...

Music Player Script

01local ss = game.SoundService
02local s1 = ss.Sound1
03local s2 = ss.Sound2
04local s3 = ss.Sound3
05local s4 = ss.Sound4
06local s5 = ss.Sound5
07 
08while true do
09    local n = math.random(1,5)
10    if n == 1 then
11        s1:Play()
12        wait(0.1)
13        db = true
14        s1.Ended:Wait()
15    elseif n == 2 then
16        s2:Play()
17        wait(0.1)
18        db = true
19        s2.Ended:Wait()
20    elseif n == 3 then
21        s3:Play()
22        wait(0.1)
23        db = true
24        s3.Ended:Wait()
25    elseif n == 4 then
26        s4:Play()
27        wait(0.1)
28        db = true
29        s4.Ended:Wait()
30    elseif n == 5 then
31        s5:Play()
32        wait(0.1)
33        db = true
34        s5.Ended:Wait()
35    end
36end
 View all 36 lines...

[SOLVED] My music player script plays two songs at once. Fix?

2 answers

Answer this question