Why does my music hardly ever play?
Okay, so I am trying to create a shuffled playlist using 9 different sound instances, and a single script. The objective is to play each songs once, until they are all played, and then start over.
Currently, the only time music is played is when the first song is supposed to start. The first song is only played about 25% of the time. I have checked everywhere I can think of for answers, and no dice. My code is:
01 | -- made by oCrxptic |
02 |
03 | local length = 0 |
04 | local songs = game.ReplicatedStorage.Songs:GetChildren() |
05 | while true do |
06 | wait(0.1) |
07 | if #songs >= 1 then -- Music available to be played |
08 | print("Playing") |
09 | local index = math.random(1,#songs) |
10 | songs[index]:Play() |
11 | print("Playing: "..songs[index].Name) |
12 | length = math.ceil(songs[index].TimeLength) |
13 | table.remove(songs,index) |
14 | wait(length) |
15 | elseif #songs <= 0 then |
Line 12 always prints a new song name when it is supposed to, which is weird to me, because then I would think that the song should also be playing.
Any help is appreciated!
1
0
1 answer
Honestly I don't know what is the issue but you can definitely clean this up a bit.
First don't hardcode wait the length of each song.
Sounds have a Ended event which fires when the song ends. Think smarter, not harder. So use that.
see what i did there
Second, don't repeat yourself, you kept indexing for songs[index] when you can just use a variable to reference the sound.
I also added a function that plays a song and waits for it to end.
01 | local songs = game:GetService("ReplicatedStorage").Songs:GetChildren() |
02 |
03 | local function play_song_and_wait(song) |
04 | song:Play() |
05 | song.Ended:Wait() |
06 | end |
07 |
08 | while true do |
09 | play_song_and_wait(songs[1]) |
10 | play_song_and_wait(songs[math.random(2, #songs)]) |
11 | end |
I start at 2 now since the first song is songs[1]. Just so it doesn't potentially replay the same song twice in a row unless that is what you want.