Scripting Helpers is winding down operations and is now read-only. More info→

vampire burning under roofs when it shouldn't? help plz

Asked by

BielNS 40

5 years ago

Edited 5 years ago

soo, im trying to make a jojo game, and one of the script is one where the vampires burn on sun, but touch ended is making it impossible to detect if player is under something that blocks sunlight, soo i keep burning even if im under the roof! plz help

01local service = game:GetService("ReplicatedStorage")
02local folder = service:WaitForChild("Effects")
03local effect = folder:WaitForChild("VFire")
04 
05game.Players.PlayerAdded:Connect(function(plr)
06    plr.CharacterAdded:Connect(function(chr)
07        spawn(function()
08            local vampire = true
09            local touching = false
10 
11            local human = chr:WaitForChild("Humanoid")
12 
13            local torso = chr:WaitForChild("Torso")
14            local head = chr:WaitForChild("Head")
15 
16            --[[
17            local la = chr:WaitForChild("Left Arm")
18            local ra = chr:WaitForChild("Right Arm")
19            local ll = chr:WaitForChild("Left Leg")
20            local rl = chr:WaitForChild("Right Leg")
21            ]]
22 
23            local part = Instance.new("Part",head)
24            part.Name = "SunCheck"
25            part.Massless = true
26            part.CanCollide = false
27            part.Size = Vector3.new(1,50,1)
28            part.Transparency = 0.5
29 
30            local weld = Instance.new("Weld", part)
31            weld.Part0 = head
32            weld.Part1 = part
33            weld.C0 = weld.C0
34            weld.C1 = weld.C1 * CFrame.new(0,-25.5,0)
35 
36            local FireParticle = effect:Clone()
37            FireParticle.Parent = torso
38            if touching then
39                FireParticle.Enabled = false
40            else
41                FireParticle.Enabled = true
42            end
43 
44            part.Touched:Connect(function()
45                touching = true
46            end)
47 
48            part.TouchEnded:Connect(function()
49                touching = false
50            end)
51 
52            while wait(1.5) do
53                if part and chr and human and torso and head and FireParticle and weld then
54                    if not touching then
55                        if vampire then
56                            human:TakeDamage(15)
57                            FireParticle.Enabled = true
58                        end
59                    end
60                else
61                    break
62                end
63            end
64        end)
65    end)
66end)
 View all 66 lines...

Let the poor vampire suffer its fate. It will be over soon. programmerHere 371 — 5y

Touch events is a strange choice of how to do this in the first place. Normally, you'd do some raycasts from various body parts towards the sun, and see if the path is obstructed. EmilyBendsSpace 1025 — 5y

1 answer

Answered by

lazycoolboy500 597

5 years ago

Edited 5 years ago

Since Roblox doesn't have anything that would check if there's anything overhead I would recommend casting a ray. Just note that when you raycast, do not overdo it! Raycasting a lot way too fast can hurt your game performance. The simplest and fastest way to do it can be done by following the following:

Create a new ray:

`1`	`ray` `=` `Ray.new(chr.Head.Position, Vector3.new(0,` `100,` `0))`

This creates a ray that starts at your character's head and finishes 100 studs up into the air.

Then you would want to get anything that the ray collided with:

`1`	`Object, Position` `=` `workspace:FindPartOnRay(ray, chr,` `false,` `true)`

This looks for any collisions in the ray. The first thing you put into it is the ray itself, the second thing is what to ignore (which is the character because that doesn't count as an object overhead), the third is something you can ignore for now (leave it false), and the last one is to ignore water as being something it hits. Object is the part or whatever the ray hit and Position is the position of that object that the ray hit.

Lastly, you check if it hit something (check if it isn't nil).

1if (Object) then
2    --Your code when it detects that there's an object overhead
3else
4    --Your code when the ray doesn't hit anything (nothing is overhead)
5end

Note that this ray will not ignore players that jump on your head because we only told it to ignore your own character.

To fix this issue we can look if there is a "Humanoid" within the object we hit.

1if (Object) then
2    if (not Object:FindFirstChild("Humanoid")) then --Checks to see if there isn't a humanoid object in the object the ray hit
3        --Your code when it detects that there's an object overhead
4    end
5else
6    --Your code when the ray doesn't hit anything (nothing is overhead)
7end

I recommend learning more about raycasting here and here so you can fix your own issues and so you can understand how it works better. This will help you understand what you are doing.

If you have any questions or issues please contact me. ;)

thx it worked BielNS 40 — 5y

vampire burning under roofs when it shouldn't? help plz

1 answer

Answer this question