While Loop duplicating, why?[SOLVED]
Hello everyone! I am creating a simulator game, and there's an area where you "sell" your parts collected for in-game currency! And where if you do not have enough, it clones a GUI to player GUI inside the script, and tweens it to you!
Now, EVERYTHING in this script functions, but, it creates multiple of the GUI if you don't have enough, and does the math function:
1 | player.leaderstats.Collected.Value / 2 + player.leaderstats.BrickBux.Value |
more than one time!
I'd like to know how to make this While Loop only execute ONCE, and only be reusable after a specific amount of time! I've tried using the wait() functions in order to make this function, but it doesn't seem to work! My full script (ServerScript)will be listed below my end!
Any and ALL help is appreciated! Thank you, ~BryanFehr
01 | while true do |
02 | local debounce = false |
03 | wait(10) |
04 | script.Parent.Touched:Connect(function(hit) |
05 | local player = game:GetService("Players"):GetPlayerFromCharacter(hit.Parent) |
06 | if player and debounce == false then |
07 | debounce = true |
08 | if player.leaderstats.Collected.Value >1 then |
09 | player.leaderstats.BrickBux.Value = player.leaderstats.Collected.Value / 2 + player.leaderstats.BrickBux.Value |
10 | wait(5) |
11 | player.leaderstats.Collected.Value = 0 |
12 | else |
13 | local cloneui = script.notenoughparts:Clone() |
14 | cloneui.Parent = player.PlayerGui |
15 | cloneui.Frame:TweenPosition(UDim2.new(0.3, 0,0.3, 0)) |
2 answers
I'm assuming you want the part to be touched within the 10 second window and it goes away for a certain amount of time before restarting and doing it again.
I modified it slightly to store the connection inside a variable and to disconnect and reconnect it whenever it loops through.
If you read through my comments in the code you should know what I'm trying to do.
01 | local connection |
02 |
03 | while true do |
04 | wait(10) --//This is the amount of time before you can touch the part |
05 |
06 | local debounce = false |
07 | connection = script.Parent.Touched:Connect(function(hit) --//Store the connection inside the variable "connection" |
08 | local player = game:GetService("Players"):GetPlayerFromCharacter(hit.Parent) |
09 | if player and debounce == false then |
10 | debounce = true |
11 | if player.leaderstats.Collected.Value >1 then |
12 | player.leaderstats.BrickBux.Value = player.leaderstats.Collected.Value / 2 + player.leaderstats.BrickBux.Value |
13 | wait(5) |
14 | player.leaderstats.Collected.Value = 0 |
15 | else |
I could do more to tell you best practices and those sort of problems with your code but honestly I'm tired and this is what I can do right now.
Hope it works.
1
0
0
First of all, remove the loop "while true do", touched event dont need loop and this may be the reason why its duplicating, second, add value = value + value instead of value = value2 + value
example: brickbux.Value = brickbux.Value + collected.value
or else it will go like this
EX: value1 = 532 value2 = 25
value1 = value2 (25) + value1(25)
and that may be the reason that gui duplicated but money didn't
if anything above wasn't the solution soo the reason is maybe that you ain't checking if there is already a gui at player gui
01 | while true do |
02 | local debounce = false |
03 | wait(10) |
04 | script.Parent.Touched:Connect(function(hit) |
05 | local player = game:GetService("Players"):GetPlayerFromCharacter(hit.Parent) |
06 | if player and debounce == false then |
07 | debounce = true |
08 | if player.leaderstats.Collected.Value >1 then |
09 | player.leaderstats.BrickBux.Value = player.leaderstats.Collected.Value / 2 + player.leaderstats.BrickBux.Value |
10 | wait(5) |
11 | player.leaderstats.Collected.Value = 0 |
12 | else |
13 | --//Checking if there ins't already a gui at the playergui |
14 | if not player.PlayerGui:FindFirstChild(script.notenoughparts.Name) then |
15 | local cloneui = script.notenoughparts:Clone() |