If statement trouble, what the heck am I doing wrong??

Asked by

5 years ago

Hi everyone, I'm really really confused. For context, I have a gui in starterGui that has a local script that makes it so when a remote (from my datastore script, ill show it later it's huge lmao) is called to the player, a gui comes up for them to choose 1 of 6 colors. When they choose a color, the color button does invokeserver() to the datastore script, the color is sent from the function on the local script to the receiver on the datastore script so thats how it's obtained.

Then the remote function on the datastore sets a saved bool and string values, with the bool being: "HasChosenColor" and the string just being a tostring() color sent from the local script.

I'm probably not explaining this well, english isn't my first language. I think it'd be better if I showed ya the scripts and did a light explanation on each.

Here's the LocalScript which is a child of the Color Choosing ScreenGui:

01local player = game.Players.LocalPlayer
02local char = player.Character
03script.Parent.Frame.Visible = false
04script.Parent.Frame.Position = UDim2.new(0.31, 0,1.067, 0)
05 
06game.ReplicatedStorage.Remotes.ColorSelectPrompt.OnClientEvent:connect(function(player)
07    wait(3)
08    char.Humanoid.WalkSpeed = 0
09    local fgui1 = script.Parent.Frame
10    local fgui1p = script.Parent
11 
12    fgui1.Visible = true
13    fgui1:TweenPosition(UDim2.new(0.31, 0,0.707, 0))
14end)

This script just shows the gui when a remote is fired on the DataStore script. The remote is fired when "HasChosenColor" value inside the player is false.

Before I show the DataStore script here's the LocalScript that's a child of every TextButton. (This local script is the exact same for every button but the Color at the top matches the button.)

01local result = tostring("Black")
02local plr = game.Players.LocalPlayer
03local pchar = plr.Character
04script.Parent.Size = UDim2.new(0, 76,0, 74)
05script.Parent.MouseButton1Down:connect(function()
06    pchar.Humanoid.WalkSpeed = 16
07    script.Parent:TweenSize(UDim2.new(0, 90,0, 88))
08    script.Parent.Parent.ColorDeepOrange.Active = false
09    script.Parent.Parent.ColorPersimmons.Active = false
10    script.Parent.Parent.ColorInstituionalWhite.Active = false
11    script.Parent.Parent.ColorReallyRed.Active = false
12    script.Parent.Parent.ColorElectricBlue.Active = false
13    game.ReplicatedStorage.Remotes.ColorSelectResult1:InvokeServer(result)
14    script.Parent.Parent.Parent.Frame:TweenPosition(UDim2.new(0.31, 0,1.067, 0))
15    script.Parent.Parent.Parent.Frame.Visible = false
16    script.Parent.Parent.Parent.Frame.Active = false
17end)

That local script just tells the DataStore script that a color was chosen through a remote function.

Here's the biggy, and if you were confused til now you'll probably understand it. There are a lot of things in this script that don't relate to the problem but I thought I should include the full thing because it contains the error. (Warning, huge script)

001local maxcount = 500000000000
002 
003local dss = game:GetService("DataStoreService"):GetDataStore(REDACTED)
004local di = game:GetService("ServerStorage"):WaitForChild("DataIndex")
005local AutosaveInterval = 60
006game.Players.PlayerAdded:connect(function(player)
007    local playerdata = Instance.new("Folder", di)
008    playerdata.Name = player.Name
009 
010    local din = player.Name
011 
012    local stats = Instance.new("Folder", playerdata)
013    stats.Name = "Stats1"
014 
015    local ArcaneCount = Instance.new("IntValue", stats)
016    ArcaneCount.Name = "Arcane"
017 
018    local leaderstatfolder = Instance.new("Folder", player)
019    leaderstatfolder.Name = "leaderstats"
020 
021    local WillpowerCount = Instance.new("IntValue", stats)
022    WillpowerCount.Name = "Willpower"
023 
024    local HasChosenColor = Instance.new("BoolValue", stats)
025    HasChosenColor.Name = "HasChosenColor"
026 
027    local Arcin = Instance.new("IntValue", leaderstatfolder)
028    Arcin.Name = "Arcine"
029 
030    local lac3 = Instance.new("IntValue", leaderstatfolder)
031    lac3.Name = "Coins"
032 
033    local lac2 = Instance.new("IntValue", leaderstatfolder)
034    lac2.Name = "Willpower"
035 
036 
037    local CoinsCount = Instance.new("IntValue", stats)
038    CoinsCount.Name = "Coins"
039 
040    local ChosenColorB = Instance.new("StringValue", leaderstatfolder)
041    ChosenColorB.Name = "ChosenColorB"
042 
043    local OtherData = Instance.new("Folder", playerdata)
044    OtherData.Name = "Other"
045 
046    --/Loading data
047    local SavedData = dss:GetAsync(player.userId)
048    --local datatable = {SavedData}
049 
050    local BrickCooler = Instance.new("BrickColorValue", OtherData)
051    BrickCooler.Name = "BrickCooler"
052 
053    if HasChosenColor.Value == false then
054        game.ReplicatedStorage.Remotes.ColorSelectPrompt:FireClient(player)
055    else
056        print("cmon put it")
057        BrickCooler.Value = BrickColor.new(ChosenColorB.Value)
058    end
059 
060    --if HasChosenColor.Value == false then
061        --game.ReplicatedStorage.Remotes.ColorSelectPrompt:FireClient(player)
062 
063    --else
064        --di[pname1].OtherData.PlayerColorB.Value = BrickColor.new()
065    --end
066 
067    game.ReplicatedStorage.Remotes.MaxArcane1.OnServerInvoke = function(player, pname)
068        di[pname].Stats1.Arcane.Value = game.ServerStorage.DataIndex[pname].Stats1.Arcane.Value + maxcount
069    game.Players[pname].leaderstats.Arcine.Value = game.Players[pname].leaderstats.Arcine.Value + maxcount
070    end
071 
072 
073 
074    game.ReplicatedStorage.Remotes.MaxWillpower1.OnServerInvoke = function(player, pname)   
075    di[pname].Stats1.Willpower.Value = game.ServerStorage.DataIndex[pname].Stats1.Willpower.Value + maxcount
076    game.Players[pname].leaderstats.Willpower.Value = game.Players[pname].leaderstats.Willpower.Value + maxcount
077    end
078 
079    game.ReplicatedStorage.Remotes.GlobalResetStats.OnServerEvent:connect(function()
080        ArcaneCount.Value = 0
081        WillpowerCount.Value = 0
082        Arcin.Value = 0
083        lac2.Value = 0
084        lac3.Value = 0
085        CoinsCount.Value = 0
086    end)
087 
088    game.ReplicatedStorage.Remotes.ResetStats.OnServerInvoke = function(player, pname)
089        di[pname].Stats1.Willpower.Value = 0
090        game.Players[pname].leaderstats.Willpower.Value = 0
091        di[pname].Stats1.Coins.Value = 0
092        game.Players[pname].leaderstats.Coins.Value = 0
093        di[pname].Stats1.Arcane.Value = 0
094        game.Players[pname].leaderstats.Arcine.Value = 0
095    end
096    game.ReplicatedStorage.Remotes.IncreaseArcane1.OnServerInvoke = function(player, pname)
097        di[pname].Stats1.Arcane.Value = di[pname].Stats1.Arcane.Value + 1
098        game.Players[pname].leaderstats.Arcine.Value = player.leaderstats.Arcine.Value + 1
099    end
100 
101    game.ReplicatedStorage.Remotes.IncreaseWillpower1.OnServerInvoke = function(player, pname)
102        di[pname].Stats1.Willpower.Value = di[pname].Stats1.Willpower.Value + 5
103        game.Players[pname].leaderstats.Willpower.Value = player.leaderstats.Willpower.Value + 5
104    end
105 
106 
107    if SavedData then
108        print('Data currently used:'..game:GetService("HttpService"):JSONEncode(SavedData):len()..'/260000 bytes')
109        for i,v in pairs(SavedData) do
110            print(i,v)
111            if i % 2 == 0 then
112                di[player.Name].Stats1:FindFirstChild(SavedData[i - 1]).Value = v
113            end
114        end
115        Arcin.Value = ArcaneCount.Value
116        lac2.Value = WillpowerCount.Value
117        lac3.Value = CoinsCount.Value
118    end
119end)
120 
121 
122 
123local function SaveStats(player)
124    local DataCollective = {}
125    for i,v in pairs(di[player.Name].Stats1:GetChildren()) do
126        DataCollective[#DataCollective + 1] = v.Name
127        DataCollective[#DataCollective + 1] = v.Value    
128    end
129    --dss:SetAsync(player.userId, game:GetService("HttpService"):JSONEncode(DataCollective))
130    local pnameout = player.Name
131    print(pnameout.."'s Data was saved.")
132    dss:SetAsync(player.userId, DataCollective)
133end
134 
135game.ReplicatedStorage.Remotes.ColorSelectResult1.OnServerInvoke = function(player, result)
136 
137    local din = player.Name
138        di[din].Stats1.HasChosenColor.Value = true
139        game.Players[din].leaderstats.ChosenColorB.Value = result
140        di[din].Other.BrickCooler.Value = BrickColor.new(result)
141end
142 
143--game.ReplicatedStorage.Remotes.SaveStats1.OnServerEvent:connect(function()
144    --for i, player in pairs(game.Players:GetPlayers()) do
145        --SaveStats(player)
146    --end
147--end)
148 
149 
150game:BindToClose(function()
151    for i, player in pairs(game.Players:GetPlayers()) do
152        SaveStats(player)
153    end
154end)
155game.Players.PlayerRemoving:connect(function(player)
156    SaveStats(player) --/Saving data upon the player leaving.
157end)
158 
159while wait(AutosaveInterval) do
160    for i, player in pairs(game.Players:GetPlayers()) do
161        SaveStats(player)
162    end
163end
 View all 163 lines...

Welp, that was big. Anyway, things important to note is a value ChosenColorB is created which acts as the color that is sent from the local script. First thing you'll notice is that BrickCooler (the brickcolor value) isnt saved with the rest. That's intentional because i can't save BrickColor values. So when the remote function from the local script is invoked the brickcolor value is set to the ChosenColorB value, and here's the main problem. "HasChosenColor" is set to true when that remote is invoked.

And I have an if statement higher up in the script at around Line 53. When the game is done doing all the loading the if statement checks if HasChosenColor is false. Naturally it shouldn't be, everytime I choose a color, save, then exit and reload the game the output reads:

Data currently used:58/260000 bytes 1 Arcane 2 0 3 Willpower 4 0 5 HasChosenColor 6 true 7 Coins 8 0

And that's where the madness begins, if it's true and the game knows it, why is the If statement not recognizing that? It's breaking everything and it's so annoying ;-; pls help

If statement trouble, what the heck am I doing wrong??

2 answers

Answer this question