Why does it randomly stop allowing you to punch?

Asked by

5 years ago

Hello, I have been making a punch script (For a fighting game) and so far it has went pretty well, but there's one problem, and that is that if you punch an enemy, sometimes it takes multiple hits, the player will be unable to punch, there are no error messages, and all I know is that it wont turn Hitting.Value to false. Everything else works fine. The layout for items you need is listed here:

LocalScript (Inside of Starter Player Scripts, Parents a animation)

01local UserInputService = game:GetService("UserInputService")
02 
03local function onInputEnded(inputObject, gameProcessedEvent)
04    -- First check if the 'gameProcessedEvent' is true
05    -- This indicates that another script had already processed the input, so this one can be ignored
06    if gameProcessedEvent then return end
07    -- Next, check that the input was a keyboard event
08    if inputObject.UserInputType == Enum.UserInputType.Keyboard then
09        print("A key was released: " .. inputObject.KeyCode.Name)
10        if inputObject.KeyCode.Name == script.Parent.Parent.Backpack.Keys.PunchKey.Value then
11 
12            if script.Parent.Parent.Backpack.UsingAbility.Value == false and script.Parent.Parent.Backpack.Hitting.Value == false then
13                    if game.Players.LocalPlayer.Backpack.Mana.Value > 10 then
14 
15                        print("ability")
16 
17 
18                        local Anim =game.Players.LocalPlayer.Character.Humanoid:LoadAnimation(script:WaitForChild("PunchAnim",1))
19                        print("AnimLoaded")
20                        Anim:Play()
21                        game.ReplicatedStorage.Special:FireServer("Punch")
22                        print("using")
23                        wait(0.4)
24                        Anim:Stop()
25                        wait(0.35)
26 
27 
28                        print("finished")
29 
30                end
31            end
32        end
33    end
34end
35UserInputService.InputEnded:Connect(onInputEnded)
 View all 35 lines...

Script (Inside of Server Script Service)

01function ability(user, move)
02 
03 
04 
05    if move == "Punch" then
06        user.Backpack.Mana.Value =  user.Backpack.Mana.Value - 10
07        print(move.."was used by"..user.Name)
08        local char = user.Character
09 
10 
11        user.Backpack.UsingAbility.Value = true
12        char.RightHand.Touched:Connect(function(hit)
13            if user.Backpack.Hitting.Value == false then
14        print("slap")
15 
16 
17 
18 
19 
20 
21                if hit.Name ~= "Shader" or hit.ClassName ~= "Accessory" then
22 
23                    user.Backpack.Hitting.Value = true
24                    hit.Parent.Humanoid.Health = hit.Parent.Humanoid.Health - 10
25 
26                elseif hit.Name == "Shader" or hit.Name == "Accessory" then
27                        hit.Parent.Parent.Humanoid.Health = hit.Parent.Parent.Humanoid.Health - 10
28                        user.Backpack.Hitting.Value = true
29                end
30 
31 
32 
33            end
34 
35 
36        end)
37        print("Donehitting")
38        wait(0.75)
39        user.Backpack.Hitting.Value = false
40        print("falsed hitting")
41        user.Backpack.UsingAbility.Value = false   
42    end
43 
44 
45end
46game.ReplicatedStorage.Special.OnServerEvent:Connect(ability)
 View all 46 lines...

There is a RemoteEvent named special in Replicated Storage In Starter Pack there are these Values: -Mana (Int) -UsingAbility (Bool) -Hitting (Bool) I also used a cel shader, which is why it has to detect for "Shader" I am a beginner at scripting, so it might be messy, sorry!

Why does it randomly stop allowing you to punch?

Answer this question