Why won't GUI destroy when one value or the other becomes false?

Asked by

5 years ago

Edited 5 years ago

So I have this script that makes it when two values are true meaning that two players are touching two separate blocks (Thanks to SerpentineKing), the function finds the two players hitting the block and adds a GUI into their PlayerGUI. I am now trying to make it so when one of the people aren't touching one of the two blocks anymore, meaning one of the values become false, the GUI is destroyed from both player's PlayerGUI, and then this script will work when both players touch the two blocks again.

01local model = script.Parent
02local connect1 = model:WaitForChild("JoinBlock1")
03local connect2 = model:WaitForChild("JoinBlock2")
04local full1 = connect1:WaitForChild("Full")
05local full2 = connect2:WaitForChild("Full")
06 
07local ss = game:GetService("ServerStorage")
08local start1 = ss:WaitForChild("Start1")
09local start2 = ss:WaitForChild("Start2")
10 
11local player1 = nil
12local player2 = nil
13 
14local function CheckConnection()
15    if player1 and player2 and player1 ~= player2 and full1.Value == true and full2.Value == true then
16        local pgui1 = player1:WaitForChild("PlayerGui")
17        local pgui2 = player2:WaitForChild("PlayerGui")
18 
19        if not pgui1:FindFirstChild("Start1") then
20            local clone1 = start1:Clone()
21            clone1.Parent = pgui1
22        end
23 
24        if not pgui2:FindFirstChild("Start2") then
25            local clone2 = start2:Clone()
26            clone2.Parent = pgui2
27        end
28    end
29end
30 
31local function CheckConnectionEnded()
32    if player1 and player2 and player1 ~= player2 and full1.Value == false or full2.Value == false then
33        local pgui1 = player1:WaitForChild("PlayerGui")
34        local pgui2 = player2:WaitForChild("PlayerGui")
35 
36        if pgui1:FindFirstChild("Start1") then
37          start1:Destroy()
38        end
39 
40        if pgui2:FindFirstChild("Start2") then
41           start2:destroy()
42        end
43    end
44end
45 
46connect1.Touched:Connect(function(hit)
47    player1 = game:GetService("Players"):GetPlayerFromCharacter(hit.parent)
48    CheckConnection()
49end)
50 
51connect2.Touched:Connect(function(hit)
52    player2 = game:GetService("Players"):GetPlayerFromCharacter(hit.parent)
53    CheckConnection()
54end)
55 
56connect1.TouchEnded:Connect(function(ended)
57    player1 = game:GetService("Players"):GetPlayerFromCharacter(ended.parent)
58    CheckConnectionEnded()
59end)
60 
61connect2.TouchEnded:Connect(function(ended)
62    player2 = game:GetService("Players"):GetPlayerFromCharacter(ended.parent)
63    CheckConnectionEnded()
64end)
 View all 64 lines...

Why won't GUI destroy when one value or the other becomes false?

Answer this question