Scripting Helpers is winding down operations and is now read-only. More info→

Not detecting player added?

Asked by

DollorLua 235

5 years ago

I was creating a admin script and I kept having a problem were it wouldn't detect a player being added. I've sent prints through and it works until it checks for the player to be added which is confusing. This has worked for me before but not now.

01local Admin = require(script.DollorsAdmin)
02script.DollorsAdmin.Parent = game.ReplicatedStorage
03 
04local Settings = {
05    Prefix = '?', --The key you want to use before a command EX: ?kill [user]
06    OwnerOnly = false, --If you want only the owner to use commands
07}
08 
09Admin.GetPrefix(Settings.Prefix)
10 
11if Admin.Loaded == true then
12    print('Admin Loaded!')
13else
14    warn('Admin Could not load. Please rejoin the server.')
15end
16 
17local GameOwnerName
18local PlaceId = game.PlaceId
19local PlaceInfo = game:GetService("MarketplaceService"):GetProductInfo(PlaceId)
20 
21if PlaceInfo.Creator.CreatorType == "Group" then
22    GameOwnerName = game:GetService("GroupService"):GetGroupInfoAsync(PlaceInfo.Creator.CreatorTargetId).Owner.Name
23elseif PlaceInfo.Creator.CreatorType == "User" then
24    GameOwnerName = PlaceInfo.Creator.Name
25end
26 
27local AdminIDs = {} --Must be user ID's. Game owner's ID is automatically put here
28 
29local OwnerID = game.Players:GetUserIdFromNameAsync(GameOwnerName)
30 
31table.insert(AdminIDs, #AdminIDs + 1, OwnerID)
32 
33game.Players.PlayerAdded:Connect(function(plr)
34    print(plr.Name)
35    for i, v in pairs(AdminIDs) do
36        if plr.UserId == v then
37            plr.Chatted:Connect(function(msg)
38                if msg:sub(1, 1) == Settings.Prefix then
39                    Admin.SendCommand(msg)
40                end
41            end)
42        end
43    end
44end)
 View all 44 lines...

I don't understand why at the end at line 33 I get no error but it never printed the players name on add...

put a wait() before the function DeceptiveCaster 3761 — 5y

1 answer

Answered by

Ankur_007 290

5 years ago

This probably due to yielding methods like GetGroupAsync and GetUserIdFromNameAsync being present before the Players.PlayerAdded connection. You can either move the whole Players.PlayerAdded connection above the setup part or you could wrap the first part of the script in a coroutine. However, since this information might be pretty important to load before the player, you can use such a structure:

01local setupCompleted = false
02local function Setup() -- Since this hasn't been called yet, it doesn't yield and affect the PlayerAdded:Connection
03   -- Do whatever you need
04    setupCompleted = true
05end
06 
07game.Players.PlayerAdded:Connect(function()
08    if not setupCompleted then
09        Setup()
10        repeat wait() until setupCompleted
11    end
12    -- Now you can be sure that everything is setup
13end)

Thank you for the answer but now that i've seen this I have made a better version of an admin script and noticed that many yeilding functions such as game.ServerScriptService:GetChatService (I totally forgot the actual layout of it) will ruin the player added function, and editting it I check on the go now and not right away so I get the important part completed first. I accept this as an answer. DollorLua 235 — 5y

Not detecting player added?

1 answer

Answer this question