Scripting Helpers is winding down operations and is now read-only. More info→

Can anyone help? Datastore script seems to add a level every time the player leaves and rejoins.

Asked by

Busoshoaku 0

5 years ago

Edited 5 years ago

Yo, so my datastore script seems to have this issue where instead of saving the players level and exp, it for some reason jumps a level or two sometimes?? (for example: the players level would be 1, then once they leave and rejoin it becomes 2?)

Here is the code if anyone wants to know;

01local DSService = game:GetService("DataStoreService"):GetDataStore("-test#1222")
02local RunService = game:GetService("RunService")
03 
04game.Players.PlayerAdded:Connect(function(plr)
05    local uniquekey = 'id-'..plr.userId
06    local leaderstats = Instance.new("Folder", plr)
07    local Level = Instance.new("NumberValue")
08    local EXP = Instance.new("NumberValue")
09    local MaxEXP = Instance.new("NumberValue")
10    local Cash = Instance.new("NumberValue")
11    local FactionEXP = Instance.new("NumberValue")
12 
13        local Strength = Instance.new("NumberValue")
14        local Stamina = Instance.new("NumberValue")
15        local Defence = Instance.new("NumberValue")
16        local Quirk = Instance.new("NumberValue")
17        local Points = Instance.new("NumberValue")
18 
19    local New =  Instance.new("BoolValue")
20 
21    leaderstats.Name = "Data"
22 
23    Level.Parent = leaderstats
24    EXP.Parent = leaderstats
25    MaxEXP.Parent = leaderstats
26    Cash.Parent = leaderstats
27    FactionEXP.Parent = leaderstats
28    New.Parent = leaderstats
29 
30    Strength.Parent = leaderstats
31    Stamina.Parent = leaderstats
32    Defence.Parent = leaderstats
33    Quirk.Parent = leaderstats
34    Points.Parent = leaderstats
35 
36    Level.Name = "Level"
37    EXP.Name = "EXP"
38    MaxEXP.Name = "MaxEXP"
39    Cash.Name = "Cash"
40    FactionEXP.Name = "FactionEXP"
41 
42    Strength.Name = "Strength"
43    Stamina.Name = "Stamina"
44    Defence.Name = "Defence"
45    Quirk.Name = "Quirk"
46    Points.Name = "Points"
47 
48    New.Name = "New"
49 
50    Level.Value = 1
51    EXP.Value = 0
52    MaxEXP.Value = 100
53    Cash.Value = 0
54    FactionEXP.Value = 0
55    New.Value = true
56 
57    Strength.Value = 0
58    Stamina.Value = 0
59    Defence.Value = 0
60    Quirk.Value = 0
61    Points.Value = 0
62 
63 
64    local GetSaved = DSService:GetAsync(uniquekey)
65 
66    if GetSaved then
67        Level.Value = GetSaved[1]
68        EXP.Value = GetSaved[2]
69        Cash.Value = GetSaved[3]
70        FactionEXP.Value = GetSaved[4]
71        New.Value = GetSaved[5]
72 
73            Strength.Value = GetSaved[6]
74            Stamina.Value = GetSaved[7]
75            Defence.Value = GetSaved[8]
76            Quirk.Value = GetSaved[9]
77            EXP.Value = GetSaved[10]
78            Points.Value = GetSaved[11]
79    else
80        local NumberFS = {Level.Value,EXP.Value,Cash.Value,FactionEXP.Value,New.Value,Strength.Value,Defence.Value,Quirk.Value,Stamina.Value,MaxEXP.Value,Points.Value,}
81        DSService:SetAsync(uniquekey,NumberFS)
82    end
83 
84 
85end)
86 
87 
88 
89 
90 
91 
92game.Players.PlayerRemoving:Connect(function(plr)
93    local uniquekey = "id-"..plr.userId
94    local SaveTable = {plr.Data.Level.Value,plr.Data.EXP.Value,plr.Data.Cash.Value,plr.Data.FactionEXP.Value,plr.Data.New.Value,plr.Data.Strength.Value,plr.Data.Defence.Value,plr.Data.Stamina.Value,plr.Data.Quirk.Value,plr.Data.MaxEXP.Value,plr.Data.Points.Value}
95    DSService:SetAsync(uniquekey, SaveTable)
96    print("Number")
97end)~~~~~~~~~~~~~~~~~
 View all 97 lines...

Contact me via discord and I might be able to help you in another way Mystifine#4924 BlackOrange3343 2676 — 5y

1 answer

Answered by

XxWingKing 96

5 years ago

Edited 5 years ago

Heres my datastore:

01local Ds = game:GetService("DataStoreService") -- access datastore
02local abilites = Ds:GetDataStore("PlayerStats_00") -- Datastore key
03 
04function getPlayerData(player) -- load data
05    local success, data = false, nil
06    repeat
07        success = pcall(function()
08            data = abilites:GetAsync(player.UserId)
09        end)
10    until success
11 
12    player.IfData.Value = true
13 
14    return data
15end
16 
17function saveData(player)
18    if player.IfData.Value then
19        local data = {}
20        for i,v in pairs(player.leaderstats:GetChildren()) do
21            table.insert(data, v.Value)
22        end
23        pcall(function()
24            abilites:SetAsync(player.UserId, data)
25        end)
26    end
27end
28 
29function loadStats(player)
30    local leaderstats = Instance.new("Folder",player)
31    leaderstats.Name = "leaderstats"
32 
33    local Credits = Instance.new("IntValue", leaderstats)
34    Credits.Name = "Coins"
35 
36    local Wins = Instance.new("IntValue", leaderstats)
37    Wins.Name = "Wins"
38 
39    local loaded = Instance.new("BoolValue", player)
40    loaded.Name = "IfData" 
41 
42    local savefile = getPlayerData(player)
43    if savefile then
44        Credits.Value = savefile[1]
45        Wins.Value = savefile[1]
46    else
47        Credits.Value = 0
48        Wins.Value = 0
49    end
50end
51 
52game.Players.PlayerAdded:Connect(loadStats) -- When player joins load their stats
53game.Players.PlayerRemoving:Connect(saveData) -- when player leaves save their stats
54 
55-- Auto-Saving (When game is releasing make an setting)
56while wait(30) do
57    for _, player in pairs(game.Players:GetPlayers())do
58        saveData(player)
59    end
60end
 View all 60 lines...

that didnt seem to fix the problem? any other ideas? Busoshoaku 0 — 5y

Maybe I could show you my datastore its kind of similar XxWingKing 96 — 5y

alright, that would be really helpful since i could just edit the values Busoshoaku 0 — 5y

I have edited my answer XxWingKing 96 — 5y

View all comments (3 more)

thanks, im trying it now Busoshoaku 0 — 5y

thank you so much! it seems to work fine, if i could upvote you i would because you've spent alot of time trying to help me make this, so thanks alot. Busoshoaku 0 — 5y

Could you mark me as the answer XxWingKing 96 — 5y

Can anyone help? Datastore script seems to add a level every time the player leaves and rejoins.

1 answer

Answer this question