How do I make my script stop the correct sound?

Asked by

5 years ago

I created a script where when you click, it opens a menu with the songs you can play, and when you click a song it plays it and an animation, and when you click stop it should stop the song and animation. When I run a test server with two players, I have them both play a song. Sometimes when I click stop on one player it will stop the other players song or not stop the song at all. Does anyone know why this is happening?

SERVER SCRIPT:

01unequipt = game.ReplicatedStorage.Unequpit
02stopsong = game.ReplicatedStorage.StopSong                   -------events
03choosesong = game.ReplicatedStorage.ChooseSong
04songstopped = game.ReplicatedStorage.songstopped
05 
06game.Players.PlayerAdded:Connect(function(player)
07    player.CharacterAdded:Connect(function(character)
08        if player.TeamColor == BrickColor.new("Really red") then
09            f = game.ReplicatedStorage["British Fife"]
10            f:Clone().Parent = player.Backpack
11            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton1.Text = "The British Grenadiers"             ----------sets guis
12            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton2.Text = "The Girl I Left Behind Me"
13            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton3.Text = "Lilliburlero"
14            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton4.Text = "Rule Britannia"
15        end
16        if player.TeamColor == BrickColor.new("Really blue") then
17            f = game.ReplicatedStorage["French Fife"]
18            f:Clone().Parent = player.Backpack
19            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton1.Text = "La Grenadier"
20            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton2.Text = "La Charge"
21            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton3.Text = "La Diane"
22            player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton4.Text = "La Pa Cadence"
23        end
24    end)
25end)
26 
27 
28choosesong.OnServerEvent:Connect(function(player,animid,songnumber)
29    song = Instance.new("Sound")
30    if player.TeamColor == BrickColor.new("Really red") then
31        song.Parent = player.Character:FindFirstChild("British Fife").Handle
32    end
33    if player.TeamColor == BrickColor.new("Really blue") then
34        song.Parent = player.Character:FindFirstChild("French Fife").Handle
35    end
36    song.SoundId = "https://www.roblox.com/Asset?ID="..songnumber                                                    -----plays song
37    animation = Instance.new("Animation")
38    animation.AnimationId = "https://www.roblox.com/Asset?ID="..animid
39    trackanimation = game.Workspace[player.Name].Humanoid:LoadAnimation(animation)
40    song:Play()
41    trackanimation:Play()
42    player.Character.Humanoid.WalkSpeed = 8
43    song.Ended:Connect(function()
44        songstopped:FireClient(player)
45        song:Destroy()
46        player.Character.Humanoid.WalkSpeed = 16
47    end)
48end)
49 
50 
51 
52 
53 
54stopsong.OnServerEvent:Connect(function(player)
55    song:Stop()
56    song:Destroy()                     
57    trackanimation:Stop()
58    player.Character.Humanoid.WalkSpeed = 16
59end)
60 
61 
62 
63 
64unequipt.OnServerEvent:Connect(function(player)                                                      ------------when u unequipt
65    song:Stop()
66    song:Destroy()
67    trackanimation:Stop()
68    player.Character.Humanoid.WalkSpeed = 16
69end)
 View all 69 lines...

LOCAL SCRIPT:

01unequipt = game.ReplicatedStorage.Unequpit --remoteevent
02stopsong = game.ReplicatedStorage.StopSong --remoteevent
03choosesong = game.ReplicatedStorage.ChooseSong --remoteevent
04songstopped = game.ReplicatedStorage.songstopped --remoteevent
05 
06player = game.Players.LocalPlayer 
07 
08 
09script.Parent.Equipped:Connect(function(mouse) --equipted
10    mouse.Button1Down:Connect(function()
11        if player.Character:FindFirstChild("British Fife") then
12            if not player.PlayerGui:WaitForChild("ScreenGui").Stop.Visible and not player.PlayerGui:WaitForChild("ScreenGui").Frame.Visible then
13                player.PlayerGui.ScreenGui.Frame.Visible = true
14            end
15        end
16    end)
17end)
18 
19 
20 
21script.Parent.Unequipped:Connect(function() --unequipted
22    unequipt:FireServer()
23    player.PlayerGui:WaitForChild("ScreenGui").Frame.Visible = false
24    player.PlayerGui:WaitForChild("ScreenGui").Stop.Visible = false
25end)
26 
27 
28 
29player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton1.MouseButton1Click:Connect(function()
30    choosesong:FireServer(4054455538,4009405494)
31    player.PlayerGui.ScreenGui.Frame.Visible = false
32    player.PlayerGui.ScreenGui.Stop.Visible = true
33end)
34player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton2.MouseButton1Click:Connect(function()
35    choosesong:FireServer(04116459147,4115819618)
36    player.PlayerGui.ScreenGui.Frame.Visible = false
37    player.PlayerGui.ScreenGui.Stop.Visible = true                                                      -----------songs
38end)
39player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton3.MouseButton1Click:Connect(function()
40    choosesong:FireServer(04116482197,4115832422)
41    player.PlayerGui.ScreenGui.Frame.Visible = false
42    player.PlayerGui.ScreenGui.Stop.Visible = true
43end)
44player.PlayerGui:WaitForChild("ScreenGui").Frame.TextButton4.MouseButton1Click:Connect(function()
45    choosesong:FireServer(04116506453,4115835480)
46    player.PlayerGui.ScreenGui.Frame.Visible = false
47    player.PlayerGui.ScreenGui.Stop.Visible = true
48end)
49 
50 
51script.Parent.Unequipped:Connect(function()                                                             -----------unequipt
52    stopsong:FireServer()
53end)            
54 
55 
56player.PlayerGui:WaitForChild("ScreenGui").Stop.TextButton.MouseButton1Click:Connect(function()         ------------stop song
57    stopsong:FireServer()
58    player.PlayerGui:WaitForChild("ScreenGui").Frame.Visible = true
59    player.PlayerGui:WaitForChild("ScreenGui").Stop.Visible = false
60end)
61 
62 
63 
64songstopped.OnClientEvent:Connect(function()                                            -------------------------------------when song is stopped
65    player.PlayerGui:WaitForChild("ScreenGui").Stop.Visible = false
66    player.PlayerGui:WaitForChild("ScreenGui").Frame.Visible = true
67end)
 View all 67 lines...

How do I make my script stop the correct sound?

Answer this question