I'm trying to make frames Visible and Not Visible. Does anyone know why this is breaking?

Asked by

SethHeinzman 284

5 years ago

Edited 5 years ago

So I have a StarterGui named Menu consisting of multiple frames and one TextButton :

Abilities, Inventory, Players, TabFrame, TravelFrame, TextButton.

Inside TabFrame: - UIListLayout set to Horizontal Layout - 4 Buttons Named: AbilitiesTab, PlayersTab, InventoryTab, TravelTab - LocalScript that contains the code at the end of this question.

The other frames inside the starterGui Menu contain nothing and are just frames with exactly the same positioning and size.

Tab Frame allows the user to click on one of the tabs, and switch to the inventory frame, abilities frame, travel frame, or players frame.

Tab Frame will always be visible but the other frames switch between what is selected.

So If I were to click the TravelTab it would switch from the starting Frame "Inventory" to the Travel Frame and make Inventory.Visible = false and TravelFrame.Visible = true.

Yes I probably should make them all Have frame at the end or not at all lol.

However for some reason the frames do not change in visibility. The buttons work correctly and change background color, text color exactly the way they should. But when trying to make the frames visible or not visible, something breaks in the code.

Here is the code! Thank you!

01local TravelFrame = game.StarterGui.Menu.TravelFrame
02local Inventory = game.StarterGui.Menu.Inventory
03local Abilities = game.StarterGui.Menu.Abilities
04local Players = game.StarterGui.Menu.Players
05local TravelTabButton = script.Parent.TravelTab
06local InventoryButton = script.Parent.InventoryTab
07local AbilitiesButton = script.Parent.AbilitiesTab
08local PlayersButton = script.Parent.PlayersTab
09local ActiveTab = Instance.new("Frame")
10local ActiveTabButton = Instance.new("TextButton")
11 
12ActiveTabButton = InventoryButton
13ActiveTab = Inventory
14 
15script.Parent.TravelTab.MouseButton1Click:connect(function()
16  -- Sets The last active tab to default non active color (White)
17  ActiveTabButton.BackgroundColor3 = Color3.new(255, 255, 255)
18  ActiveTabButton.TextColor3 = Color3.new(0 , 0, 0)
19  -- Once last active tab colors are set, Sets ActiveTabButton to new active Tab and sets colors to black (Active)
20  ActiveTabButton = TravelTabButton
21  ActiveTabButton.BackgroundColor3 = Color3.new(0, 0, 0)
22  ActiveTabButton.TextColor3 = Color3.new(255, 255, 255)
23 
24  -- Sets Last Active Page/Frame to invisible and switches ActiveTab to new active page.
25  ActiveTab.Visible = false
26  ActiveTab = TravelFrame
27  ActiveTab.Visible = true
28end)
29 
30script.Parent.InventoryTab.MouseButton1Click:connect(function()
31  -- Sets The last active tab to default non active color (White)
32  ActiveTabButton.BackgroundColor3 = Color3.new(255, 255, 255)
33  ActiveTabButton.TextColor3 = Color3.new(0 , 0, 0)
34  -- Once last active tab colors are set, Sets ActiveTabButton to new active Tab and sets colors to black (Active)
35  ActiveTabButton = InventoryButton
36  ActiveTabButton.BackgroundColor3 = Color3.new(0, 0, 0)
37  ActiveTabButton.TextColor3 = Color3.new(255, 255, 255)
38 
39  -- Sets Last Active Tab to invisible and switches ActiveTab to new active page.
40  ActiveTab.Visible = false
41  ActiveTab = Inventory
42  ActiveTab.Visible = true
43end)
44 
45script.Parent.PlayersTab.MouseButton1Click:connect(function()
46  -- Sets The last active tab to default non active color (White)
47  ActiveTabButton.BackgroundColor3 = Color3.new(255, 255, 255)
48  ActiveTabButton.TextColor3 = Color3.new(0 , 0, 0)
49  -- Once last active tab colors are set, Sets ActiveTabButton to new active Tab and sets colors to black (Active)
50  ActiveTabButton = PlayersButton
51  ActiveTabButton.BackgroundColor3 = Color3.new(0, 0, 0)
52  ActiveTabButton.TextColor3 = Color3.new(255, 255, 255)
53 
54  -- Sets Last Active Tab to invisible and switches ActiveTab to new active page.
55  ActiveTab.Visible = false
56  ActiveTab = Inventory
57  ActiveTab.Visible = true
58end)
59 
60script.Parent.AbilitiesTab.MouseButton1Click:connect(function()
61  -- Sets The last active tab to default non active color (White)
62  ActiveTabButton.BackgroundColor3 = Color3.new(255, 255, 255)
63  ActiveTabButton.TextColor3 = Color3.new(0 , 0, 0)
64  -- Once last active tab colors are set, Sets ActiveTabButton to new active Tab and sets colors to black (Active)
65  ActiveTabButton = AbilitiesButton
66  ActiveTabButton.BackgroundColor3 = Color3.new(0, 0, 0)
67  ActiveTabButton.TextColor3 = Color3.new(255, 255, 255)
68 
69  -- Sets Last Active Tab to invisible and switches ActiveTab to new active page.
70  ActiveTab.Visible = false
71  ActiveTab = Inventory
72  ActiveTab.Visible = true
73end)
 View all 73 lines...

I also tried to just open a frame without the complex code and with a simple TextButton. I put the local script in the textbutton and

1script.Parent.MouseButton1Click:connect(function()
2    -- Just an example. This did not work either.
3    someFrame.Visible = true
4    textButton.Visible = false
5end)

I am given no errror. The frames just aren't changing from visible to not visible. SethHeinzman 284 — 5y

lol replace game.StarterGui to player.PlayerGui WillBe_Stoped 71 — 5y

maybe replace every color3.new() with color3.fromRGB(), (e.g Color3.fromRGB(50,30,10) would be Color3.new(50/255,30/255,10/255), maybe change it because it wont change the color) Kriscross102 118 — 5y

LOL thank you. I can't believe I forgot about that. SethHeinzman 284 — 5y

I'm trying to make frames Visible and Not Visible. Does anyone know why this is breaking?

1 answer

Answer this question