Why does my script give a "stack overflow" error?
01 | local RemoteEvent = script.Parent:WaitForChild("RemoteEvent") |
02 | local Mouse = game.Players.LocalPlayer:GetMouse() |
03 | local Tool = script.Parent |
04 | local IsActivated |
05 |
06 | local function OnActivated () |
07 | local Target = Mouse.Target |
08 | if Target then |
09 | local Durability = Target:FindFirstChild("Durability") |
10 | if Durability then |
11 | IsActivated = true |
12 | while IsActivated == true and Target.Parent ~= nil and Durability.Value > 0 do |
13 | wait(0.1) |
14 | Durability.Value = Durability.Value - 1 |
15 | end |
I don't know why this happen's but i'm pretty sure its because of the OnActivated() but im not sure, it should only run twice but it repeats a lot.
Concept : When everything goes right, it makes it so that the function would run again.
Specific : When everything goes as it is expected (IsActivated == true and Target.Parent ~= nil and Durability.Value == 0) then it would "run" the function over again.
0
0
2 answers
In OnActivated, you use recursion, which either never ends or repeats a lot. Since Roblox disabled tail call optimizations, you should consider using a loop instead of using recursion.
In your case, it seems like you're using recursion simply to repeat code with no new arguments passed. In this case, you'd just need a loop in the function like
1 | local function OnActivated () |
2 | while IsActivated do |
3 | --code in OnActivated |
4 | end |
5 | end |
Note: If you want to take advantage of tail call optimizations in Lua, return the return value of the function, eg:
1 | local function foo() |
2 | return foo() |
3 | end |
You accidently fit a if statement that defines a function that the if statements defines You are making a loop of that function since its inside it.
01 | local RemoteEvent = script.Parent:WaitForChild("RemoteEvent") |
02 | local Mouse = game.Players.LocalPlayer:GetMouse() |
03 | local Tool = script.Parent |
04 |
05 | local IsActivated = false |
06 |
07 | local function OnActivated () |
08 |
09 | local Target = Mouse.Target |
10 |
11 | if Target then |
12 |
13 | local Durability = Target:FindFirstChild("Durability") |
14 |
15 | if Durability then |
You also set IsActivated to nothing, you declared the variable, but with no value. Which is an error universally for all programming languages. (Except for HTML or CSS, they aint programming languages)