I've got an error I just can't seem to squash, can anyone help me out?
01 | this = script.Parent |
02 |
03 | function fademodel(part, modelname) |
04 | if part ~= nil then |
05 | model = game.Lighting.Models:findFirstChild(modelname) |
06 | modelchildren = model:GetChildren() |
07 | tempmodel = Instance.new("Model") |
08 | tempmodel.Name = model.Name |
09 | tempmodel.Parent = game.workspace.FadeModelTest.Models |
10 | for i, v in ipairs(modelchildren) do |
11 |
12 | local t = v:clone() |
13 | local temp = v.CFrame |
14 | t.Parent = tempmodel |
15 | t.CFrame = temp |
This is my script. I'm trying to make a part that, when you touch it, it will bring a model out from the lighting but in a more light on resources kind of way. The issue is, that this line: this.Touched:connect(fademodel(part)) is throwing the error: Attempt to connect failed: Passed value is not a function
I've got a feeling it's just some dumb typo that I can't seem to find, but it might be something else. Any help would be appreciated.
1 answer
Touched events have one built in parameter. It is built in, so you do not have to define it with an argument. This parameter is hit or part, which is automatically equal to the part that hit the brick. Don't try adding other parameters, as it probably won't work right. You should also check if the part that touched the brick is truly a player. For this we can use the GetPlayerFromCharacter() method.
Also, you're basically creating a clone of the model you put in Lighting, and putting it in workspace. But why would you do it the way you're doing it, instead of just using the Clone()method? So,
01 | this = script.Parent |
02 | modelname = "modenamehere" |
03 |
04 | function fademodel(part) |
05 | if game.Players:GetPlayerFromCharacter(part.Parent) then |
06 | local clone = game.Lighting[modelname]:Clone() |
07 | clone.Parent = game.Workspace.FadeModelTest.Models |
08 | end |
09 | end |
10 |
11 | print("here") |
12 | this.Touched:connect(fademodel) |
Hope i helped!
0