Scripting Helpers is winding down operations and is now read-only. More info→

Script works fine on studio play mode, but breaks partially when in-game?

Asked by

arthurdaniel91 72

5 years ago

I am making a tower defense style game, and I made a minigunner tower for testing. But I am having a big problem.

On studio play mode, the tower's script works perfectly fine. But when in-game or on studio test mode, it breaks partially and the shoot() function doesn't fire for some reason.

Script:

01--//Services
02local players = game:GetService("Players")
03local debris = game:GetService("Debris")
04 
05--//Variables
06local tower = script.Parent.Parent
07 
08local towerHumanoidRootPart = tower:WaitForChild("HumanoidRootPart")
09local humanoid = tower:WaitForChild("Humanoid")
10local minigun = tower:WaitForChild("Minigun")
11 
12local storage = tower:WaitForChild("Storage")
13 
14local animations = storage:WaitForChild("Animations")
15local idleAnimation = animations:WaitForChild("Idle")
16 
17local soundEffects = storage:WaitForChild("SoundEffects")
18local gunshotSFX = soundEffects:WaitForChild("GunshotSFX")
19 
20local statistics = require(storage:WaitForChild("TowerStatistics"))
21local range = statistics["Range"]
22local fireRate = statistics["FireRate"]
23local damage = statistics["Damage"]
24 
25--//Functions
26local function generateRangeMarker()
27    local rangeMarker = Instance.new("Part")
28    rangeMarker.Anchored = true
29    rangeMarker.CanCollide = false
30    rangeMarker.CFrame = towerHumanoidRootPart.CFrame *CFrame.new(0, -1.75, 0) *CFrame.Angles(0, 0, math.rad(90))
31    rangeMarker.Size = Vector3.new(.1, range * 2, range * 2)
32    rangeMarker.BrickColor = BrickColor.new("Deep blue")
33    rangeMarker.Transparency = .5
34 
35    local rangeMarkerMesh = Instance.new("SpecialMesh", rangeMarker)
36    rangeMarkerMesh.MeshType = Enum.MeshType.Cylinder
37 
38    rangeMarker.Parent = tower
39end
40 
41local function startAnimation()
42    wait()
43    humanoid:LoadAnimation(idleAnimation):Play()
44end
45 
46local function shoot() --//The function that breaks when in-game.
47    while wait(fireRate) do
48        local playerList = players:GetPlayers()
49 
50        for i = 1, #playerList do
51            local target = workspace:FindFirstChild(playerList[i].Name)
52            if not target then return end
53 
54            local targetHumanoid = target:FindFirstChild("Humanoid")
55            if not targetHumanoid then return end
56 
57            local targetHumanoidRootPart = target:FindFirstChild("HumanoidRootPart")
58            if not targetHumanoidRootPart then return end
59 
60            local magnitude = (towerHumanoidRootPart.CFrame.p - targetHumanoidRootPart.CFrame.p).magnitude
61 
62            if magnitude < range then
63                towerHumanoidRootPart.CFrame = CFrame.new(towerHumanoidRootPart.CFrame.p, targetHumanoidRootPart.CFrame.p)
64                towerHumanoidRootPart.Orientation = Vector3.new(0, towerHumanoidRootPart.Orientation.Y, towerHumanoidRootPart.Orientation.Z)
65 
66                targetHumanoid:TakeDamage(damage)
67 
68                local newGunshotSFX = Instance.new("Sound")
69                newGunshotSFX.Name = "ClonedGunshotSFX"
70                newGunshotSFX.SoundId = gunshotSFX.SoundId
71 
72                newGunshotSFX.Parent = minigun
73                newGunshotSFX:Play()
74 
75                debris:AddItem(newGunshotSFX, 1)
76            end
77        end
78    end
79end
80 
81--//Callers
82generateRangeMarker()
83startAnimation()
84shoot() --//The caller for the shoot() function.
 View all 84 lines...

This is the 3rd/4th time I am asking this, I didn't get a answer on the other times I asked this same question.

im not gonna get fully in to this but maybe one thing that u can change and probably should change too is when u got magnitude checks, dont check using CFrame, check using HumanoidRootPart.Position Gameplayer365247v2 1055 — 5y

1 answer

Answered by

sleazel 1287

5 years ago

This lines:

`1`	`if` `not` `target` `then` `return` `end`

`2`	`if` `not` `targetHumanoid` `then` `return` `end`

are ending your function completely rather than restarting the loop. You can either replace return with break that will break the for loop, or nest your code few more times, like this:

01for i = 1, #playerList do
02 
03    local target = workspace:FindFirstChild(playerList[i].Name)
04    if target then
05 
06        local targetHumanoid = target:FindFirstChild("Humanoid")
07        if targetHumanoid then
08 
09            local targetHumanoidRootPart = target:FindFirstChild("HumanoidRootPart")
10            if targetHumanoidRootPart then
11 
12                local magnitude = (towerHumanoidRootPart.CFrame.p - targetHumanoidRootPart.CFrame.p).magnitude
13 
14                if magnitude < range then
15 
16                    towerHumanoidRootPart.CFrame = CFrame.new(towerHumanoidRootPart.CFrame.p, targetHumanoidRootPart.CFrame.p)
17                    towerHumanoidRootPart.Orientation = Vector3.new(0, towerHumanoidRootPart.Orientation.Y, towerHumanoidRootPart.Orientation.Z)
18                    targetHumanoid:TakeDamage(damage)
19 
20                    -- TIP :this code below should be outside while loop as it needs to run just once
21                    local newGunshotSFX = Instance.new("Sound")
22                    newGunshotSFX.Name = "ClonedGunshotSFX"
23                    newGunshotSFX.SoundId = gunshotSFX.SoundId
24 
25                    newGunshotSFX.Parent = minigun
26                    --end of just once code
27                    newGunshotSFX:Play()
28 
29                    debris:AddItem(newGunshotSFX, 1) --not needed when you use my tip
30                end
31            end
32        end
33    end
34end
 View all 34 lines...

Living legend. Thanks alot man! I was having this issue for a very long time and I am glad to have finally fixed it. Cheers! arthurdaniel91 72 — 5y

Script works fine on studio play mode, but breaks partially when in-game?

1 answer

Answer this question