Scripting Helpers is winding down operations and is now read-only. More info→

How can I fix this leaderstats script?

Asked by

ultrabug 306

11 years ago

Basically I am trying to make a leaderboard, but here is what I have for it, the problem is it will not show up onto the leaderboard.

01local ds=game:GetService("DataStoreService"):GetDataStore("Stats")
02game.Players.PlayerAdded:connect(function(np)
03    local ls=Instance.new("BoolValue")
04    ls.Name="leaderstats"
05    local level=Instance.new("NumberValue")
06    level.Name="Level"
07    local xp=Instance.new("NumberValue")
08    xp.Name="XP"
09    xp.Parent=ls
10    local kills=Instance.new("NumberValue")
11    kills.Name="Kills"
12    kills.Parent=ls
13    level.Parent=ls
14    ls.Parent=np
15    kills.Value=0
16    level.Value=0
17    xp.Value=0
18    dsl=ds:GetAsync(tostring(np.userid).."Level")
19    if dsl==nil then
20        ds:SetAsync(tostring(np.userid).."Level", 0)
21    else
22        level.Value=ds:GetAsync(tostring(np.Userid).."Level")
23    end
24    dsxp=ds:GetAsync(tostring(np.userid).."XP")
25    if dsxp==nil then
26        ds:SetAsync(tostring(np.userid).."XP", 0)
27    else
28        xp.Value=ds:GetAsync(tostring(userid).."XP")
29    end
30end)
31game.Players.PlayerRemoving:connect(function(lp)
32    level=lp.leaderstats.Level
33    ds:SetAsync(tostring(lp.userid).."Level", level.Value)
34    ds:SetAsync(tostring(lp.userid).."XP", xp.Value)
35end)
36game.Players.PlayerAdded:connect(function(player)
37    player.CharacterAdded:connect(function(character)
38        local humanoid=character:WaitForChild("Humanoid")
39        humanoid.Died:connect(function()
40            local value=humanoid:FindFirstChild("creator")
41                local kp=value.Value
42                if kp~=nil then
43                    kp.leaderstats.Kills.Value=kp.leaderstats.Kills.Value +1
44                    kp.leaderstats.XP.Value=kp.leaderstats.XP.Value + 10
45                    local xpn=kp.leaderstats.Level.Value * 100
46                    if kp.leaderstats.XP.Value >= xpn then
47                        kp.leaderstats.Level.Value=kp.leaderstats.Level.Value +1
48                        ds:SetAsync(tostring(kp.userid).."Level", kp.leaderstats.Level.Value)
49                        ds:SetAsync(tostring(kp.userid).."XP", kp.leaderstats.XP.Value)
50                end
51            end
52        end)
53    end)
54end)
 View all 54 lines...

Thank you in advance.

What is the problem with it? User#2 0 — 11y

It will not show up onto the leaderboard. ultrabug 306 — 11y

1 answer

Answered by

User#2 0

11 years ago

Not everything the humanoid when they die will be a creator value, so you should've kept the code inside the died event the same (unless you found another error inside of it).

That is all I noticed, if I find anything else I'll edit my answer.

So I should reset the values when they join the game automatically to 0? ultrabug 306 — 11y

Yes User#2 0 — 11y

Okay I will see if this will work, thank you. ultrabug 306 — 11y

Nope I found it, when I name the xp value I forgot to put it in a string. ultrabug 306 — 11y

View all comments (13 more)

Ahh, I skipped over that. Still, though, the values probably default to 0. User#2 0 — 11y

I think so, any ways I tested it again, the board showed up, and then when I killed him it didn't count it onto the board, I think it may be the gun but it named the tag value the same thing. Any ideas? ultrabug 306 — 11y

I think the event is "Died" instead of "Dead" (of the Humanoid) User#2 0 — 11y

TY, that is it! ultrabug 306 — 11y

Nope, it is still not working. ultrabug 306 — 11y

Im going to repost what the script has now. ultrabug 306 — 11y

I edited my question with the new script. ultrabug 306 — 11y

I also edited my answer. User#2 0 — 11y

Okay and I start changing this up again. ultrabug 306 — 11y

level is parented to leaderstats right after kills. ultrabug 306 — 11y

Ahh, I couldn't find it. But the Died part still applies I assume User#2 0 — 11y

Probably, I saw the other way I had it with the loop in someone elses answer for finding the tag, so I figured I might aswell give it a shot. ultrabug 306 — 11y

I got the kills, xp, and level to work, but it only shows up for 1 person(the 1st person to join), the others don't even have 0s in their spots. ultrabug 306 — 11y

How can I fix this leaderstats script?

1 answer

Answer this question