My Dart Gun Script has server-client communication issues. How can I fix this?

Asked by

5 years ago

I am currently building a Nerf Gun FPS. I am currently struggling with communication between server and client. My goal is to spawn a dart using a server script and remote functions. Script is below:

01--Main Script which goes in Server Storage --
02 
03 
04local serverStorage = game:GetService("ServerStorage")
05local replicatedStorage = game:GetService("ReplicatedStorage")
06local KOValue = "Kills"
07local WOValue = "Wipeouts"
08local damage = 30
09replicatedStorage.ShootEvent.OnServerEvent:Connect(function(player,tool,position,part)
10    if game.Workspace[player.Name].Humanoid.Health <= 0 then
11        -- The player is dead, do not do anything
12    else
13 
14-- Create a clone of Dart and set its color
15local Dart = 
16        local dartClone = Dart:Clone()
17        --game.Debris:AddItem(dartClone, 30)
18        dartClone.BrickColor = player.TeamColor
19        dartClone.Touched:connect(function(hit)
20            if hit and hit.Parent and hit.Parent ~= player.Character and hit.Parent ~= tool then
21                dartClone:Destroy()
22            end
23        end)
24 
25        spawn(function()
26            wait(30)
27            if dartClone then dartClone:Destroy() end
28        end)        
29 
30        -- Position the dart clone and launch!
31        local spawnPosition = (tool.Handle.CFrame * CFrame.new(2, 0, 0)).p
32        dartClone.CFrame = CFrame.new(spawnPosition, target) --NOTE: This must be done before assigning Parent
33        dartClone.Velocity = dartClone.CFrame.lookVector * dartspeed --NOTE: This should be done before assigning Parent
34        dartClone.Parent = game.Workspace       
35 
36        -- Attach creator tags to the dart early on
37        local creatorTag = Instance.new('ObjectValue', dartClone)
38        creatorTag.Value = player
39        creatorTag.Name = 'creator' --NOTE: Must be called 'creator' for website stats
40        local iconTag = Instance.new('StringValue', creatorTag)
41        iconTag.Value = tool.TextureId
42        iconTag.Name = 'icon'
43 
44 
45        delay(delay, function()
46        end)
47 
48 
49        if part then
50            if part.Name == "Head" or part:IsA("Hat") and part.Parent:FindFirstChild("Humanoid").Health > 0 then
51                -- Boom headshot
52                replicatedStorage.Headshot:FireClient(player)
53                damage = 1000
54                return "Headshot!"
55            end
56            local humanoid = part.Parent:FindFirstChild("Humanoid")
57            if not humanoid then
58                humanoid = part.Parent.Parent:FindFirstChild("Humanoid")
59            else
60                humanoid:TakeDamage(damage)
61                if humanoid.Health <= 0 then
62                    player.leaderstats[KOValue].Value = player.leaderstats[KOValue].Value + 1
63                    game.Players[humanoid.Parent.Name].leaderstats[WOValue].Value = game.Players[humanoid.Parent.Name].leaderstats[WOValue].Value + 1
64                end    
65            end
66            wait(30)
67            if dartClone then
68                dartClone:Destroy()
69            end
70        end
71    end
72end)
73 
74replicatedStorage.EquipAnimation.OnServerEvent:Connect(function(player,animation)
75    local newAnim = game.Workspace[player.Name].Humanoid:LoadAnimation(animation)
76    newAnim:Play()
77    replicatedStorage.UnequipAnimation.OnServerEvent:Connect(function(player,animation)
78        newAnim:Stop()
79        for i,v in pairs(game.Workspace:GetChildren()) do
80            if v.Name == player.Name.."'s Trajectory" then
81                v:Destroy()
82            end
83        end
84    end)
85    replicatedStorage.Reload.OnServerEvent:Connect(function(player,animation)
86        newAnim:Stop()
87        local reloadAnim = game.Workspace[player.Name].Humanoid:LoadAnimation(animation)
88        reloadAnim:Play()
89    end)
90end)
 View all 90 lines...

Local Script Below:

001--Constraints
002local IgnoreList = {rocket = 0, handle = 1, effect = 1, water = 1} -- Rocket will fly through things named these
003--NOTE: Keys must be lowercase, values must evaluate to true
004--Variables
005local tool = script.Parent
006 
007local player = game.GetService("Players").LocalPlayer
008 
009local mouse = player:GetMouse()
010 
011 
012local gungui = tool:WaitForChild("GunGUI" )
013local firesound = tool.WaitForChild("FireSound")
014local reloadsound = tool.WaitForChild("ReloadSound")
015local primesound = tool.WaitForChild("PrimeSound")
016local primedelay = tool.Configurations:WaitForChild("PrimeDelay")
017local damage = tool.Configurations:WaitForChild("Damage")
018local range = tool.Configurations:WaitForChild("Range")
019local dartspeed = tool.Configurations:WaitForChild("DartSpeed") -- Speed of the projectile
020local reloadtime = tool.Configurations:WaitForChild("ReloadTime") -- Seconds until tool can be used again
021local primingtime = tool.Configurations:WaitForChild("PrimeTime") --seconds until tool can be used again
022 
023local torso = nil
024 
025local reloading = false --reloading check
026 
027local priming = false -- priming check
028 
029local capacity = tool:WaitForChild("Capacity")
030 
031local CreatorTag = Dart:WaitForChild('creator', 60)
032 
033local gravityacceleration = 196.2
034 
035local dartmeshid = 'rbxassetid://2906043627'
036 
037local meshscale = Vector3.new(0.17,0.17,.25)
038 
039local dartpartscale = Vector3.new(1, 1, 1)
040 
041local dartcolor = BrickColor.new(33, 60, 122)
042 
043local dartscript = script:WaitForChild('Dart')
044 
045--local contextActionService = game:GetService("ContextActionService") 
046--caters to mobile gamers (A Later Update)
047 
048local bodytype = nil
049 
050local difference = 0 -- dif between head and mouse
051 
052local replicatedstorage = game.GetService("ReplicatedStorag")
053 
054local gungui = tool:WaitForChild("GunGUI")
055 
056--remote events
057local equipAnimation = replicatedstorage:WaitForChild("EquipAnimation")
058 
059local unequipanimation = replicatedstorage:WaitForChild("UnequipAnimation")
060 
061local primeAnimation = replicatedstorage:WaitForChild("PrimeAnimation")
062 
063local shootevent = replicatedstorage:WaitForChild("ShootEvent")
064 
065local prime = replicatedstorage:WaitForChild("Prime")
066 
067local reload = replicatedstorage:WaitForChild("Reload")
068 
069local headshot = replicatedstorage:WaitForChild("Headshot")
070--remote functions
071local checkBodyType = replicatedstorage:WaitForChild("CheckBodyType")
072 
073local fetchRemainingAmmo = replicatedstorage:WaitForChild("FetchRemainingAmmo")
074--bodytype
075function findBodyType()
076    bodytype = checkBodyType:InvokeServe(tool)
077    print(bodytype) 
078end
079 
080 
081--When tool is equipped this script will run
082local function OnTouched(otherPart)
083    if Dart and otherPart then
084        -- Fly through anything in the ignore list
085        if IgnoreList[string.lower(otherPart.Name)] then
086            return
087        end
088 
089 
090tool.Equipped:Connect(function(mouse)
091    gungui:Clone().Parent = player.PlayerGui -- cloning gui into player on equip
092    findBodyType() -- not used
093    equipAnimation:FireServer(tool.shoot) -- calling remote event to add to server equip animation
094    mouse.Icon = ""
095    --shoot function
096    mouse.Button1Down:Connect(function()
097        if Capacity <=0 or reloading == true or priming == true or cooldown == true then
098            --do nothing 
099        else
100            local head = game.Workspace [player.Name].Head.CFrame.lookVector
101            local mouse = CFrame.new(game.Workspace[player.Name].Head.Position,mouse.Hit.p).lookVector 
102            difference = (head-mouse)
103            local
104            --DartHERE-----------------
105 
106local function OnActivated()
107    local myModel = player.Character
108    if Tool.Enabled and myModel and myModel:FindFirstChild('Humanoid') and myModel.Humanoid.Health > 0 then
109        Tool.Enabled = false
110        game.ReplicatedStorage.ROBLOX_RocketFireEvent:FireServer(mouse.Hit.p)
111        wait(2)
112 
113        Tool.Enabled = true
114                if humanoid and humanoid.Health > 0 then -- Humanoids are tagged and damaged
115            if hitPart.Name == 'Torso' then
116                ApplyTags(humanoid)
117                humanoid:TakeDamage(100)
118            end
119 
120            end
121        end
122    end
123local function OnTouched(otherPart)
124    if Dart and otherPart then
125        -- Fly through anything in the ignore list
126        if IgnoreList[string.lower(otherPart.Name)] then
127            return
128        end
129 
130        local myPlayer = CreatorTag.Value
131        if myPlayer then
132            -- Fly through the creator
133            if myPlayer.Character and myPlayer.Character:IsAncestorOf(otherPart) then
134                return
135            end
136 
137             -- Fly through friendlies
138            if not myPlayer.Neutral then
139                local character = FindCharacterAncestor(otherPart.Parent)
140                local player = PlayersService:GetPlayerFromCharacter(character)
141                if player and player ~= myPlayer and player.TeamColor == Dart.BrickColor then
142                    return
143                end
144            end
145        end
146 
147        -- Fly through terrain water
148        if otherPart == game.Workspace.Terrain then
149            --NOTE: If the Dart is large, then the simplifications made here will cause it to fly through terrain in some cases
150            local frontOfRocket = Dart.Position + (Dart.CFrame.lookVector * (Dart.Size.Z / 2))
151            local cellLocation = game.Workspace.Terrain:WorldToCellPreferSolid(frontOfRocket)
152            local cellMaterial = game.Workspace.Terrain:GetCell(cellLocation.X, cellLocation.Y, cellLocation.Z)
153            if cellMaterial == Enum.CellMaterial.Water or cellMaterial == Enum.CellMaterial.Empty then
154                return
155            end
156        end
157 
158        -- Connect custom logic for the explosion
159        explosion.Hit:connect(function(hitPart, hitDistance) OnExplosionHit(hitPart, hitDistance, explosion.Position) end)
160 
161        -- Move this script and the creator tag (so our custom logic can execute), then destroy the Dart
162        CreatorTag.Parent = script
163        Dart:Destroy()
164    end
165end
166 
167 
168Dart.Touched:connect(OnTouched)
169            if difference.magnitude < 1.33 then
170                shootevent:FireServer(tool,position,part)
171                Capacity.Value = Capacity.Value - 1
 View all 171 lines...

Server scripts should go into ServerScriptService, and the remote events inside of ReplicatedStorage. Nowaha 459 — 5y

Please specify your issue and where the issue is in your code. Honestly, nobody feels like trying to understand over 200 lines of another person's unknown code without understanding what the issue even is exactly. Nowaha 459 — 5y

I didn't think so ExHydraboy 30 — 5y

My problem is this. I had an original script that simply fired the dart. I used a few YT vids to make it create remote functions on tool equip but It didn't do much else. Recently I have tried to rewrite the script and add some animations and a HUD, but the original script is confusing me. ExHydraboy 30 — 5y

Originally I had a local script that I copied from somewhere that made the tool mobile compatible, and the setup was a Script inside of a Local script with no server scripts. I've never been good with scripting tools, but online it said to use Remote Functions and Server scripts. In the server script on lines 14 - 47 I have the main dart mesh. I'm confused on where to put it. ExHydraboy 30 — 5y

My Dart Gun Script has server-client communication issues. How can I fix this?

Answer this question