Scripting Helpers is winding down operations and is now read-only. More info→

Why does this script give everyone the resource instead of just one person?

Asked by

5 years ago

So i'm trying to make a basic ore collection. The collection works by a pickaxe hitting a rock. If the rock name corresponds to the script, give them that ore.

That all works fine... However, my scripts seems to give the resource to all players rather than just one...

Any ideas?

001game.ReplicatedStorage.Oof.OnServerEvent:Connect(function(player)
002local playersname = player.Name
003local FolderName = game.ServerScriptService:FindFirstChild(playersname)
004if FolderName then
005 
006  if script.Parent.InUse.Value == false then
007    script.Parent.InUse.Value = true
008    local kickAnimation = Instance.new("Animation")
009    kickAnimation.AnimationId = "rbxassetid://704173649"
010    local kickAnimationTrack = player.Character.Humanoid:LoadAnimation(kickAnimation)
011    kickAnimationTrack:Play()
012    wait(1.5)
013    script.Parent.InUse.Value = false
014 
015 
016 
017  else
018    print("Nope")
019  end
020end
021 
022local function Kill (hit)
023 
024 
025  if hit.Parent.Name == "Rock" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
026    script.Parent.Debounce.Value = true
027    FolderName.Stone.Value = FolderName.Stone.Value + 1
028    player.PlayerGui.Inventory.Main.Frame.Items.Stone.TextButton.Text = "Stone: ".. FolderName.Stone.Value
029    A = game.ServerScriptService.Notify
030    B = A:Clone()
031    B.Value.Value = "Rock + 1"
032    B.Parent = player.PlayerGui
033    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
034    print(playersname)
035    B.Disabled = false
036    wait(1.5)
037    B:Destroy()
038    script.Parent.Debounce.Value = false
039    print(script.Parent.Debounce.Value)
040  end
041 
042  if hit.Parent.Name == "Copper" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
043    script.Parent.Debounce.Value = true
044    FolderName.Copper.Value = FolderName.Copper.Value + 1
045    player.PlayerGui.Inventory.Main.Frame.Items.Copper.TextButton.Text = "Copper: ".. FolderName.Copper.Value
046    A = game.ServerScriptService.Notify
047    B = A:Clone()
048    B.Value.Value = "Copper + 1"
049    B.Parent = player.PlayerGui
050    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
051    B.Disabled = false
052    wait(1.5)
053    script.Parent.Debounce.Value = false
054    print(script.Parent.Debounce.Value)
055    B:Destroy()
056 
057  end
058 
059  if hit.Parent.Name == "Tin" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
060    script.Parent.Debounce.Value = true
061    FolderName.Tin.Value = FolderName.Tin.Value + 1
062    player.PlayerGui.Inventory.Main.Frame.Items.Tin.TextButton.Text = "Tin: ".. FolderName.Tin.Value
063    A = game.ServerScriptService.Notify
064    B = A:Clone()
065    B.Value.Value = "Tin + 1"
066    B.Parent = player.PlayerGui
067    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
068    B.Disabled = false
069    wait(1.5)
070    script.Parent.Debounce.Value = false
071    B:Destroy()
072    print(script.Parent.Debounce.Value)
073 
074  end
075 
076  if hit.Parent.Name == "Gold" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
077    script.Parent.Debounce.Value = true
078    FolderName.Gold.Value = FolderName.Gold.Value + 1
079    player.PlayerGui.Inventory.Main.Frame.Items.Gold.TextButton.Text = "Gold: ".. FolderName.Gold.Value
080    A = game.ServerScriptService.Notify
081    B = A:Clone()
082    B.Value.Value = "Gold + 1"
083    B.Parent = player.PlayerGui
084    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
085    B.Disabled = false
086    wait(1.5)
087    B:Destroy()
088    script.Parent.Debounce.Value = false
089    print(script.Parent.Debounce.Value)
090 
091  end
092 
093  if hit.Parent.Name == "Iron" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
094    script.Parent.Debounce.Value = true
095    FolderName.Iron.Value = FolderName.Iron.Value + 1
096    player.PlayerGui.Inventory.Main.Frame.Items.Iron.TextButton.Text = "Iron: ".. FolderName.Iron.Value
097    A = game.ServerScriptService.Notify
098    B = A:Clone()
099    B.Value.Value = "Iron + 1"
100    B.Parent = player.PlayerGui
101    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
102    B.Disabled = false
103    wait(1.5)
104    B:Destroy()
105    script.Parent.Debounce.Value = false
106    print(script.Parent.Debounce.Value)
107 
108  end
109 
110 
111  if hit.Parent.Name == "Clay" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
112    script.Parent.Debounce.Value = true
113    FolderName.Clay.Value = FolderName.Clay.Value + 1
114    player.PlayerGui.Inventory.Main.Frame.Items.Clay.TextButton.Text = "Clay: ".. FolderName.Clay.Value
115    A = game.ServerScriptService.Notify
116    B = A:Clone()
117    B.Value.Value = "Clay + 1"
118    B.Parent = player.PlayerGui
119    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
120    B.Disabled = false
121    wait(1.5)
122    B:Destroy()
123    script.Parent.Debounce.Value = false
124    print(script.Parent.Debounce.Value)
125 
126  end
127 
128  if hit.Parent.Name == "Coal" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
129    script.Parent.Debounce.Value = true
130    FolderName.Coal.Value = FolderName.Coal.Value + 1
131    player.PlayerGui.Inventory.Main.Frame.Items.Coal.TextButton.Text = "Coal: ".. FolderName.Coal.Value
132    A = game.ServerScriptService.Notify
133    B = A:Clone()
134    B.Value.Value = "Coal + 1"
135    B.Parent = player.PlayerGui
136    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
137    B.Disabled = false
138    wait(1.5)
139    B:Destroy()
140    script.Parent.Debounce.Value = false
141    print(script.Parent.Debounce.Value)
142 
143  end
144 
145 
146 
147end
148script.Parent.Handle.Touched:Connect(Kill)
149end)
 View all 149 lines...

Thank you.

I am very sorry to tell you that not a lot of people are going to read this HUGE 149 lines script and try to find any mistakes. Try finding the problematic part. Sonnenroboter 336 — 5y

+ on the above comment Nowaha 459 — 5y

Here Eternalove_fan32 188 — 5y

1 answer

Answered by

Eternalove_fan32 188

5 years ago

You have made a folder in the ServerScriptService, in which the value of the resources are stored. Good idea, but did you make one folder per player??? If so, then I only have an idea to solve it that you may not like. It's easier to make the folder in the player and not in the ServerScriptService, as if you were doing a leaderstats:

01game.Players.PlayerAdded:Connect(function(player)
02local FolderName = Instance.new("Folder", player)
03FolderName.Name = player.Name
04local Coal = Instance.new("IntValue", FolderName)
05Coal.Name = "Coal"
06local Copper = Instance.new("IntValue",FolderName)
07Copper.Name = "Copper"
08local Iron = Instance.new("IntValue", FolderName)
09Iron.Name = "Iron"
10local Tin = Instance.new("IntValue", FolderName)
11Tin.Name = "Tin"
12local Gold = Instance.new("IntValue", FolderName)
13Gold.Name = "Gold"
14local Clay = Instance.new("IntValue", FolderName)
15Clay.Name = "Clay"
16local Rock = Instance.new("IntValue", FolderName)
17Rock.Name = "Rock"
18end)

So, I tried it myself and it works, your code should be like this (don't forget my code):

001game.ReplicatedStorage.Oof.OnServerEvent:Connect(function(player)
002--[Eternalove_fan32
003local FolderName = Instance.new("Folder", player)
004FolderName.Name = player.Name
005local Coal = Instance.new("IntValue", FolderName)
006Coal.Name = "Coal"
007local Copper = Instance.new("IntValue",FolderName)
008Copper.Name = "Copper"
009local Iron = Instance.new("IntValue", FolderName)
010Iron.Name = "Iron"
011local Tin = Instance.new("IntValue", FolderName)
012Tin.Name = "Tin"
013local Gold = Instance.new("IntValue", FolderName)
014Gold.Name = "Gold"
015local Clay = Instance.new("IntValue", FolderName)
016Clay.Name = "Clay"
017local Rock = Instance.new("IntValue", FolderName)
018Rock.Name = "Rock"
019--Eternalove_fan32]
020local playersname = player.Name
021local FolderName = player:FindFirstChild(playersname) -- Eternalove_fan32 was here (i modifie here your code)
022if FolderName then
023 
024  if script.Parent.InUse.Value == false then
025    script.Parent.InUse.Value = true
026    local kickAnimation = Instance.new("Animation")
027    kickAnimation.AnimationId = "rbxassetid://704173649"
028    local kickAnimationTrack = player.Character.Humanoid:LoadAnimation(kickAnimation)
029    kickAnimationTrack:Play()
030    wait(1.5)
031    script.Parent.InUse.Value = false
032 
033 
034 
035  else
036    print("Nope")
037  end
038end
039 
040local function Kill (hit)
041 
042 
043  if hit.Parent.Name == "Rock" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
044    script.Parent.Debounce.Value = true
045    FolderName.Stone.Value = FolderName.Stone.Value + 1
046    player.PlayerGui.Inventory.Main.Frame.Items.Stone.TextButton.Text = "Stone: ".. FolderName.Stone.Value
047    A = game.ServerScriptService.Notify
048    B = A:Clone()
049    B.Value.Value = "Rock + 1"
050    B.Parent = player.PlayerGui
051    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
052    print(playersname)
053    B.Disabled = false
054    wait(1.5)
055    B:Destroy()
056    script.Parent.Debounce.Value = false
057    print(script.Parent.Debounce.Value)
058  end
059 
060  if hit.Parent.Name == "Copper" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
061    script.Parent.Debounce.Value = true
062    FolderName.Copper.Value = FolderName.Copper.Value + 1
063    player.PlayerGui.Inventory.Main.Frame.Items.Copper.TextButton.Text = "Copper: ".. FolderName.Copper.Value
064    A = game.ServerScriptService.Notify
065    B = A:Clone()
066    B.Value.Value = "Copper + 1"
067    B.Parent = player.PlayerGui
068    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
069    B.Disabled = false
070    wait(1.5)
071    script.Parent.Debounce.Value = false
072    print(script.Parent.Debounce.Value)
073    B:Destroy()
074 
075  end
076 
077  if hit.Parent.Name == "Tin" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
078    script.Parent.Debounce.Value = true
079    FolderName.Tin.Value = FolderName.Tin.Value + 1
080    player.PlayerGui.Inventory.Main.Frame.Items.Tin.TextButton.Text = "Tin: ".. FolderName.Tin.Value
081    A = game.ServerScriptService.Notify
082    B = A:Clone()
083    B.Value.Value = "Tin + 1"
084    B.Parent = player.PlayerGui
085    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
086    B.Disabled = false
087    wait(1.5)
088    script.Parent.Debounce.Value = false
089    B:Destroy()
090    print(script.Parent.Debounce.Value)
091 
092  end
093 
094  if hit.Parent.Name == "Gold" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
095    script.Parent.Debounce.Value = true
096    FolderName.Gold.Value = FolderName.Gold.Value + 1
097    player.PlayerGui.Inventory.Main.Frame.Items.Gold.TextButton.Text = "Gold: ".. FolderName.Gold.Value
098    A = game.ServerScriptService.Notify
099    B = A:Clone()
100    B.Value.Value = "Gold + 1"
101    B.Parent = player.PlayerGui
102    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
103    B.Disabled = false
104    wait(1.5)
105    B:Destroy()
106    script.Parent.Debounce.Value = false
107    print(script.Parent.Debounce.Value)
108 
109  end
110 
111  if hit.Parent.Name == "Iron" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
112    script.Parent.Debounce.Value = true
113    FolderName.Iron.Value = FolderName.Iron.Value + 1
114    player.PlayerGui.Inventory.Main.Frame.Items.Iron.TextButton.Text = "Iron: ".. FolderName.Iron.Value
115    A = game.ServerScriptService.Notify
116    B = A:Clone()
117    B.Value.Value = "Iron + 1"
118    B.Parent = player.PlayerGui
119    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
120    B.Disabled = false
121    wait(1.5)
122    B:Destroy()
123    script.Parent.Debounce.Value = false
124    print(script.Parent.Debounce.Value)
125 
126  end
127 
128 
129  if hit.Parent.Name == "Clay" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
130    script.Parent.Debounce.Value = true
131    FolderName.Clay.Value = FolderName.Clay.Value + 1
132    player.PlayerGui.Inventory.Main.Frame.Items.Clay.TextButton.Text = "Clay: ".. FolderName.Clay.Value
133    A = game.ServerScriptService.Notify
134    B = A:Clone()
135    B.Value.Value = "Clay + 1"
136    B.Parent = player.PlayerGui
137    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
138    B.Disabled = false
139    wait(1.5)
140    B:Destroy()
141    script.Parent.Debounce.Value = false
142    print(script.Parent.Debounce.Value)
143 
144  end
145 
146  if hit.Parent.Name == "Coal" and script.Parent.Debounce.Value == false and script.Parent.InUse.Value == true then
147    script.Parent.Debounce.Value = true
148    FolderName.Coal.Value = FolderName.Coal.Value + 1
149    player.PlayerGui.Inventory.Main.Frame.Items.Coal.TextButton.Text = "Coal: ".. FolderName.Coal.Value
150    A = game.ServerScriptService.Notify
151    B = A:Clone()
152    B.Value.Value = "Coal + 1"
153    B.Parent = player.PlayerGui
154    hit.Parent.Damage.Value = hit.Parent.Damage.Value +1
155    B.Disabled = false
156    wait(1.5)
157    B:Destroy()
158    script.Parent.Debounce.Value = false
159    print(script.Parent.Debounce.Value)
160 
161  end
162 
163 
164 
165end
166script.Parent.Handle.Touched:Connect(Kill)
167end)
 View all 167 lines...

Why does this script give everyone the resource instead of just one person?

1 answer

Answer this question