How to place a block with the mouse using mouse.Hit.Position?

Asked by

5 years ago

I'm not having errors and it works, but it's really finicky. I have a LocalScript to do all the math and everything and then I send it through an event to place it with a ServerScript. I was hoping someone could improve my code to make it better. Here is the LocalScript inside StarterGui

01local uis = game:GetService('UserInputService')
02local plr = game.Players.LocalPlayer
03local mouse = plr:GetMouse()
04 
05if uis.MouseEnabled then
06    local OriginalMousePos = mouse.Hit.Position
07    mouse.Button1Down:Connect(function()
08        if plr.Mode.Value == 'Building' and plr.Block.Value ~= '' then --Mode is the mode they are in (None, Building, or Removing) and Block is the block they are using (string of the block's name)
09            local pos = mouse.Hit.Position
10            local x = math.floor(pos.X)
11            local y = math.floor(pos.Y)
12            local z = math.floor(pos.Z)
13            local bs = plr.BlockSize.Value --Size of the block
14            local base = workspace.Plots[plr.Plot.Value].Bases.Base --base they are building on
15            local downX = base.Position.X - (base.Size.X / 2)
16            local upX = base.Position.X + (base.Size.X / 2)
17            local downZ = base.Position.Z - (base.Size.Z / 2)
18            local upZ = base.Position.Z + (base.Size.Z / 2)
19            local coords = Vector3.new(x + bs/2, y + bs/2, z + bs/2)
20            if coords.X > downX and coords.X < upX and coords.Z > downZ and coords.Z < upZ then --Make sure they are in they're plot
21                game.ReplicatedStorage["Remove Passive"]:FireServer() --remove any pasiive blocks on the base
22                game.ReplicatedStorage["Place Block"]:FireServer(plr.Block.Value, coords, bs, false) --place a block
23            end
24        end
25    end)
26    while true do
27        wait()
28        if OriginalMousePos ~= mouse.Hit.Position and plr.Mode.Value == 'Building' and plr.Block.Value ~= '' then --If they still have the same position, there is no point in placing another passive block
29            local pos = mouse.Hit.Position
30            OriginalMousePos = pos --update OriginalMousePos
31            local x = math.floor(pos.X)
32            local y = math.floor(pos.Y)
33            local z = math.floor(pos.Z)
34            local bs = plr.BlockSize.Value --Size of the block
35            local base = workspace.Plots[plr.Plot.Value].Bases.Base
36            local downX = base.Position.X - (base.Size.X / 2)
37            local upX = base.Position.X + (base.Size.X / 2)
38            local downZ = base.Position.Z - (base.Size.Z / 2)
39            local upZ = base.Position.Z + (base.Size.Z / 2)
40            local coords = Vector3.new(x + bs/2, y + bs/2, z + bs/2)
41            if coords.X > downX and coords.X < upX and coords.Z > downZ and coords.Z < upZ then --Make sure they are inside the base
42                game.ReplicatedStorage["Remove Passive"]:FireServer() --remove any passive blocks
43                game.ReplicatedStorage["Place Block"]:FireServer(plr.Block.Value, Vector3.new(x + bs/2, y + bs/2, z + bs/2), bs, true) --place passive block. 
44            end
45        end
46    end
47end
 View all 47 lines...

If you are wondering why I added half the size of the block when firing the event to place the block, it's to center the block on the plot.

If you need it, here are the scripts for placing a block and removing a passive. Placing a Block in ServerScriptService

01local PS = game:GetService('PhysicsService')
02 
03game.ReplicatedStorage["Place Block"].OnServerEvent:Connect(function(plr, block, coords, bs, passive)
04    local block = game.ReplicatedStorage.Blocks[block]:Clone()
05    block.Position = coords
06    block.Size = Vector3.new(bs, bs, bs)
07    if passive then
08        block.CanCollide = false
09        block.Transparency = 0.5
10        block.Name = 'Passive'
11        PS:SetPartCollisionGroup(block, 'Building')
12    else
13        PS:SetPartCollisionGroup(block, 'Built')
14        plr.Blocks[block.Name].Value = plr.Blocks[block.Name].Value - 1
15        plr.Refresh.Value = true
16    end
17    block.Parent = workspace.Plots[plr.Plot.Value].Blocks
18end)

Removing a Passive in ServerScriptService

1game.ReplicatedStorage["Remove Passive"].OnServerEvent:Connect(function(plr)
2    pcall(function()
3        workspace.Plots[plr.Plot.Value].Blocks.Passive:Destroy()
4    end)
5end)

Thx in advance

You should do your calculations on the server to prevent hackers OBenjOne 190 — 5y

Alright, thx sheepposu 561 — 5y

How to place a block with the mouse using mouse.Hit.Position?

1 answer

Answer this question