Scripting Helpers is winding down operations and is now read-only. More info→

Admin script not kicking a player from the game?

Asked by

Warriorfoox 25

5 years ago

Edited 5 years ago

I've been making a UI-based Admin Script and when you type a player's name and run it it doesn't show any errors or kick them from the game.

001-- Script in ServerScriptService
002local SS = game:GetService("ServerStorage")
003local DSS = game:GetService("DataStoreService")
004 
005-- "Allowed" users
006local Staff = {"Gavfoox","Warriorfoox","Player1","WhistleCats"}
007local Banned = {}
008--local Staff = {GroupId=0; RankId=0;}
009 
010 
011local Players = game:GetService("Players")
012local _B = DSS:GetDataStore("DS1_BANS")
013local _C = {} do
014    for c=48,57 do table.insert(_C,string.char(c)) end
015    for c=65,90 do table.insert(_C,string.char(c)) end
016    for c=97,122 do table.insert(_C,string.char(c)) end
017end
018 
019local debounce = false
020local function CommandPanel(Player)
021    local _N = "???²?³????????????³?³??????"
022    local function newString(length)
023        if not length or length <= 0 then return '' end
024        math.randomseed(os.clock()^5)
025        _N = tostring(newString(length-1).._C[math.random(1,#_C)])
026    end
027    newString()
028    local panel = SS:WaitForChild("panel"):Clone()
029    panel.Parent = Player.PlayerGui; panel.Name = _N
030    local cmd = panel.main.commands
031    local trigger = Instance.new("StringValue", panel)
032    panel.TextButton.MouseButton1Click:Connect(function()
033        if debounce then
034            panel.main:TweenPosition(UDim2.new(.038,0,1.572,0), "Out", "Bounce", 1)
035            wait(1)
036            panel.main.Visible = false
037            debounce = false
038        elseif not debounce then
039            panel.main.Visible = true
040            panel.main:TweenPosition(UDim2.new(.038,0,.572,0), "In", "Bounce", 1)
041            wait(1)
042            debounce = true
043        end
044    end)
045    for i,v in pairs(cmd:GetChildren()) do
046        if v:IsA("TextButton") then
047            v.MouseButton1Click:Connect(function()
048                for d,b in pairs(cmd:GetChildren()) do
049                    if b:IsA("TextButton") then
050                        b.BackgroundColor3 = Color3.fromRGB(255,255,255)
051                        b.BackgroundTransparency = 1
052                        b.TextColor3 = Color3.fromRGB(0,0,0)
053                    end
054                end
055                v.BackgroundColor3 = Color3.fromRGB(43,156,255)
056                v.BackgroundTransparency = .55
057                v.TextColor3 = Color3.fromRGB(255,255,255)
058                panel.main.action:TweenSizeAndPosition(UDim2.new(1,0,.281,0), UDim2.new(0,0,.719,0), "In", "Bounce", .5)
059                wait(.5)
060                for i,v in pairs(panel.main.action:GetChildren()) do
061                    v.Visible = true
062                end
063                trigger.Value = v.Name
064            end)
065        end
066    end
067    panel.main.action.run.MouseButton1Click:Connect(function()
068        if trigger.Value == "a" then
069            pcall(function()
070                Players[panel.main.action.box.Text]:Kick("Don't break the rules. Kicked by "..Player.Name)
071            end)
072        elseif trigger.Value == "b" then
073            pcall(function()
074                _B:SetAsync(tostring(panel.main.action.box.Text), true)
075                Players[panel.main.action.box.Text]:Kick("You have been banned for breaking the rules. Banned by "..Player.Name)
076            end)
077        end
078    end)
079end
080 
081local function IsStaffMember(Player)
082--[[for _,s in pairs (Staff) do
083        if type(s) == "table" then
084            local Rank = Player:GetRankInGroup(s.GroupId)
085            if Rank >= (s.RankId) then return true end
086        end
087    end ]]
088    for _,s in pairs (Staff) do
089        if type(s) == "string" and string.lower(s) == string.lower(Player.Name) then
090            return true
091        end
092    end
093    return false
094end
095 
096function onPlayerAdded(Player)
097    if IsStaffMember(Player) then
098        CommandPanel(Player)
099        return
100    end
101    for i,v in pairs(Banned) do
102        if _B:GetAsync(Player.Name) then
103            Player:Kick("You are banned from this game.")
104        end
105    end
106end
107 
108Players.PlayerAdded:Connect(onPlayerAdded)
109for _,p in pairs(Players:GetPlayers()) do
110    onPlayerAdded(p)
111end
 View all 111 lines...

I do not actually know what the issue is here, but it isn't doing what it's expected to do when kicking/banning members.

Hey, ban me from your game and I'll change my name to bypass the ban because of how unsecure your ban system is. User#24403 69 — 5y

Will do Warriorfoox 25 — 5y

@incapaxx oof thats gotta sting Mr_Unlucky 1085 — 5y

Your Robux not mine Warriorfoox 25 — 5y

1 answer

Answered by

MessorAdmin 598

5 years ago

Edited 5 years ago

So theres alot that can be changed and made better on yours.

I made my script very quickly before I had to leave.

Heres an example, Id recommend you to base yours off of mine. I dont have much time to explain, im sorry but im being rushed out the door rn.

01local Players = game:GetService("Players")
02local Http = game:GetService("HttpService")
03local Datastore = game:GetService("DataStoreService")
04 
05local Admins = {"Player1"} -- If you are going to use player names, make a function to convert to userid
06local GroupIds = {
07    {
08        Id = 00,
09        Rank = 254
10    }
11}
12local NeededRank = 254
13 
14local Banned = Datastore:GetDataStore("Banned")
15 
16function GetUserId(p)
17    if type(p) == "number" then
18        return p
19    elseif type(p) == "userdata" then
20        return p.UserId
21    elseif type(p) == "string" then
22        if Players:FindFirstChild(p) then
23            return Players[p.Name].UserId
24        else
25            return tonumber(p)
26        end
27    end
28    return nil
29end
30 
31function GetPlayer(p)
32    if type(p) == "userdata" then
33        return p
34    elseif type(p) == "number" then
35        return Players:GetPlayerByUserId(p)
36    elseif type(p) == "string" then
37        if Players:FindFirstChild(p) then
38            return Players[p]
39        end
40    end
41    return nil
42end
43 
44function IsAdmin(p)
45    if Admins[p] or Admins[GetUserId(p)] then -- This way username or userid can be used
46        return true
47    end
48    for _,v in next,GroupIds do
49        local player = GetPlayer(p)
50        if player and player:IsInGroup(v.Id) and player:GetRankInGroup(v.Rank) >= NeededRank then
51            return true
52        end
53    end
54    return false
55end
56 
57-- For your guis, id recommand using a Module script
58 
59Players.PlayerAdded:Connect(function(p)
60    if Banned:GetAsync(p.UserId) then
61        p:Kick("Banned")
62    end
63    p.Chatted:Connect(function(m)
64        if IsAdmin(p) == true then
65            if m:sub(0,3) == "/e " then
66                m = m:sub(4)
67            end
68            if m:sub(0,5) == "!kick" then
69                local target = m:sub(7)
70                print(target)
71                local player = Players:FindFirstChild(target)
72                if player then
73                    player:Kick()
74                else
75                    print'i prob got the subbing wrong, just +1'
76                end
77            elseif m:sub(0,4) == "!ban" then
78                local target = m:sub(7)
79                print(target)
80                local player = Players:FindFirstChild(target)
81                if player then
82                    Banned:SetAsync(player.UserId, true)
83                    player:Kick()
84                end
85            end
86        end
87    end)
88end)
 View all 88 lines...

I will be back in about an hour to finish this. Im sorry, but heres a good basis for what you should use. Never use username, people can change their name and come right back. ALWAYS use UserId. MessorAdmin 598 — 5y

players can change their userid too, so whats the point cegberry 432 — 5y

lmao what players cant change their userid? Mr_Unlucky 1085 — 5y

LOL WHAT. Players cant change their UserId unless they are exploiting and are REALLY fast at changing it before the .PlayerAdded event gets to them connecting. MessorAdmin 598 — 5y

Admin script not kicking a player from the game?

1 answer

Answer this question