Scripting Helpers is winding down operations and is now read-only. More info→

Random brick help?

Asked by

CardboardRocks 215

10 years ago

This makes a brick that randomly goes up and down like the bars in this video. It has been working but if I stand on top of them they will teleport on top of me. To try to fix that, I've limited how far it goes up if someone's touching it, but the script is breaking. There are no errors, but whenever the brick is touched the brick stops. Any ideas why?

01touched = false
02prevnum = 0
03script.Parent.Touched:connect(function()
04    touched = true
05end)
06 
07script.Parent.TouchEnded:connect(function()
08    touched = false
09end)
10 
11 
12 
13while touched == false do
14    wait(.05)
15    script.Parent.CanCollide = false
16    a = math.random(3, 3)
17    script.Parent.Size = Vector3.new(script.Parent.Size.X, a, script.Parent.Size.Z)
18    script.Parent.Position = Vector3.new(script.Parent.Position.X, (a / 2) , script.Parent.Position.Z)
19    prevnum = a
20    script.Parent.CanCollide = true
21end
22 
23 
24while touched == true do
25    wait(.05)
26    if prevnum == 3 then
27        script.Parent.CanCollide = false
28        b = math.random(3, 4)
29        script.Parent.Size = Vector3.new(script.Parent.Size.X, b, script.Parent.Size.Z)
30        script.Parent.Position = Vector3.new(script.Parent.Position.X, (b / 2) , script.Parent.Position.Z)
31        print(prevnum)
32        prevnum = b
33        print(prevnum)
34        script.Parent.CanCollide = true
35    elseif prevnum == 4 then
36        script.Parent.CanCollide = false
37        b = math.random(3, 5)
38        script.Parent.Size = Vector3.new(script.Parent.Size.X, b, script.Parent.Size.Z)
39        script.Parent.Position = Vector3.new(script.Parent.Position.X, (b / 2) , script.Parent.Position.Z)
40        prevnum = b
41        script.Parent.CanCollide = true
42    elseif prevnum == 5 then
43        script.Parent.CanCollide = false
44        b = math.random(3, 6)
45        script.Parent.Size = Vector3.new(script.Parent.Size.X, b, script.Parent.Size.Z)
46        script.Parent.Position = Vector3.new(script.Parent.Position.X, (b / 2) , script.Parent.Position.Z)
47        prevnum = b
48        script.Parent.CanCollide = true
49    elseif prevnum == 6 then
50        script.Parent.CanCollide = false
51        b = math.random(3, 7)
52        script.Parent.Size = Vector3.new(script.Parent.Size.X, b, script.Parent.Size.Z)
53        script.Parent.Position = Vector3.new(script.Parent.Position.X, (b / 2) , script.Parent.Position.Z)
54        prevnum = b
55        script.Parent.CanCollide = true
56    elseif prevnum == 7 then
57        script.Parent.CanCollide = false
58        b = math.random(3, 7)
59        script.Parent.Size = Vector3.new(script.Parent.Size.X, b, script.Parent.Size.Z)
60        script.Parent.Position = Vector3.new(script.Parent.Position.X, (b / 2) , script.Parent.Position.Z)
61        prevnum = b
62        script.Parent.CanCollide = true
63    end
64end
 View all 64 lines...

Instead of script.Parent.Position, use script.Parent.CFrame to avoid that. Position checks for collisions when being set, and will move the part to the nearest point above the defined point where it will fit. CFrame doesn't bother with that. deaththerapy 60 — 10y

Vector3 clips, so when you change the Position of a part (Which requires a Vector3 value) and there is a part in the way, the part will get moved on top of the other one. CFrame doesn't clip. Basswobble 165 — 10y

1 answer

Answered by

adark 5487

10 years ago

Like death said in his comment, simply change every instance of script.Parent.Position = Vector3.new to script.Parent.CFrame = CFrame.new to stop it jumping on top of the the Player.

The reason it's stopping, however, is because each of those loops is set to only run once. When the brick gets Touched by any part (you should always do a sanity check to see if a Character touched it, by checking if Game.Players:GetPlayerFromCharacter(hit.Parent) returns anything), the first loop ends and the second begins. When the brick stops being Touched by any part (not just the one that first Touched it), the second loop will end and the script will then end.

Try using just this:

1while true do
2    wait(.05)
3    local a = math.random(3, 3) --local so that the variable is only used within the loop.
4    script.Parent.Size = Vector3.new(script.Parent.Size.X, a, script.Parent.Size.Z)
5    script.Parent.CFrame = CFrame3.new(script.Parent.Position.X, (a / 2) , script.Parent.Position.Z)
6end

(By the way, those bars aren't moving randomly in that video: they each represent the volume of a short band of frequencies of sound being played in the song at that moment. IIRC, the lower pitches are on the left, and the higher on the right.)

Thanks so much! CardboardRocks 215 — 10y

Random brick help?

1 answer

Answer this question