Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
0

0 Old game no longer works due to the removal of Experimental Mode what needs to be added?

Asked by
Dark_Alchemist 0
5 years ago

I am trying to track down (and it has been 2 years so learning all of this again) what I need to do to fix this script (I bet more are like this one).

local wspace = game.Workspace
local rumble = wspace.RumbleSoundPart
local magnitude = 0
local temp = 0
local temp2 = 0
local maxdistance = 18
while true do
    wait(0.5)
    for i,v in pairs(game.Players:GetChildren()) do
magnitude = ((v.Character.Head.Position - wspace.RumbleSoundPart.Position).magnitude) - 4
if magnitude < 1 then magnitude = 1 end
temp = (magnitude/maxdistance)
if temp > 0.4 then temp = 0.4 end
temp2 = 1 - temp
if temp2 > 0.4 then temp2 = 0.4 end
if temp2 < 0 then temp2 = 0 end
wspace.MusicScript.Sound.Volume = temp
wspace.MusicScript.Sound1.Volume = temp
wspace.MusicScript.Sound2.Volume = temp
wspace.RumbleSoundPart.Sound.Volume = temp2
    end
end

Error is Attempt to index field 'Character' (a nil value). What should I add to make sure the character is in the game before this gets called? I tried a few things but nothing seemed to work.

2 answers

Log in to vote
1
Answered by
mado 40
5 years ago

Use the CharacterAdded event of a player to get a reference to their character when it's replicated.

ex:

game.Players.PlayerAdded:Connect(function(player)
    player.CharacterAdded:Connect(function(character)
        -- Character is returned from the CharacterAdded event so you can just include it in the callback function as a parameter 
    end)
end)
0
;c Internal_1 344 — 5y
Ad
Log in to vote
0
Answered by
Internal_1 344 Moderation Voter
5 years ago 
local wspace = game.Workspace 
local rumble = wspace.RumbleSoundPart 
local magnitude = 0 
local temp = 0 
local temp2 = 0 
local maxdistance = 18 
while wait(0.5) do  
    for i,v in pairs(game.Players:GetChildren()) do 
        if not v.Character then
            repeat
                wait()
            until v.Character
        end
        v.Character:WaitForChild("Head")
        magnitude = ((v.Character.Head.Position - wspace.RumbleSoundPart.Position).magnitude) - 4 
        if magnitude < 1 then 
            magnitude = 1 
        end 
        temp = (magnitude/maxdistance) 
        if temp > 0.4 then 
            temp = 0.4 
        end 
        temp2 = 1 - temp 
        if temp2 > 0.4 then 
            temp2 = 0.4 
        end 
        if temp2 < 0 then 
            temp2 = 0 
        end 
        wspace.MusicScript.Sound.Volume = temp 
        wspace.MusicScript.Sound1.Volume = temp 
        wspace.MusicScript.Sound2.Volume = temp 
        wspace.RumbleSoundPart.Sound.Volume = temp2 
        --sf=string.format 
        --print(sf("temp is %f, temp2 is %f, magnitude is %f",temp, temp2, magnitude)) 
    end 
end

To wait for the character, you first have to make sure that the character isn't nil, and if it is, wait for it using a repeat-until loop. After that, you want to wait for all parts of the character to be added, hence the Character:WaitForChild("Head").

0
Will that repeat loop ever just go into a never ending loop? Dark_Alchemist 0 — 5y
0
I am now getting a warning in yellow telling me your solution has an infinite yield possibility. Crashing in it too. A lot of stuff is just flaky since they removed experimental and most no longer works. Dark_Alchemist 0 — 5y

Answer this question