Savable leaderboard won't save? Please Help

Asked by
5 years ago
I was trying to make this leaderboard savable. Player suppose to see their score even after they quit but for some reason, it won't work.
I wrote the script which is why obviously I am asking for help because its not working. So stop saying I didn't wrote the script. Yes, I used free models to base my script but that doesn't mean I didn't wrote it. Yes I was talking to you @eLunate If you can't help please let others help me instead.
Note: I noted in here where there might be a problem. I just can't figure which one.
001function onXPChanged(player, XP, level)
002    if XP.Value>=level.Value * 10 then
003        XP.Value = 0
004        level.Value = level.Value + 1
005    end
006end
007 
008function onLevelUp(player, XP, level)
009    local m = Instance.new("Hint")
010    m.Parent = game.Workspace
011    m.Text = player.Name .. " has leveled up!"
012    wait(3)
013    m.Parent = nil
014   player.Humanoid.Health = 0
015end
016 
017 
018function onPlayerRespawned(player)
019    wait(5)
020 
021    player.Character.Humanoid.Health = player.Character.Humanoid.Health + player.leaderstats.Level * 10
022 
023    player.Character.Humanoid.MaxHealth = player.Character.Humanoid.MaxHealth + player.leaderstats.Level * 10
024 
025end
026 
027local datastore = game:GetService("DataStoreService")
028local ds1 = datastore:GetDataStore("KillsSaveSystem")
029local ds2 = datastore:GetDataStore("CashSaveSystem")
030local ds3 = datastore:GetDataStore("DeathSaveSystem")
031local ds4 = datastore:GetDataStore("LevelSaveSystem")
032local ds5 = datastore:GetDataStore("XPSaveSystem")
033 
034function onPlayerEntered(newPlayer)
035 
036local stats = Instance.new(newPlayer)
037    stats.Name = "leaderstats"
038 
039local cash = Instance.new("IntValue",stats)
040    cash.Name = "Cash" 
041 
042local kills = Instance.new("IntValue",stats)
043    kills.Name = "Kills"
044 
045local deaths = Instance.new("IntValue",stats)
046    deaths.Name = "Deaths"
047 
048local level = Instance.new("IntValue",stats)
049   level.Name = "Level"
050 
051local xp = Instance.new("IntValue",stats)
052   xp.Name = "XP"
053 
054 kills.Value = ds1:GetAsync(newPlayer.UserId) or 0
055 ds1:SetAsync(newPlayer.UserId, kills.Value)
056 
057 cash.Value = ds2:GetAsync(newPlayer.UserId) or 0
058 ds2:SetAsync(newPlayer.UserId, cash.Value)
059 
060deaths.Value = ds3:GetAsync(newPlayer.UserId) or 0
061 ds3:SetAsync(newPlayer.UserId, deaths.Value)
062 
063level.Value = ds4:GetAsync(newPlayer.UserId) or 0
064 ds4:SetAsync(newPlayer.UserId, level.Value)
065 
066xp.Value = ds5:GetAsync(newPlayer.UserId) or 0
067 ds5:SetAsync(newPlayer.UserId, xp.Value)
068 
069   cash.Parent = stats
070    stats.Parent = newPlayer
071    kills.Parent = stats
072    deaths.Parent = stats
073   level.Parent = stats
074   xp.Parent = stats
075---updater: This area might be broken, I don't know whats wrong.
076    xp.Changed:connect(function() onXPChanged(newPlayer, xp, level) end)
077    level.Changed:connect(function() onLevelUp(newPlayer, xp, level) end)
078 
079        kills.Changed:connect(function()
080     ds1:SetAsync(newPlayer.UserId, kills.Value)
081     end)
082 
083        cash.Changed:connect(function()
084     ds2:SetAsync(newPlayer.UserId, cash.Value)
085     end)
086 
087        deaths.Changed:connect(function()
088     ds3:SetAsync(newPlayer.UserId, deaths.Value)
089     end)
090 
091        level.Changed:connect(function()
092    ds4:SetAsync(newPlayer.UserId, level.Value)
093    end)
094        xp.Changed:connect(function()
095    ds5:SetAsync(newPlayer.UserId, xp.Value)
096    end)
097 
098    end
099-------
100    local humanoid = newPlayer.Character.Humanoid
101 
102    humanoid.Died:connect(function() onHumanoidDied(humanoid, newPlayer) end )
103 
104    newPlayer.Changed:connect(function(property) onPlayerRespawn(property, newPlayer) end )
105 
106 
107    stats.Parent = newPlayer
108 
109end
110 
111function Send_DB_Event_Died(victim, killer)
112    local killername = "unknown"
113    if killer ~= nil then killername = killer.Name end
114    print(victim.Name, " was killed by ", killername)
115 
116    if shared["deaths"] ~= nil then
117        shared["deaths"](victim, killer)
118        print("Death event sent.")
119    end
120end
121 
122function Send_DB_Event_Kill(killer, victim)
123    print(killer.Name, " killed ", victim.Name)
124    if shared["kills"] ~= nil then
125        shared["kills"](killer, victim)
126        print("Kill event sent.")
127    end
128end
129 
130 
131 
132function onHumanoidDied(humanoid, player)
133    local stats = player:findFirstChild("leaderstats")
134    if stats ~= nil then
135        local deaths = stats:findFirstChild("Deaths")
136        deaths.Value = deaths.Value + 1
137 
138        local killer = getKillerOfHumanoidIfStillInGame(humanoid)
139 
140 
141        Send_DB_Event_Died(player, killer)
142        handleKillCount(humanoid, player)
143    end
144end
145 
146function onPlayerRespawn(property, player)
147 
148    if property == "Character" and player.Character ~= nil then
149        local humanoid = player.Character.Humanoid
150            local p = player
151            local h = humanoid
152            humanoid.Died:connect(function() onHumanoidDied(h, p) end )
153    end
154end
155 
156function getKillerOfHumanoidIfStillInGame(humanoid)
157 
158    local tag = humanoid:findFirstChild("creator")
159 
160    if tag ~= nil then
161 
162        local killer = tag.Value
163        if killer.Parent ~= nil then
164            return killer
165        end
166    end
167 
168    return nil
169end
170 
171function handleKillCount(humanoid, player)
172    local killer = getKillerOfHumanoidIfStillInGame(humanoid)
173    if killer ~= nil then
174        local stats = killer:findFirstChild("leaderstats")
175        if stats ~= nil then
176            local kills = stats:findFirstChild("Kills")
177           local cash = stats:findFirstChild("Cash")
178         local xp = stats:findFirstChild("XP")
179            if killer ~= player then
180                kills.Value = kills.Value + 1
181            cash.Value = cash.Value + 50
182            xp.Value = xp.Value + 3
183 
184            else
185                kills.Value = kills.Value - 0
186 
187            end
188            Send_DB_Event_Kill(killer, player)
189        end
190    end
191end
192 
193game.Players.ChildAdded:connect(onPlayerEntered)
 View all 193 lines...
I forgot that stats are suppose to be int. not named. Asher0606 36 — 5y
Savable leaderboard won't save? Please Help

1 answer

Answer this question
