part not getting properly GC'ed? help please?

Asked by

Myune 24

5 years ago

Edited 5 years ago

i am trying to make a part spawn in the workspace when a player is added in a folder named "PartsInWorkspace". my issue is, when the player leaves i dont think it deletes from the game and gets GC'ed.

my first issue is my game has ungodly amount of untracked data, about 500mb in a blank, new baseplate, and on a good day like 300mb, which makes my overall memory 700 and sometimes 450 to 600. i feel my only way is to work around it. otherwise i dont really know how i can do this game idea at all because when my player moves the data goes up and doesnt ever come back down, especially when i stop testing and reenter it, the memory jumps up about 10-50mb. when i test the game with Player1 etc, it drops to about 500mb maybe 450, but it rises over time and doesnt stop(this is in a blank baseplate with nothing, and usually happens when the player moves).

so i am testing the ability to work around it and i created this script (the original works fine, this is an example script of what im working with.) i am afraid it isnt getting GC'ed when the player leaves the game, because i still notice memory rising, it does drop but less than a single mb, and it rises faster than it drops. also, lua GC is usually at 0% which tells me nothing is really getting cleaned up.

i read about scope also, but it wasnt too clear. is this "out of scope"?

one more thing, i read about disconnecting events, but when i do it doesnt activate for other players so, i assume that cant be done with this. i read about "return" as well but i dont know what that does, or how to use it in this case very well.

Thanks, any help is appreciated the code is below:

01--/ all of this is located in  a ServerScript
02--/ im gonna use a part for example to prevent a wall of code
03--/can player added still reference the player?
04game.Players.PlayerAdded:Connect(function(player)
05    if player then
06        local parts = game.ServerStorage.parts:GetChildren()
07        for i=1,#parts do
08            local v = parts[i]:Clone()
09            if v.PartInfo.Value == player:WaitForChild("leaderstats").part.Value then
10                v.Name = player.Name
11                v.Parent = game.Workspace.PartsInWorkspace
12                for i,bc in pairs(v:GetChildren())do
13                    if (bc:IsA("BasePart")) then
14                        bc.BrickColor = BrickColor.new("Alder")
15                    end
16                end
17            end
18        end
19    end
20end)
21 
22-- when i remove the part i do this:
23game.Players.PlayerRemoving:Connect(function(player)
24    for i,p in pairs(game.Workspace.PartsInWorkspace:GetChildren())do
25        if (p:IsA("BasePart")) then
26            if p.Name == player.Name then
27                p:Destroy()
28            end
29        end
30    end
31end)
 View all 31 lines...

You really need to indent and format your code properly BlueTaslem 18071 — 5y

i updated it, does it look better now? o: Myune 24 — 5y

Please do not use GC, it confused me up until I read the script to find GetChildren. Also, how are you getting memory values (through Studio, Developer Console[F9 screen] on live server, task manager)? M39a9am3R 3210 — 5y

Don’t use get children? What alternative should I use? I meant garbage collect, but I am getting memory through F9 in the developer console, I don’t feel like this is getting cleaned up when the player leaves, I have bad memory issues on a blank baseplate Myune 24 — 5y

part not getting properly GC'ed? help please?

Answer this question